MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0030115Open CASCADE[OCCT] OCCT:Data Exchangepublic2018-09-06 12:262018-09-12 14:06
Reporterskl 
Assigned Toskl 
PrioritynormalSeverityfeature 
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.4.0*Fixed in Version 
Summary0030115: Data Exchange - Implementation of import from XCAF to VRML.
DescriptionIt is needed to implement import from TDocStd_Document to VRML format with supporting structure, colors and names for shapes represented by triangulation.
TagsNo tags attached.
Test case number
Attached Files

- Relationships

-  Notes
(0079013)
git (administrator)
2018-09-06 12:41

Branch CR30115 has been created by skl.

SHA-1: 9ca6468f9105871054ff48c16f678c598cd4eabf


Detailed log of new commits:

Author: skl
Date: Thu Sep 6 11:18:13 2018 +0300

    0030115: Implementation of import from XCAF to VRML.
(0079014)
kgv (developer)
2018-09-06 13:00

+    if (aFace.IsNull() == Standard_False) {

Please don't use this style in new code - IsNull() returns a "bool" and there is no need to compare it with "true" or "false" like this.

+  filebuf aFoc;
+  ostream outStream(&aFoc);
+  if (aFoc.open(theFile, ios::out))

This is broken for working with UNICODE file paths on Windows - please use OSD_OpenStream() instead (and correct the other place in file too).
(0079016)
git (administrator)
2018-09-06 14:02

Branch CR30115 has been updated forcibly by skl.

SHA-1: 4a83b140a5dd6da2e7372cca355f66d25c9c7bae
(0079080)
git (administrator)
2018-09-10 11:59

Branch CR30115 has been updated forcibly by skl.

SHA-1: 25f30ecc8193f1a7f0c56a7c3965383ce8db03d0
(0079081)
git (administrator)
2018-09-10 12:14

Branch CR30115 has been updated forcibly by skl.

SHA-1: 877ae5347f373464afc6739ddbcaa36ddbbdfdd9
(0079128)
git (administrator)
2018-09-11 17:17

Branch CR30115_1 has been created by anv.

SHA-1: a72abface182dc355ac5d1bd8ccea483a03fee76


Detailed log of new commits:

Author: anv
Date: Tue Sep 11 17:14:24 2018 +0300

    OCCT Samples dependencies fix
(0079131)
kgv (developer)
2018-09-11 18:15

--- a/samples/CSharp/OCCTProxy_D3D/OCCTProxy_D3D.vcxproj
+++ b/samples/CSharp/OCCTProxy_D3D/OCCTProxy_D3D.vcxproj
@@ -94,6 +94,7 @@
       <DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
     </ClCompile>
     <Link>
+      <AdditionalDependencies>TKLCAF.lib;%(AdditionalDependencies)</AdditionalDependencies>
       
<OutputFile>$(OutDir)OCCTProxy_D3D.dll</OutputFile>

This is inconsistent to other linkage properties of projects OCCTProxy.vcxproj, OCCTProxy_D3D.vcxproj, which defined libraries using pragma in .cpp.
(0079132)
kgv (developer)
2018-09-11 18:50
edited on: 2018-09-11 18:51

> VRML provides no capability to define units of measure.
> All linear distances are assumed to be in meters and all angles are in radians.

  /**
   * Constructor.
   * @param theScene
   *   Scene receiving all Vrml data.
   * @param theScale
   *   Scale factor, considering that VRML standard specifies coordinates in
   *   meters. So if your data are in mm, you should provide theScale=0.001
   */
  inline VrmlData_ShapeConvert (VrmlData_Scene&     theScene,
                                const Standard_Real theScale = 1.)
    : myScene (theScene),
      myScale (theScale)
  {}

I don't see unit scale being set within the patch, so that supposedly generated file has wrong length units
(considering that OCCT uses millimeters ("xstep.gui.unit") by default and VRML is forced to meters).

(0079148)
git (administrator)
2018-09-12 12:52

Branch CR30115_1 has been updated forcibly by anv.

SHA-1: 231e9406454f7cfbe75521ebe2415108984b9f50

- Issue History
Date Modified Username Field Change
2018-09-06 12:26 skl New Issue
2018-09-06 12:26 skl Assigned To => gka
2018-09-06 12:41 git Note Added: 0079013
2018-09-06 12:55 kgv Assigned To gka => skl
2018-09-06 12:55 kgv Severity minor => feature
2018-09-06 12:55 kgv Status new => assigned
2018-09-06 12:55 kgv Summary Implementation of import from XCAF to VRML. => Data Exchange - Implementation of import from XCAF to VRML.
2018-09-06 13:00 kgv Note Added: 0079014
2018-09-06 14:02 git Note Added: 0079016
2018-09-10 11:59 git Note Added: 0079080
2018-09-10 12:14 git Note Added: 0079081
2018-09-11 17:17 git Note Added: 0079128
2018-09-11 18:15 kgv Note Added: 0079131
2018-09-11 18:50 kgv Note Added: 0079132
2018-09-11 18:51 kgv Note Edited: 0079132 View Revisions
2018-09-12 12:52 git Note Added: 0079148


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker