View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0030055CommunityOCCT:Modeling Algorithmspublic2018-08-10 00:512023-03-07 14:10
Reporterdipts Assigned Toakaftasev  
PrioritynormalSeveritymajor 
Status verifiedResolutionfixed 
PlatformWindowsOSVC++ 2015 
Product Version7.3.0 
Target Version7.7.1 
Summary0030055: Modeling Algorithms - BRepOffset_MakeOffset throws "TopoDS_Vertex hasn't gp_Pnt" in intersection mode
DescriptionAn exception was caught 0000019119B769B0 : Standard_NullObject: BRep_Tool:: TopoDS_Vertex hasn't gp_Pnt
bgerror failed to handle background error.
    Original error: ** Exception ** 0000019119B769B0 : Standard_NullObject: BRep_Tool:: TopoDS_Vertex hasn't gp_Pnt
    Error in bgerror:
Steps To Reproducerestore Loft.brep
thickshell res Loft 1 i
TagsNo tags attached.
Test case numberoffset/bugs/bug30055

Attached Files

  • Loft.brep (8,508 bytes)

Activities

dipts

2018-08-10 00:51

developer  

Loft.brep (8,508 bytes)

git

2022-11-25 12:14

administrator   ~0112303

Branch CR30055 has been created by ifv.

SHA-1: de2c2424b3f61b3a37c556ea454fb2d9486b46f9


Detailed log of new commits:

Author: ifv
Date: Fri Nov 25 12:11:10 2022 +0300

    0030055: BRepOffset_MakeOffset throws "TopoDS_Vertex hasn't gp_Pnt" in intersection mode

git

2022-11-29 12:12

administrator   ~0112377

Branch CR30055 has been updated forcibly by ifv.

SHA-1: 332043338ef1e9a5e7f4e48d42f2a21f576b0fde

git

2022-12-02 12:57

administrator   ~0112471

Branch CR30055 has been updated forcibly by ifv.

SHA-1: af3381f0088027ec5e9f775727f02e6deeb8f666

git

2022-12-05 15:15

administrator   ~0112495

Branch CR30055 has been updated forcibly by ifv.

SHA-1: ef83b98dcad177ab081d2b89ea0a996d9fcd6ade

git

2022-12-12 15:29

administrator   ~0112610

Branch CR30055 has been updated forcibly by ifv.

SHA-1: 4989e2e143fea1b540827ad2292f354850661750

ifv

2022-12-13 17:10

developer   ~0112616

Branch CR30055 is ready for review

Test results:
http://jenkins-test-10.nnov.opencascade.com/view/CR30055-master-ifv/view/COMPARE/

emv

2022-12-14 10:50

developer   ~0112620

src/BRepOffset/BRepOffset_Analyse.cxx
- Could you please add description to the new method CheckMixedContinuity
- I think it would be great if there would be a comment explaining what the first and second loops with LocalAnalysis_SurfaceContinuity do. Otherwise it is unclear why we stop in first in case of 'Done()' and continue in second.
- I think the following line
    if ((aCont.IsG1() && isG1) || (!aCont.IsG1() && !isG1))

 may be replaced with
    if (aCont.IsG1== isG1)


src/BRepOffset/BRepOffset_MakeOffset.cxx
- Also would be great to have a comment why we have an edge without any vertices
      if (V3.IsNull() && V4.IsNull())


tests/bugs/modalg_2/bug5805_5
tests/bugs/modalg_3/bug5805_6
tests/perf/modalg/bug26443_1
- Look like regressions. Before we obtained what looked like a correct results.

tests/bugs/modalg_2/bug5805_3 and other tests
- I don't think it is necessary to dump the initial shape in case of empty result shape. It may confuse the developer sometime into thinking that the result is obtained. Better keep the window empty.

git

2022-12-16 11:17

administrator   ~0112646

Branch CR30055 has been updated forcibly by ifv.

SHA-1: 04f53603b73cd53e9956dc5553cbf86c995e91f1

git

2022-12-19 10:42

administrator   ~0112683

Branch CR30055 has been updated forcibly by ifv.

SHA-1: 1d006dc9c622894a4aaaa1f25d3189daea24d84c

ifv

2022-12-19 10:47

developer   ~0112684

Branch CR30055 is ready for review

Test results:
http://jenkins-test-10.nnov.opencascade.com/view/CR30055-master-ifv/view/COMPARE/

git

2023-01-26 18:17

administrator   ~0113001

Branch CR30055_1 has been created by andrey.kaftasev_159541.

SHA-1: 05f8f04a514864e78bc1567fdee192b6f9babce4


Detailed log of new commits:

Author: akaftasev
Date: Thu Jan 26 18:17:31 2023 +0300

    0030055: BRepOffset_MakeOffset throws "TopoDS_Vertex hasn't gp_Pnt" in intersection mode
    
    Diagnostic of mixed connectivity of faces along common edge is added.
    If algorithm finds such pair of faces, it stops working with special error code.

git

2023-02-03 19:12

administrator   ~0113067

Branch CR30055_1 has been updated forcibly by andrey.kaftasev_159541.

SHA-1: 86635dfbec4deb5059969d1e33d3716ae36a9f42

git

2023-02-06 14:15

administrator   ~0113081

Branch CR30055_1 has been updated forcibly by andrey.kaftasev_159541.

SHA-1: 44be123039169a45d652850f8a4b70579f5ca535

akaftasev

2023-02-06 19:52

developer   ~0113089

Please, integrate branch:
OCCT - CR30055_1

vglukhik

2023-02-12 17:59

administrator   ~0113114

Combination -
OCCT branch : SHA -
Products branch : SHA -
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18869.980000000163 / 18416.460000000254 [+2.46%]
Products
Total CPU difference: 12095.80000000011 / 12108.910000000147 [-0.11%]
Windows-64-VC142:
OCCT
Total CPU difference: 20579.4375 / 20947.5625 [-1.76%]
Products
Total CPU difference: 13954.984375 / 14923.015625 [-6.49%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2023-02-12 18:17

administrator   ~0113118

Branch CR30055 has been deleted by mnt.

SHA-1: 1d006dc9c622894a4aaaa1f25d3189daea24d84c

git

2023-02-12 18:17

administrator   ~0113119

Branch CR30055_1 has been deleted by mnt.

SHA-1: 44be123039169a45d652850f8a4b70579f5ca535

Related Changesets

occt: master 44be1230

2023-02-06 14:15:35

akaftasev

Details Diff		 0030055: BRepOffset_MakeOffset throws "TopoDS_Vertex hasn't gp_Pnt" in intersection mode

Diagnostic of mixed connectivity of faces along common edge is added.
If algorithm finds such pair of faces, it stops working with special error code.		 Affected Issues
0030055
mod - src/BRepOffset/BRepOffset_Analyse.cxx Diff File
mod - src/BRepOffset/BRepOffset_Error.hxx Diff File
mod - src/BRepOffset/BRepOffset_MakeOffset.cxx Diff File
mod - src/BRepTest/BRepTest_FeatureCommands.cxx Diff File
mod - src/ChFiDS/ChFiDS_TypeOfConcavity.hxx Diff File
mod - tests/bugs/modalg_2/bug5805_3 Diff File
mod - tests/bugs/modalg_2/bug5805_4 Diff File
mod - tests/bugs/modalg_2/bug5805_5 Diff File
mod - tests/bugs/modalg_3/bug5805_6 Diff File
mod - tests/offset/bugs/bug26288 Diff File
mod - tests/offset/bugs/bug27913 Diff File
add - tests/offset/bugs/bug30055 Diff File
mod - tests/offset/bugs/bug5806 Diff File
mod - tests/offset/shape/A2 Diff File
mod - tests/offset/shape/A3 Diff File
mod - tests/perf/modalg/bug26443_1 Diff File

Issue History

Date Modified Username Field Change
2018-08-10 00:51 dipts New Issue
2018-08-10 00:51 dipts Assigned To => msv
2018-08-10 00:51 dipts File Added: Loft.brep
2019-08-12 17:45 msv Target Version 7.4.0 => 7.5.0
2020-09-14 22:53 msv Target Version 7.5.0 => 7.6.0
2021-08-29 18:51 msv Target Version 7.6.0 => 7.7.0
2022-10-24 10:43 szy Target Version 7.7.0 => 7.8.0
2022-10-31 10:07 szy Assigned To msv => ifv
2022-10-31 10:07 szy Status new => assigned
2022-11-25 12:14 git Note Added: 0112303
2022-11-29 12:12 git Note Added: 0112377
2022-12-02 12:57 git Note Added: 0112471
2022-12-05 15:15 git Note Added: 0112495
2022-12-12 15:29 git Note Added: 0112610
2022-12-13 17:07 ifv Test case number => offset/bugs/bug30055
2022-12-13 17:10 ifv Assigned To ifv => msv
2022-12-13 17:10 ifv Status assigned => resolved
2022-12-13 17:10 ifv Note Added: 0112616
2022-12-13 18:54 msv Assigned To msv => emv
2022-12-14 10:50 emv Note Added: 0112620
2022-12-14 10:50 emv Assigned To emv => ifv
2022-12-14 10:50 emv Status resolved => assigned
2022-12-16 11:17 git Note Added: 0112646
2022-12-19 10:42 git Note Added: 0112683
2022-12-19 10:47 ifv Assigned To ifv => emv
2022-12-19 10:47 ifv Status assigned => resolved
2022-12-19 10:47 ifv Note Added: 0112684
2022-12-29 15:24 ebelouso Assigned To emv => akaftasev
2023-01-26 18:17 git Note Added: 0113001
2023-02-03 19:12 git Note Added: 0113067
2023-02-04 16:18 dpasukhi Summary BRepOffset_MakeOffset throws "TopoDS_Vertex hasn't gp_Pnt" in intersection mode => Modeling Algorithms - BRepOffset_MakeOffset throws "TopoDS_Vertex hasn't gp_Pnt" in intersection mode
2023-02-06 14:15 git Note Added: 0113081
2023-02-06 19:52 akaftasev Assigned To akaftasev => bugmaster
2023-02-06 19:52 akaftasev Status resolved => reviewed
2023-02-06 19:52 akaftasev Note Added: 0113089
2023-02-12 17:50 akaftasev Changeset attached => occt master 44be1230
2023-02-12 17:50 akaftasev Assigned To bugmaster => akaftasev
2023-02-12 17:50 akaftasev Status reviewed => verified
2023-02-12 17:50 akaftasev Resolution open => fixed
2023-02-12 17:59 vglukhik Note Added: 0113114
2023-02-12 18:17 git Note Added: 0113118
2023-02-12 18:17 git Note Added: 0113119
2023-03-07 14:10 dpasukhi Target Version 7.8.0 => 7.7.1