MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0030052Community[OCCT] OCCT:Data Exchangepublic2018-08-09 19:152020-03-22 11:40
Reporterthomhong 
Assigned Tobugmaster 
PrioritynormalSeverityminor 
StatusverifiedResolutionfixed 
PlatformWindowsOSVC++ 2015OS Version64 bit
Product Version[OCCT] 7.3.0 
Target Version[OCCT] 7.5.0*Fixed in Version 
Summary0030052: Data Exchange - STEP import missing surfaces
DescriptionOuter cylinder surfaces missing on attached STEP files when importing into OpenCASCADE.
Steps To ReproduceReproduced by ImportExport sample project (OCC 7.3 - Debug x64)
TagsNo tags attached.
Test case numberNot required
Attached Fileszip file icon STEP Import Issues.zip (381,095 bytes) 2018-08-09 19:15
zip file icon OCC-Dec2019.zip (898,326 bytes) 2019-12-06 00:30

- Relationships

-  Notes
(0089403)
thomhong (reporter)
2019-12-06 00:31

A few more examples of the same issue, still occurs in 7.4.0 (also reproducible in CAD Assistant).
(0089463)
mahaidong (reporter)
2019-12-11 08:36

where is the code? I can not find the ImportExport sample project in <occt>/smaples
(0090279)
szy (administrator)
2020-02-03 11:13

See the code at ..\opencascade-7.4.0\samples\mfc\standard\Common\ImportExport\
(0090280)
gka (developer)
2020-02-03 12:03

Sources of ImportExport sample can be found by path:

opencascade-7.4.0\samples\mfc\standard\05_ImportExport\src
(0090290)
git (administrator)
2020-02-04 15:32

Branch CR30052 has been created by gka.

SHA-1: 2c19e8aadddf6fce69325e5d4c0ba29e2aac66f9


Detailed log of new commits:

Author: gka
Date: Tue Feb 4 14:57:01 2020 +0300

    0030052: Data Exchange - STEP import missing surfaces
    
    Fix to detect tangential edges to split line for case when edge lies out of period on the periodical surface
(0090605)
git (administrator)
2020-02-20 16:03

Branch CR30052_1 has been created by gka.

SHA-1: bd236506a18c058826270ff0d7bff2e80c6c77f0


Detailed log of new commits:

Author: gka
Date: Tue Feb 18 16:56:19 2020 +0300

    0030052: Data Exchange - STEP import missing surfaces
    
    Added call of the fix self-intersection before call addition of the seam edge.
    Activated method to remove faces having small area.
    Added merging adjacent vertices having distance less than sum of their tolerances.
(0090606)
git (administrator)
2020-02-20 19:01

Branch CR30052_2 has been created by gka.

SHA-1: ba9b2f775f3c8e9271091a97714398341c45c86e


Detailed log of new commits:

Author: gka
Date: Tue Feb 18 16:56:19 2020 +0300

    0030052: Data Exchange - STEP import missing surfaces
    
    Added call of the fix self-intersection before call addition of the seam edge.
    Activated method to remove faces having small area.
    Comparison distance between vertex and split point with tolerance of edge was excluded in order to avoid creation of the small edges
(0090611)
git (administrator)
2020-02-21 14:30

Branch CR30052_2 has been updated by gka.

SHA-1: 62592b2622a20b455383d9a35c7790542085473d


Detailed log of new commits:

Author: gka
Date: Fri Feb 21 14:28:41 2020 +0300

    Additional commit to avoid regressions

(0090612)
git (administrator)
2020-02-21 14:33

Branch CR30052_2 has been updated forcibly by gka.

SHA-1: cfbb87a343e5e83b64be21dc071d64903bcd6693
(0090615)
git (administrator)
2020-02-21 18:27

Branch CR30052_2 has been updated by gka.

SHA-1: 223338bb6ac6b9f577ed5d7c3c0e45447098926d


Detailed log of new commits:

Author: gka
Date: Fri Feb 21 18:26:37 2020 +0300

    Modification to avoid regression due to changing mode for FixSmallAreaWireMode

(0090616)
git (administrator)
2020-02-21 18:30

Branch CR30052_2 has been updated forcibly by gka.

SHA-1: 20b7b885601f867e5f716ad58e8a105b50c0b500
(0090683)
git (administrator)
2020-02-26 12:05

Branch CR30052_1 has been updated forcibly by gka.

SHA-1: 06a823101abe7640bf27b350594c2bad63ee6d1f
(0090688)
git (administrator)
2020-02-26 16:36

Branch CR30052_3 has been created by gka.

SHA-1: f26b9d881c50715ff3019d72d886c6a7f15b374b


Detailed log of new commits:

Author: gka
Date: Wed Feb 26 16:35:58 2020 +0300

    0030052: Data Exchange - STEP import missing surfaces
    
    Correction in the ShapeFix_ComposeShell:
     to avoid splitting edge when split point lies in the limits of the tolerance of the vertex.
     to correct shift of the pcurves for case when initial shift is more than 1 in the method ShapeFix_ComposeShell::SplitByLine
(0090712)
git (administrator)
2020-02-27 19:13

Branch CR30052_1 has been updated by gka.

SHA-1: 859fc09b22bea89f11c2bf539315c208a130aae7


Detailed log of new commits:

Author: gka
Date: Thu Feb 27 19:13:11 2020 +0300

    Modification in the ShapeFix

(0090727)
git (administrator)
2020-02-28 18:13

Branch CR30052_4 has been created by gka.

SHA-1: 6da2f271ea3c8dcbd4ecb36e450ad55ac0cebeae


Detailed log of new commits:

Author: gka
Date: Wed Feb 26 16:35:58 2020 +0300

    0030052: Data Exchange - STEP import missing surfaces
    
    Correction in the ShapeFix_ComposeShell:
     to avoid splitting edge when split point lies in the limits of the tolerance of the vertex.
     to correct shift of the pcurves for case when initial shift is more than 1 in the method ShapeFix_ComposeShell::SplitByLine
    In the method ShapeFix_Face::FixMissingSeam added removing small edges having length less than working precision and removing wires having area less than working precision
(0090728)
git (administrator)
2020-02-28 18:19

Branch CR30052_4 has been updated forcibly by gka.

SHA-1: 2dc55736b37aa798d12a3b10549524ad2130a52e
(0090752)
git (administrator)
2020-03-02 11:36

Branch CR30052_4 has been updated forcibly by gka.

SHA-1: ceeb9abc42347afb4f5ec1752dc9cf4a6f513a14
(0090761)
git (administrator)
2020-03-02 14:38

Branch CR30052_5 has been created by gka.

SHA-1: ceeb9abc42347afb4f5ec1752dc9cf4a6f513a14


No new revisions were added by this update.
(0090804)
git (administrator)
2020-03-03 20:14

Branch CR30052_5 has been updated forcibly by gka.

SHA-1: df1bf819e14ff69b445f65bf18fabbbfa4940c25
(0090859)
git (administrator)
2020-03-06 20:11

Branch CR30052_5 has been updated forcibly by gka.

SHA-1: 21ba75a14e137aabd4fb96deafa05c6b2b7f6b29
(0090887)
git (administrator)
2020-03-10 19:37

Branch CR30052_5 has been updated forcibly by gka.

SHA-1: 0ba6f89b476b6255b7ff3223efeb0b32befb06bd
(0090900)
git (administrator)
2020-03-11 18:15

Branch CR30052_5 has been updated forcibly by gka.

SHA-1: 103a93e534a06dd10f7811a538b7fadc71caa91f
(0090909)
git (administrator)
2020-03-12 10:58

Branch CR30052_5 has been updated forcibly by gka.

SHA-1: 58f51c25b35954a1e845e04fa96c82ed9dffa79a
(0090916)
gka (developer)
2020-03-12 16:28

Please find results of tests by path:

http://occt-tests/CR30052_5-master-gka-OCCT/Windows-64-VC14/diff_summary.htm [^]
http://occt-tests/CR30052_5-master-gka-OCCT/Debian80-64/diff_summary.html [^]
http://occt-tests/CR30052_5-master-gka-Products/Windows-64-VC14/summary.html [^]
http://occt-tests/CR30052_5-master-gka-Products/Debian80-64/diff_summary.html [^]
(0090917)
gka (developer)
2020-03-12 16:29

Branch CR30052_5 is ready to be reviewed
(0090993)
git (administrator)
2020-03-17 19:23

Branch CR30052_5 has been updated forcibly by abv.

SHA-1: 998695eac8bdbcaef58ebd3d7a4a63492c7acff4
(0091000)
git (administrator)
2020-03-18 09:50

Branch CR30052_5 has been updated forcibly by abv.

SHA-1: d58f60ccec37b5bbe2f4f78d3fbdda80c75e5dcd
(0091026)
abv (manager)
2020-03-18 13:38

Reviewed, please integrate. The branch has been rebased on current master and cleared from irrelevant changes in whitespaces. Tests are OK, see Jenkins job CR30052_5-master-gka-OCCT
(0091042)
abv (manager)
2020-03-19 10:19

I confirm that the branches to be integrated are those already taken in WEEK-12:
OCCT: CR30052_5 at d58f60ccec37b5bbe2f4f78d3fbdda80c75e5dcd
Products: CR30052_Products at 0e62afee1394dc5e56d5045169e2b9c65892dc6a
(0091126)
git (administrator)
2020-03-22 11:31

Branch CR30052_5 has been deleted by inv.

SHA-1: d58f60ccec37b5bbe2f4f78d3fbdda80c75e5dcd
(0091133)
git (administrator)
2020-03-22 11:31

Branch CR30052_4 has been deleted by inv.

SHA-1: ceeb9abc42347afb4f5ec1752dc9cf4a6f513a14
(0091134)
git (administrator)
2020-03-22 11:31

Branch CR30052_1 has been deleted by inv.

SHA-1: 859fc09b22bea89f11c2bf539315c208a130aae7
(0091135)
git (administrator)
2020-03-22 11:31

Branch CR30052_3 has been deleted by inv.

SHA-1: f26b9d881c50715ff3019d72d886c6a7f15b374b
(0091136)
git (administrator)
2020-03-22 11:31

Branch CR30052_2 has been deleted by inv.

SHA-1: 20b7b885601f867e5f716ad58e8a105b50c0b500
(0091137)
git (administrator)
2020-03-22 11:31

Branch CR30052 has been deleted by inv.

SHA-1: 2c19e8aadddf6fce69325e5d4c0ba29e2aac66f9
(0091154)
bugmaster (administrator)
2020-03-22 11:40

Combination -
OCCT branch : IR-2020-03-20
master SHA - 7ef1f9b7c1d9301c158a593dc5facb5a33450318
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : IR-2020-03-20 SHA - f10b867b449ebfa55e0a3c8cb276ae511f9cf7f2
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16845.960000000137 / 16685.300000000094 [+0.96%]
Products
Total CPU difference: 11305.960000000074 / 11298.700000000106 [+0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 18268.609375 / 18088.765625 [+0.99%]
Products
Total CPU difference: 13110.078125 / 13084.390625 [+0.20%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

- Related Changesets
occt: master 6a9f983a
Timestamp: 2020-02-26 13:35:58
Author: gka
Committer: bugmaster
Details ] Diff ]
0030052: Data Exchange - STEP import missing surfaces

Changes made for #31233 are reverted.

Correction in the ShapeFix_ComposeShell:
 Modification of the method SplitByLine in order to find all points of the intersection for case when initial curve shifts in the positive or negative direction
 to avoid splitting edge when split point lies in the limits of the tolerance of the vertex.
 to correct shift of the pcurves for case when initial shift is more than 1 in the method ShapeFix_ComposeShell::SplitByLine

In the method ShapeFix_Face::FixMissingSeam added removing small edges having length less than working precision and removing wires having area less than working precision

Modified test cases; added test for related issue: bugs step bug31301
mod - src/ShapeFix/ShapeFix_ComposeShell.cxx Diff ] File ]
mod - src/ShapeFix/ShapeFix_ComposeShell.hxx Diff ] File ]
mod - src/ShapeFix/ShapeFix_Face.cxx Diff ] File ]
mod - src/ShapeFix/ShapeFix_Wire.cxx Diff ] File ]
mod - tests/bugs/modalg_7/bug30273 Diff ] File ]
add - tests/bugs/step/bug30052_1 Diff ] File ]
add - tests/bugs/step/bug30052_2 Diff ] File ]
add - tests/bugs/step/bug30052_3 Diff ] File ]
add - tests/bugs/step/bug30052_4 Diff ] File ]
add - tests/bugs/step/bug30052_5 Diff ] File ]
add - tests/bugs/step/bug31301 Diff ] File ]
mod - tests/de/step_1/E4 Diff ] File ]
mod - tests/de/step_1/F8 Diff ] File ]
mod - tests/de/step_1/G1 Diff ] File ]
mod - tests/de/step_3/E6 Diff ] File ]

- Issue History
Date Modified Username Field Change
2018-08-09 19:15 thomhong New Issue
2018-08-09 19:15 thomhong Assigned To => gka
2018-08-09 19:15 thomhong File Added: STEP Import Issues.zip
2019-12-06 00:30 thomhong File Added: OCC-Dec2019.zip
2019-12-06 00:31 thomhong Note Added: 0089403
2019-12-11 08:36 mahaidong Note Added: 0089463
2019-12-17 13:42 kgv Summary STEP import missing surfaces => Data Exchange - STEP import missing surfaces
2020-02-03 11:13 szy Note Added: 0090279
2020-02-03 12:03 gka Note Added: 0090280
2020-02-04 15:32 git Note Added: 0090290
2020-02-04 17:12 kgv Target Version => 7.5.0*
2020-02-20 16:03 git Note Added: 0090605
2020-02-20 19:01 git Note Added: 0090606
2020-02-21 14:30 git Note Added: 0090611
2020-02-21 14:33 git Note Added: 0090612
2020-02-21 18:27 git Note Added: 0090615
2020-02-21 18:30 git Note Added: 0090616
2020-02-26 12:05 git Note Added: 0090683
2020-02-26 16:36 git Note Added: 0090688
2020-02-27 19:13 git Note Added: 0090712
2020-02-28 18:13 git Note Added: 0090727
2020-02-28 18:19 git Note Added: 0090728
2020-03-02 11:36 git Note Added: 0090752
2020-03-02 14:38 git Note Added: 0090761
2020-03-02 16:56 gka Relationship added related to 0031301
2020-03-03 20:14 git Note Added: 0090804
2020-03-06 20:11 git Note Added: 0090859
2020-03-10 19:37 git Note Added: 0090887
2020-03-11 18:15 git Note Added: 0090900
2020-03-12 10:58 git Note Added: 0090909
2020-03-12 16:28 gka Note Added: 0090916
2020-03-12 16:29 gka Note Added: 0090917
2020-03-12 16:29 gka Assigned To gka => abv
2020-03-12 16:29 gka Status new => resolved
2020-03-17 18:49 abv Relationship added related to 0031233
2020-03-17 19:23 git Note Added: 0090993
2020-03-18 09:50 git Note Added: 0091000
2020-03-18 13:38 abv Note Added: 0091026
2020-03-18 13:38 abv Assigned To abv => bugmaster
2020-03-18 13:38 abv Status resolved => reviewed
2020-03-19 10:19 abv Note Added: 0091042
2020-03-19 16:31 bugmaster Changeset attached => occt master 6a9f983a
2020-03-19 16:31 bugmaster Status reviewed => verified
2020-03-19 16:31 bugmaster Resolution open => fixed
2020-03-22 11:31 git Note Added: 0091126
2020-03-22 11:31 git Note Added: 0091133
2020-03-22 11:31 git Note Added: 0091134
2020-03-22 11:31 git Note Added: 0091135
2020-03-22 11:31 git Note Added: 0091136
2020-03-22 11:31 git Note Added: 0091137
2020-03-22 11:40 bugmaster Note Added: 0091154
2020-03-22 11:40 bugmaster Test case number => Not required


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker