View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0029680 | Open CASCADE | OCCT:Tests | public | 2018-04-08 18:48 | 2018-06-29 21:19 |
| Reporter | Assigned To | bugmaster | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 7.0.0 | ||||
| Target Version | 7.3.0 | Fixed in Version | 7.3.0 | ||
| Summary | 0029680: Tests - command checkprops does not work for negative values | ||||
| Description | Check of mass (volume, area, length) properties performed by DRAW command checkprops always passes without error if specified reference value is negative. Note: apparently the problem has been discovered and fixed during analysis of visual differences after fix of #28903, initially within patch for #29663 | ||||
| Steps To Reproduce | pload MODELING box b 10 10 10 # the following command gives no error in OCCT 7.2.0 checkprops b -v -10 | ||||
| Tags | No tags attached. | ||||
| Test case number | offset faces_type_i E5 | ||||
|
|
Branch CR29680 has been created by abv. SHA-1: 5ee45510486e7fd6b236e9a888db7603c0162862 Detailed log of new commits: Author: abv Date: Sun Apr 8 18:52:31 2018 +0300 0029680: Tests - command checkprops does not work for negative values DRAW command checkprops is corrected to handle properly negative reference values. Test case offset faces_face_i E5 is corrected (improvement due to #28903) |
|
|
Branch CR29680 has been updated forcibly by abv. SHA-1: 44d6f595f3993db6ad02421d669666b517160e5b |
|
|
Branch CR29680 has been updated forcibly by abv. SHA-1: 4669a4a01870a7fb090000da273ed8f30ca4d61f |
|
|
Fix pushed to CR29680, please review. The test results are in Jenkins job CR29680-master-abv. Note that failure of test offset faces_face_i E5 was due to remaining extra TODO statement due to incorrect rebase, this is corrected in the last version of the branch. Image differences in OCCT tests and failures on Products tests are apparently due to other changes in the IR_WEEK12 branch on which CR29680 is based. |
|
|
Reviewed. Dear Bugmaster, Please exclude the file "CheckCommands.tcl" from remotes/origin/CR29663_2 branch because its functionality is a duplicate of this fix. |
|
|
> Please exclude the file "CheckCommands.tcl" from remotes/origin/CR29663_2 branch because its functionality is a duplicate of this fix. I am sorry. It is already done in the branch CR29663_3. |
|
|
OCCT branch : IR-WEEK12 SHA - a23e23b5e5e56f10d15e85518195162b347d5ac4 Products branch : IR-WEEK12 SHA - 8471189e8649026d76950924f8ec2b4878cba528 was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian70-64: OCCT Total CPU difference: 18180.84999999974 / 18135.489999999976 [+0.25%] Products Total CPU difference: 7464.190000000011 / 7435.139999999992 [+0.39%] Windows-64-VC10: OCCT Total CPU difference: 17769.964709298587 / 17864.39211459853 [-0.53%] Products Total CPU difference: 8154.078669399982 / 8129.77371359997 [+0.30%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR29680 has been deleted by kgv. SHA-1: 4669a4a01870a7fb090000da273ed8f30ca4d61f |
|
occt: master 9b74e207 2018-04-08 15:52:31
Committer: bugmaster Details Diff |
0029680: Tests - command checkprops does not work for negative values DRAW command checkprops is corrected to handle properly negative reference values. Test case offset faces_face_i E5 is corrected (improvement due to #28903) |
Affected Issues 0029680 |
|
| mod - src/DrawResources/CheckCommands.tcl | Diff File | ||
| mod - tests/offset/faces_type_i/E5 | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-04-08 18:48 |
|
New Issue | |
| 2018-04-08 18:48 |
|
Assigned To | => apn |
| 2018-04-08 19:02 | git | Note Added: 0075232 | |
| 2018-04-08 21:25 | git | Note Added: 0075234 | |
| 2018-04-09 07:20 | git | Note Added: 0075236 | |
| 2018-04-09 08:28 |
|
Note Added: 0075237 | |
| 2018-04-09 08:28 |
|
Status | new => resolved |
| 2018-04-09 08:28 |
|
Assigned To | apn => nbv |
| 2018-04-09 09:43 |
|
Note Added: 0075238 | |
| 2018-04-09 09:43 |
|
Assigned To | nbv => bugmaster |
| 2018-04-09 09:43 |
|
Status | resolved => reviewed |
| 2018-04-09 09:52 |
|
Note Added: 0075239 | |
| 2018-04-09 13:20 | bugmaster | Note Added: 0075244 | |
| 2018-04-09 13:20 | bugmaster | Status | reviewed => tested |
| 2018-04-11 07:49 | bugmaster | Changeset attached | => occt master 9b74e207 |
| 2018-04-11 07:49 | bugmaster | Status | tested => verified |
| 2018-04-11 07:49 | bugmaster | Resolution | open => fixed |
| 2018-04-11 11:00 | git | Note Added: 0075351 | |
| 2018-04-11 12:05 | bugmaster | Test case number | => offset faces_type_i E5 |
| 2018-06-29 21:14 |
|
Fixed in Version | => 7.3.0 |
| 2018-06-29 21:19 |
|
Status | verified => closed |
