View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0029636 | Open CASCADE | OCCT:Modeling Algorithms | public | 2018-03-23 15:40 | 2018-04-11 14:46 |
Reporter | Assigned To | bugmaster | |||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | duplicate | ||
Target Version | 7.4.0 | ||||
Summary | 0029636: Wrong detection of closedness of face in method BRepOffset_Tool::EnLargeFace | ||||
Description | When a closed face lies on periodic surface and its parametric origin differs from the surface parametric origin, detection of closedness is wrong. | ||||
Steps To Reproduce | No. | ||||
Tags | No tags attached. | ||||
Test case number | |||||
|
Branch CR29636 has been created by jgv. SHA-1: 3db07a9b2aae53b6024cd3f86d77b777d0257aaa Detailed log of new commits: Author: jgv Date: Fri Mar 23 16:08:11 2018 +0300 0029636: Wrong detection of closedness of face in method BRepOffset_Tool::EnLargeFace Add method BRepOffset_Tool::DetectClosedness that sets values of flags "uclosed" and "vclosed". |
|
Branch CR29636_1 has been created by jgv. SHA-1: daea2ad3116adfb4864d5d3c57153a9cb4f8405b Detailed log of new commits: Author: jgv Date: Mon Mar 26 14:39:56 2018 +0300 Change usage of infinite values in enlargement of surface. Author: jgv Date: Fri Mar 23 16:08:11 2018 +0300 0029636: Wrong detection of closedness of face in method BRepOffset_Tool::EnLargeFace Add method BRepOffset_Tool::DetectClosedness that sets values of flags "uclosed" and "vclosed". Author: jgv Date: Thu Mar 22 19:15:26 2018 +0300 Next version Author: jgv Date: Tue Mar 20 16:39:43 2018 +0300 Delete a comment Author: jgv Date: Thu Feb 1 10:59:18 2018 +0300 Modify test case Author: jgv Date: Wed Jan 31 14:06:31 2018 +0300 Fix of regressions Author: jgv Date: Tue Jan 30 14:09:12 2018 +0300 Correction according to the remarks Author: jgv Date: Fri Jan 26 15:56:01 2018 +0300 Modify test cases Author: jgv Date: Thu Jan 25 14:48:39 2018 +0300 Fix of regressions Author: jgv Date: Tue Jan 23 18:26:15 2018 +0300 Add test case. Author: jgv Date: Tue Jan 23 17:54:06 2018 +0300 0028903: BRepOffset_MakeOffset produces invalid shape (thickshell) in Intersection mode 1. Method BRepOffset_Tool::Inter3D is modified: now selection of proper edges is performed here, they are not concatenated into one edge if they go through a vertex on a boundary. 2. Method BRepOffset_Inter3d::ConnexIntByInt is modified: selection of edges is eliminated. 3. Method BRepOffset_Inter2d::ConnexIntByInt is corrected to be able to process seam edges correct. |
|
Branch CR29636_1 has been updated by jgv. SHA-1: 3446f9f55d2477b23fa1ec9ce330d01f93718f97 Detailed log of new commits: Author: jgv Date: Tue Mar 27 14:48:39 2018 +0300 Add new parameter "UseInfini" to method BRepOffset_Tool::EnLargeFace |
|
Please review the branch CR29636_1. |
|
Dear Julia, please squash the commits and provide the proper commit message for the fix. Please rebase also the patch on the current master or if necessary on the actual patch for the issue #28903. |
|
Branch CR29636_2 has been created by jgv. SHA-1: 9b69aa3e596ae3ac5d33d34fc485e6665ce8e0d3 Detailed log of new commits: Author: jgv Date: Fri Mar 23 16:08:11 2018 +0300 0029636: Wrong detection of closedness of face in method BRepOffset_Tool::EnLargeFace Add method BRepOffset_Tool::DetectClosedness that sets values of flags "uclosed" and "vclosed". |
|
The branch has not been reviewed yet. |
|
src/BRepOffset/BRepOffset_Tool.hxx - Add comments for the new method and new parameter of EnLargeFace method. src/BRepOffset/BRepOffset_Tool.cxx - What is the purpose of the repetition of the comment in lines 3137-3145? - line 3093: stop the loop if both theUclosed and theVclosed are set to true; - line 2702: the flag name "UseInfini" does not seem to be appropriate. Please explain the following differences in images: IMAGE bugs modalg_6 bug26288 IMAGE bugs modalg_2 bug5805_41 Performance degradation on both Linux and Windows platforms: CPU bugs modalg_2 bug5805_18: 1.3728088 / 0.7332047 [+87.23%] |
|
Branch CR29636_2 has been updated by jgv. SHA-1: 0765dd917f4cc7a483fe910032f8b25c3c9c3141 Detailed log of new commits: Author: jgv Date: Fri Mar 30 16:18:08 2018 +0300 Correction according to the remarks. |
|
Please have a look at modified CR29636_2 before I launch testing. |
|
Please explain the meaning of the ExtensionMode: 1 - analytical faces will be extended as large as possible, non-analytical on the fourth of the face U and V extension; 0 - analytical faces will be extended on ten times of the face U and V extension, non-analytical on the face U and V extension. |
|
Please close this as a duplicate of #29591. |
|
Branch CR29636 has been deleted by kgv. SHA-1: 3db07a9b2aae53b6024cd3f86d77b777d0257aaa |
|
Branch CR29636_1 has been deleted by kgv. SHA-1: 3446f9f55d2477b23fa1ec9ce330d01f93718f97 |
|
Branch CR29636_2 has been deleted by kgv. SHA-1: 0765dd917f4cc7a483fe910032f8b25c3c9c3141 |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-03-23 15:40 |
|
New Issue | |
2018-03-23 15:40 |
|
Assigned To | => msv |
2018-03-23 15:41 |
|
Assigned To | msv => jgv |
2018-03-23 15:41 |
|
Status | new => assigned |
2018-03-23 16:08 | git | Note Added: 0074833 | |
2018-03-26 14:44 | git | Note Added: 0074924 | |
2018-03-27 14:49 | git | Note Added: 0074958 | |
2018-03-27 21:59 |
|
Note Added: 0074976 | |
2018-03-27 21:59 |
|
Assigned To | jgv => msv |
2018-03-27 21:59 |
|
Status | assigned => resolved |
2018-03-27 21:59 |
|
Steps to Reproduce Updated | |
2018-03-28 09:49 |
|
Assigned To | msv => emv |
2018-03-28 10:25 |
|
Note Added: 0074986 | |
2018-03-28 10:25 |
|
Assigned To | emv => jgv |
2018-03-28 10:25 |
|
Status | resolved => assigned |
2018-03-29 17:08 | git | Note Added: 0075033 | |
2018-03-30 13:48 |
|
Assigned To | jgv => msv |
2018-03-30 13:48 |
|
Status | assigned => resolved |
2018-03-30 13:48 |
|
Assigned To | msv => bugmaster |
2018-03-30 13:48 |
|
Status | resolved => reviewed |
2018-03-30 14:09 |
|
Note Added: 0075055 | |
2018-03-30 14:09 |
|
Status | reviewed => assigned |
2018-03-30 14:09 |
|
Assigned To | bugmaster => emv |
2018-03-30 14:09 |
|
Status | assigned => resolved |
2018-03-30 14:46 |
|
Note Added: 0075056 | |
2018-03-30 14:46 |
|
Assigned To | emv => jgv |
2018-03-30 14:46 |
|
Status | resolved => assigned |
2018-03-30 16:18 | git | Note Added: 0075060 | |
2018-03-30 16:20 |
|
Note Added: 0075061 | |
2018-03-30 16:20 |
|
Assigned To | jgv => msv |
2018-03-30 16:20 |
|
Status | assigned => resolved |
2018-03-30 16:38 |
|
Note Added: 0075065 | |
2018-04-02 17:28 |
|
Assigned To | msv => jgv |
2018-04-02 17:28 |
|
Status | resolved => assigned |
2018-04-02 18:33 |
|
Note Added: 0075127 | |
2018-04-02 18:33 |
|
Assigned To | jgv => bugmaster |
2018-04-02 18:33 |
|
Status | assigned => feedback |
2018-04-03 10:45 | bugmaster | Status | feedback => closed |
2018-04-03 10:45 | bugmaster | Resolution | open => fixed |
2018-04-11 11:04 | git | Note Added: 0075364 | |
2018-04-11 11:04 | git | Note Added: 0075365 | |
2018-04-11 11:04 | git | Note Added: 0075366 | |
2018-04-11 14:46 | bugmaster | Resolution | fixed => duplicate |