View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0029575 | Open CASCADE | OCCT:Coding | public | 2018-03-14 17:43 | 2019-07-10 18:46 |
Reporter | Assigned To | ||||
Priority | normal | Severity | integration request | ||
Status | closed | Resolution | won't fix | ||
Summary | 0029575: Remove unuseful "template tools" | ||||
Description | Some classes like BRepBlend_HCurve2dTool Contap_HCurve2dTool IntPatch_HCurve2dTool BRepBlend_HCurveTool HLRBRep_BSurfaceTool and maybe other are currently not used in OCCT and shall be deleted. They was created in order to provide "template-like" functionality. Other tools (e.g. Extrema_CurveTool), which are still used should be replaced with templates and (after that) be removed. | ||||
Tags | No tags attached. | ||||
Test case number | |||||
|
Nikolai, can you explain why you wrote that classes like BRepBlend_HCurve2dTool are not used? That particular one is used in multiple places, e.g. in BRepBlend_HCurve2dTool.cxx. The same with others. |
|
Andrey, In my opinion, some such classes are excess. I do not make detailed analyze but they can be replaced with the correspond method of argument. E.g. IntPatch_HCurve2dTool::Value(CURVE,X(3))) can be replaced with curve->Value(...) where "curve" is Adaptor2d_HCurve2d. ETC. Moreover, if they cannot be replaced then many methods of these classes are not used currently (e.g. IntPatch_HCurve2dTool::IsPeriodic()). Additionally, please see bug description: "Other tools (e.g. Extrema_CurveTool), which are still used should be replaced with templates and (after that) be removed." |
|
I have nothing against eliminating these classes if they are do not provide any added value, just please use accurate wording in bug descriptions (and elsewhere). If you write that something (class in that case) is not used, this should mean that it is not used, literally. |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-03-14 17:43 |
|
New Issue | |
2018-03-14 17:43 |
|
Assigned To | => msv |
2018-03-20 06:00 |
|
Note Added: 0074686 | |
2018-03-20 06:00 |
|
Assigned To | msv => nbv |
2018-03-20 06:00 |
|
Status | new => feedback |
2018-03-20 09:43 |
|
Note Added: 0074688 | |
2018-03-20 09:43 |
|
Assigned To | nbv => abv |
2018-03-21 16:14 |
|
Note Added: 0074744 | |
2018-03-21 16:14 |
|
Assigned To | abv => nbv |
2018-03-21 16:14 |
|
Status | feedback => assigned |
2019-07-10 18:46 |
|
Status | assigned => closed |
2019-07-10 18:46 |
|
Resolution | open => won't fix |
2019-07-10 18:46 |
|
Target Version | 7.4.0 => |