View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0029516Open CASCADEOCCT:Visualizationpublic2018-02-19 22:242019-09-17 11:49
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityintegration request 
Status closedResolutionfixed 
Target Version7.4.0Fixed in Version7.4.0 
Summary0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::ReflectionMode()
DescriptionGraphic3d_MaterialAspect::ReflectionMode() returns FALSE for disabled material components.

This functionality is redundant - the same can be done in several other ways:
- By setting material component coefficient to 0.0.
- By setting material component color to zeros.
- By setting Shading Model to unlit.

It is proposed to remove redundant property to simplify materials management.
Steps To ReproduceN/A
TagsNo tags attached.
Test case number

Relationships

related to 0029097 closedbugmaster Open CASCADE Visualization - allow picking Graphic3d_TypeOfShadingModel per-object 
related to 0030930 closedapn Open CASCADE Draw Harness, ViewerTest - add commands vlistcolors and vlistmaterials listing standard Colors and Materials 
related to 0030700 closedapn Open CASCADE Visualization, TKOpenGl - support PBR Metallic-Roughness shading model 

Activities

git

2019-08-30 21:55

administrator   ~0086560

Branch CR29516 has been created by kgv.

SHA-1: 91c5170fc187afddb633ba0c9d506dd186f172a7


Detailed log of new commits:

Author: kgv
Date: Fri Aug 30 21:52:12 2019 +0300

    0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::ReflectionMode()

git

2019-08-31 09:46

administrator   ~0086565

Branch CR29516 has been updated forcibly by kgv.

SHA-1: 30b0d9d04c7fe394ffb7b24f5e7cf6a42c79cbe0

git

2019-08-31 09:54

administrator   ~0086567

Branch CR29516 has been updated forcibly by kgv.

SHA-1: 951534267d572de9937a3f3c110bd444f8dcde70

git

2019-08-31 13:16

administrator   ~0086570

Branch CR29516 has been updated forcibly by kgv.

SHA-1: e0e142e8adb5cb6165c4a7cf099fc0954f7857c6

git

2019-08-31 13:32

administrator   ~0086572

Branch CR29516 has been updated forcibly by kgv.

SHA-1: 3f78c59a69687e67e1d6c2199a3537faa9b3d454

git

2019-08-31 21:26

administrator   ~0086576

Branch CR29516 has been updated forcibly by kgv.

SHA-1: 41ded72e9f5af099f1b53055aee48b1463328172

git

2019-08-31 22:01

administrator   ~0086577

Branch CR29516 has been updated forcibly by kgv.

SHA-1: fe6487919f38310797aaf72543e7d6bdc39a9b46

git

2019-08-31 22:26

administrator   ~0086578

Branch CR29516 has been updated forcibly by kgv.

SHA-1: 09f4a33cc40cd525806af970c3fb9724bd5e6b6e

git

2019-08-31 22:34

administrator   ~0086579

Branch CR29516 has been updated forcibly by kgv.

SHA-1: aa37cba1613b4a2e12fd193521be73df8f4cf736

git

2019-08-31 22:56

administrator   ~0086580

Branch CR29516 has been updated forcibly by kgv.

SHA-1: 3988998dedb0ffbd64932fa7a9fdf538cba4e4b5

git

2019-08-31 22:57

administrator   ~0086581

Branch CR29516 has been updated forcibly by kgv.

SHA-1: cb93b890b6dd96657746a3c8e8b1e7ab43e463f7

git

2019-08-31 23:19

administrator   ~0086583

Branch CR29516 has been updated forcibly by kgv.

SHA-1: 06c6b7dba7975ec979c121e3405d2e3ba4a92fcc

git

2019-09-01 00:15

administrator   ~0086585

Branch CR29516_1 has been created by kgv.

SHA-1: 350b99d9c24f913fe5e9fe4cc11e7a57336962aa


Detailed log of new commits:

Author: kgv
Date: Fri Aug 30 21:52:12 2019 +0300

    0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::ReflectionMode()
    
    Decomposition of Ambient, Diffuse, Specular and Emissive properties has been eliminated within *Graphic3d_MaterialAspect* definition,
    so that following methods of *Graphic3d_MaterialAspect* class have been removed:
    SetReflectionMode(), SetReflectionModeOn(), Ambient(), Diffuse(), Emissive(), Specular(), SetAmbient(), SetDiffuse(), SetSpecular(), SetEmissive().
    
    Graphic3d_NOM_NEON_GNC non-physical material definition has been corrected
    and define WHITE emission color coefficient instead of YELLOW.
    
    Added method Graphic3d_ClipPlane::SetCappingColor() for more straight-forward modification of Capping color in case of non-physical material.
    Prs3d_ShadingAspect::Color() has been fixed to return InteriorColor instead of material color coefficient in case of non-physical material.

git

2019-09-01 00:18

administrator   ~0086586

Branch CR29516_1 has been updated forcibly by kgv.

SHA-1: e550f6869977aaa0876d2c82a9ed8118087ee8da

kgv

2019-09-01 10:37

developer   ~0086588

Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR29516_1-CR29516-KGV/

git

2019-09-02 17:28

administrator   ~0086625

Branch CR29516_1 has been updated forcibly by kgv.

SHA-1: 80bf2e1fad31635d1cd7521986b25d5b3477d7af

osa

2019-09-04 12:40

developer   ~0086729

The patch was reviewed without remarks

bugmaster

2019-09-04 15:14

administrator   ~0086736

Combination -
OCCT branch : CR29516_1
master SHA - e550f6869977aaa0876d2c82a9ed8118087ee8da
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : CR29516 SHA - 6990be2fe5e87b8cf6754ae407546f07b28e8419
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16185.080000000082 / 16167.270000000033 [+0.11%]
Products
Total CPU difference: 10470.100000000053 / 10484.930000000048 [-0.14%]
Windows-64-VC14:
OCCT
Total CPU difference: 18310.25 / 18256.515625 [+0.29%]
Products
Total CPU difference: 12204.84375 / 12168.265625 [+0.30%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2019-09-07 16:27

administrator   ~0086942

Branch CR29516_1 has been deleted by inv.

SHA-1: 80bf2e1fad31635d1cd7521986b25d5b3477d7af

git

2019-09-07 16:27

administrator   ~0086945

Branch CR29516 has been deleted by inv.

SHA-1: 06c6b7dba7975ec979c121e3405d2e3ba4a92fcc

Related Changesets

occt: master 61168418

2019-08-30 18:52:12

kgv


Committer: bugmaster Details Diff		 0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::ReflectionMode()

Decomposition of Ambient, Diffuse, Specular and Emissive properties has been eliminated within *Graphic3d_MaterialAspect* definition,
so that following methods of *Graphic3d_MaterialAspect* class have been removed:
SetReflectionMode(), SetReflectionModeOn(), Ambient(), Diffuse(), Emissive(), Specular(), SetAmbient(), SetDiffuse(), SetSpecular(), SetEmissive().

Graphic3d_NOM_NEON_GNC non-physical material definition has been corrected
and define WHITE emission color coefficient instead of YELLOW.

Added method Graphic3d_ClipPlane::SetCappingColor() for more straight-forward modification of Capping color in case of non-physical material.
Prs3d_ShadingAspect::Color() has been fixed to return InteriorColor instead of material color coefficient in case of non-physical material.		 Affected Issues
0029516
mod - dox/dev_guides/upgrade/upgrade.md Diff File
mod - samples/mfc/standard/Common/User_Cylinder.cxx Diff File
mod - src/AIS/AIS_Dimension.cxx Diff File
mod - src/AIS/AIS_Manipulator.cxx Diff File
mod - src/AIS/AIS_Shape.cxx Diff File
mod - src/AIS/AIS_Triangulation.cxx Diff File
mod - src/AIS/AIS_ViewCube.cxx Diff File
mod - src/Graphic3d/Graphic3d_ClipPlane.cxx Diff File
mod - src/Graphic3d/Graphic3d_ClipPlane.hxx Diff File
mod - src/Graphic3d/Graphic3d_MaterialAspect.cxx Diff File
mod - src/Graphic3d/Graphic3d_MaterialAspect.hxx Diff File
mod - src/MeshVS/MeshVS_ElementalColorPrsBuilder.cxx Diff File
mod - src/MeshVS/MeshVS_MeshPrsBuilder.cxx Diff File
mod - src/MeshVS/MeshVS_NodalColorPrsBuilder.cxx Diff File
mod - src/OpenGl/OpenGl_Aspects.cxx Diff File
mod - src/OpenGl/OpenGl_Material.hxx Diff File
mod - src/OpenGl/OpenGl_SceneGeometry.cxx Diff File
mod - src/OpenGl/OpenGl_SceneGeometry.hxx Diff File
mod - src/OpenGl/OpenGl_View.hxx Diff File
mod - src/OpenGl/OpenGl_View_Raytrace.cxx Diff File
mod - src/OpenGl/OpenGl_Workspace.cxx Diff File
mod - src/Prs3d/Prs3d_ShadingAspect.cxx Diff File
mod - src/QABugs/QABugs_17.cxx Diff File
mod - src/QABugs/QABugs_PresentableObject.cxx Diff File
mod - src/V3d/V3d_Trihedron.cxx Diff File
mod - src/ViewerTest/ViewerTest.cxx Diff File
mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx Diff File
mod - src/ViewerTest/ViewerTest_OpenGlCommands.cxx Diff File
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff File

Issue History

Date Modified Username Field Change
2018-02-19 22:24 kgv New Issue
2018-02-19 22:24 kgv Assigned To => kgv
2018-02-19 22:24 kgv Relationship added related to 0029097
2018-03-11 13:09 kgv Target Version 7.3.0 => 7.4.0
2019-05-07 14:26 kgv Relationship added related to 0030700
2019-08-30 21:55 git Note Added: 0086560
2019-08-31 09:46 git Note Added: 0086565
2019-08-31 09:54 git Note Added: 0086567
2019-08-31 13:16 git Note Added: 0086570
2019-08-31 13:32 git Note Added: 0086572
2019-08-31 21:26 git Note Added: 0086576
2019-08-31 22:01 git Note Added: 0086577
2019-08-31 22:26 git Note Added: 0086578
2019-08-31 22:34 git Note Added: 0086579
2019-08-31 22:56 git Note Added: 0086580
2019-08-31 22:57 git Note Added: 0086581
2019-08-31 23:19 git Note Added: 0086583
2019-09-01 00:15 git Note Added: 0086585
2019-09-01 00:18 git Note Added: 0086586
2019-09-01 10:37 kgv Note Added: 0086588
2019-09-01 10:37 kgv Assigned To kgv => san
2019-09-01 10:37 kgv Status new => resolved
2019-09-01 10:38 kgv Relationship added related to 0030930
2019-09-02 17:28 git Note Added: 0086625
2019-09-04 12:37 kgv Assigned To san => osa
2019-09-04 12:40 osa Note Added: 0086729
2019-09-04 12:40 osa Assigned To osa => bugmaster
2019-09-04 12:40 osa Status resolved => reviewed
2019-09-04 15:14 bugmaster Note Added: 0086736
2019-09-04 15:14 bugmaster Status reviewed => tested
2019-09-07 11:38 bugmaster Changeset attached => occt master 61168418
2019-09-07 11:38 bugmaster Status tested => verified
2019-09-07 11:38 bugmaster Resolution open => fixed
2019-09-07 16:27 git Note Added: 0086942
2019-09-07 16:27 git Note Added: 0086945