MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0029367Community[OCCT] OCCT:Visualizationpublic2017-12-05 06:522019-11-10 11:43
ReporterVico Liang 
Assigned Toapn 
PrioritynormalSeverityintegration request 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.5.0*Fixed in Version 
Summary0029367: Visualization - simplify interface of V3d_View and V3d_Viewer
Descriptionclass V3d_View:
  Standard_EXPORT Standard_Boolean IfMoreLights() const;
  V3d_ListOfLightIterator ActiveLightIterator() const;
  void InitActiveLights();
  Standard_Boolean MoreActiveLights() const;
  void NextActiveLights();
  const Handle(V3d_Light)& ActiveLight() const;

class V3d_Viewer:
  V3d_ListOfViewIterator ActiveViewIterator() const;
  void InitActiveViews();
  Standard_Boolean MoreActiveViews() const;
  void NextActiveViews();
  const Handle(V3d_View)& ActiveView();

  V3d_ListOfViewIterator DefinedViewIterator() const;
  void InitDefinedViews();
  Standard_Boolean MoreDefinedViews() const;
  void NextDefinedViews();
  const Handle(V3d_View)& DefinedView() const;

  V3d_ListOfLightIterator ActiveLightIterator() const;
  void InitActiveLights();
  Standard_Boolean MoreActiveLights() const;
  void NextActiveLights();
  const Handle(V3d_Light)& ActiveLight() const;

  V3d_ListOfLightIterator DefinedLightIterator() const;
  void InitDefinedLights();
  Standard_Boolean MoreDefinedLights() const;
  void NextDefinedLights();
  const Handle(V3d_Light)& DefinedLight() const;

All above methods can be removed and replaced by returning the internal raw data
  V3d_ListOfView myDefinedViews;
  V3d_ListOfView myActiveViews;
  V3d_ListOfLight myDefinedLights;
  V3d_ListOfLight myActiveLights;
Steps To ReproduceNot required
TagsNo tags attached.
Test case number
Attached Files

- Relationships
related to 0028987closedkgv Open CASCADE Visualization, SelectMgr_SelectableObject - move out iterator from object 
related to 0030972feedbackbugmaster Open CASCADE Visualization - remove deprecated iterators embedded into TKV3d containers 

-  Notes
(0087977)
git (administrator)
2019-10-09 14:54

Branch CR29367 has been created by mzernova.

SHA-1: 4a4410e4fab1d0dd919a348de1933558c544649d


Detailed log of new commits:

Author: mzernova
Date: Thu Sep 19 12:54:11 2019 +0300

    0029367: Visualization - simplify interface of V3d_View and V3d_Viewer
    
    The interface of V3d_View and V3d_Viewer has been simplified. For the fields myDefinedViews, myActiveViews, myDefinedLights, myActiveLights were added appropriate Get***() methods
(0087979)
user897
2019-10-09 14:57

The patch CR29367 is ready to review
(0087980)
kgv (developer)
2019-10-09 15:08

+  //! @return a list of defined views.
+  V3d_ListOfView GetDefinedViews() const { return myDefinedViews; }
...
+  //! @return a list of active lights.
+  V3d_ListOfLight GetActiveLights() const { return myActiveLights; }
...
+  //! @return a list of defined lights.
+  V3d_ListOfLight GetDefinedLights() const { return myDefinedLights; }

Why list is returned by copy?
And remove "Get" prefix from these methods.

-  for (V3d_ListOfLightIterator aDefLightIter (MyViewer->DefinedLightIterator()); aDefLightIter.More(); 
aDefLightIter.Next())
+  V3d_ListOfLight aDefinedLights = MyViewer->GetDefinedLights();
+  for (V3d_ListOfLightIterator aDefLightIter (aDefinedLights); aDefLightIter.More(); aDefLightIter.Next())


Please revert modifications removing usage of method returning iterator.

-  //! Initializes an internal iterator on the active views.
-  void InitActiveViews() { myActiveViewsIterator.Initialize (myActiveViews); }
-
-  //! Returns true if there are more active view(s) to return.
-  Standard_Boolean MoreActiveViews() const { return myActiveViewsIterator.More(); }
-
-  //! Go to the next active view (if there is not, ActiveView will raise an exception)
-  void NextActiveViews() { if (!myActiveViews.IsEmpty()) myActiveViewsIterator.Next(); }
-  
-  const Handle(V3d_View)& ActiveView() const { return myActiveViewsIterator.Value(); }

Please don't remove these methods - they should be marked as Deprecated and removed after next OCCT release.
Methods creating an Iterator should be left as is and used in existing code, only methods using "embedded" iterators should be marked deprecated.
(0088280)
git (administrator)
2019-10-17 18:46

Branch CR29367 has been updated by mzernova.

SHA-1: ddaa9992d5b4b22763ca3c1b2802f00b7d528174


Detailed log of new commits:

Author: mzernova
Date: Thu Oct 10 12:18:41 2019 +0300

    remarks from kgv

(0088281)
git (administrator)
2019-10-17 18:46

Branch CR29367_1 has been created by mzernova.

SHA-1: 4ddced4e8e65cde3fa4056f655c4a6a8e22600ff


Detailed log of new commits:

Author: mzernova
Date: Thu Sep 19 12:54:11 2019 +0300

    0029367: Visualization - simplify interface of V3d_View and V3d_Viewer
    
    The interface of V3d_View and V3d_Viewer has been simplified. For the fields myDefinedViews, myActiveViews, myDefinedLights, myActiveLights were added appropriate methods returning the internal raw data
(0088304)
user897
2019-10-18 14:32

The patch CR29367 is ready to review
(0088307)
kgv (developer)
2019-10-18 14:49

+  Standard_DEPRECATED ("This method is deprecated. Please use ActiveLights() to getting raw data 
and work with them")
   const Handle(V3d_Light)& ActiveLight() const { return myActiveLightsIterator.Value(); }

Please move deprecated methods into dedicated "public:" section at the end of class definition (but before protected/private sections).
(0088312)
git (administrator)
2019-10-18 15:53

Branch CR29367_1 has been updated by mzernova.

SHA-1: 9e5a5f9a5b0b8ac9468b6f2f94b840d221f3472f


Detailed log of new commits:

Author: mzernova
Date: Fri Oct 18 15:47:18 2019 +0300

    remarks from kgv

(0088313)
git (administrator)
2019-10-18 16:06

Branch CR29367_2 has been created by mzernova.

SHA-1: a440b8f41658f8b0e68373ef49c8830d0feba08f


Detailed log of new commits:

Author: mzernova
Date: Thu Sep 19 12:54:11 2019 +0300

    0029367: Visualization - simplify interface of V3d_View and V3d_Viewer
    
    The interface of V3d_View and V3d_Viewer has been simplified. For the fields myDefinedViews, myActiveViews, myDefinedLights, myActiveLights were added appropriate methods returning the internal raw data
(0088320)
user897
2019-10-18 17:30

Please review the branch CR29367_2
(0088367)
kgv (developer)
2019-10-20 19:50

There are compilation warnings:

View_Displayer.cxx:287, GNU C Compiler 4 (gcc), Priority: Normal

'void V3d_Viewer::InitActiveViews()' is deprecated (declared at /OCCT_SRC/src/V3d/V3d_Viewer.hxx:453): 
This method is deprecated. Please use ActiveViews() to getting raw data and work with them [-Wdeprecated-declarations]


View_Displayer.cxx:288, GNU C Compiler 4 (gcc), Priority: Normal

'Standard_Boolean V3d_Viewer::MoreActiveViews() const' is deprecated (declared at /OCCT_SRC/src/V3d/V3d_Viewer.hxx:457): 
This method is deprecated. Please use ActiveViews() to getting raw data and work with them [-Wdeprecated-declarations]


View_Displayer.cxx:289, GNU C Compiler 4 (gcc), Priority: Normal

'const opencascade::handle& V3d_Viewer::ActiveView() const' is deprecated (declared at /OCCT_SRC/src/V3d/V3d_Viewer.hxx:464): 
This method is deprecated. Please use ActiveViews() to getting raw data and work with them [-Wdeprecated-declarations]



+  Standard_DEPRECATED ("This method is deprecated. Please use ActiveViews() to getting raw data 
and work with them")

The deprecation message can be shorter:
> Deprecated method - ActiveViews() should be used instead.
(0088377)
kgv (developer)
2019-10-21 09:49

More warnings:

++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Project : CR29367_2-master-KGV-OCCT-Windows-64-VC14-sample-mfc
++++++++++++++++++++++++++++++++++++++++++++++++++++++++

New warnings appears: 16
 
Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/01_geometry/src/geomsources.cpp

Line : 219
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/01_geometry/src/geomsources.cpp

Line : 220
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/common/occ_3dbasedoc.cpp

Line : 492
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/common/occ_3dbasedoc.cpp

Line : 493
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/10_convert/src/wnt/occdemodoc.cpp

Line : 233
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/10_convert/src/wnt/occdemodoc.cpp

Line : 234
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/04_viewer3d/src/texturesext_presentation.cpp

Line : 71
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/04_viewer3d/src/texturesext_presentation.cpp

Line : 72
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/07_triangulation/src/triangulationdoc.cpp

Line : 416
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/07_triangulation/src/triangulationdoc.cpp

Line : 417
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/04_viewer3d/src/viewer3ddoc.cpp

Line : 1023
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/04_viewer3d/src/viewer3ddoc.cpp

Line : 1024
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/04_viewer3d/src/viewer3dview.cpp

Line : 1019
Message : V3d_Viewer::InitActiveLights: This method is deprecated. Please use ActiveLights() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/04_viewer3d/src/viewer3dview.cpp

Line : 1021
Message : V3d_Viewer::ActiveLight: This method is deprecated. Please use ActiveLights() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/04_viewer3d/src/viewer3dview.cpp

Line : 1032
Message : V3d_View::InitActiveLights: This method is deprecated. Please use ActiveLights() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/occt/samples/mfc/standard/04_viewer3d/src/viewer3dview.cpp

Line : 1034
Message : V3d_View::ActiveLight: This method is deprecated. Please use ActiveLights() to getting raw 
data and work with them

++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Project : CR29367_2-master-KGV-Products-Windows-64-VC14-sample-mfc
++++++++++++++++++++++++++++++++++++++++++++++++++++++++

New warnings appears: 14
 
Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/ocaf/src/ocafsampledoc.cpp

Line : 821
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/ocaf/src/ocafsampledoc.cpp

Line : 823
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1269
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1270
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1271
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1272
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1713
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1714
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1715
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1716
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1809
Message : V3d_Viewer::InitActiveViews: This method is deprecated. Please use ActiveViews() to getting 
raw data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1810
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1811
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them

Type : MSBuild
Category : C4996
File Name : c:/install/cr29367_2-master-kgv/windows-64-vc14-opt/products/samples/mfc/shapehealer/kernel/shapehealingdoc.cpp

Line : 1812
Message : V3d_Viewer::ActiveView: This method is deprecated. Please use ActiveViews() to getting raw 
data and work with them



++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Project : CR29367_2-master-KGV-OCCT-Debian80-64-opt-compile
++++++++++++++++++++++++++++++++++++++++++++++++++++++++

New warnings appears: 3
 
Type : GNU C Compiler 4 (gcc)
Category : Warning:deprecated-declarations
File Name : /dn62/builds/CR29367_2-master-KGV/OCCT_SRC/tools/View/View_Displayer.cxx
Line : 287
Message : void V3d_Viewer::InitActiveViews() is deprecated (declared at _SRC/src/V3d/V3d_Viewer.hxx:453): 
This method is deprecated. Please use ActiveViews() to getting raw data and work with them [-Wdeprecated-declarations]


Type : GNU C Compiler 4 (gcc)
Category : Warning:deprecated-declarations
File Name : /dn62/builds/CR29367_2-master-KGV/OCCT_SRC/tools/View/View_Displayer.cxx
Line : 288
Message : Standard_Boolean V3d_Viewer::MoreActiveViews() const is deprecated (declared at _SRC/src/V3d/V3d_Viewer.hxx:457): 
This method is deprecated. Please use ActiveViews() to getting raw data and work with them [-Wdeprecated-declarations]


Type : GNU C Compiler 4 (gcc)
Category : Warning:deprecated-declarations
File Name : /dn62/builds/CR29367_2-master-KGV/OCCT_SRC/tools/View/View_Displayer.cxx
Line : 289
Message : const opencascade::handle<V3d_View>& V3d_Viewer::ActiveView() const is deprecated 
(declared at _SRC/src/V3d/V3d_Viewer.hxx:464): This method is deprecated. Please use ActiveViews() to 
getting raw data and work with them [-Wdeprecated-declarations]



++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Project : CR29367_2-master-KGV-Products-MacOS-opt-compile
++++++++++++++++++++++++++++++++++++++++++++++++++++++++

New warnings appears: 4
 
Type : Clang (LLVM based)
Category : -Wdeprecated-declarations
File Name : /CR29367_2-master-KGV/Products_SRC/src/PMIVisTest/PMIVisTest.cxx
Line : 2518
Message : InitDefinedViews is deprecated: This method is deprecated. Please use DefinedViews() to getting 
raw data and work with them

Type : Clang (LLVM based)
Category : -Wdeprecated-declarations
File Name : /CR29367_2-master-KGV/Products_SRC/src/PMIVisTest/PMIVisTest.cxx
Line : 2518
Message : MoreDefinedViews is deprecated: This method is deprecated. Please use DefinedViews() to getting 
raw data and work with them

Type : Clang (LLVM based)
Category : -Wdeprecated-declarations
File Name : /CR29367_2-master-KGV/Products_SRC/src/PMIVisTest/PMIVisTest.cxx
Line : 2518
Message : NextDefinedViews is deprecated: This method is deprecated. Please use DefinedViews() to getting 
raw data and work with them

Type : Clang (LLVM based)
Category : -Wdeprecated-declarations
File Name : /CR29367_2-master-KGV/Products_SRC/src/PMIVisTest/PMIVisTest.cxx
Line : 2520
Message : DefinedView is deprecated: This method is deprecated. Please use DefinedViews() to getting 
raw data and work with them
(0088431)
git (administrator)
2019-10-22 18:17

Branch CR29367_2 has been updated by mzernova.

SHA-1: 5bfdce843cecb71ed47b054805b4fdb45bb2a1ea


Detailed log of new commits:

Author: mzernova
Date: Tue Oct 22 17:21:42 2019 +0300

    remarks from kgv

(0088432)
kgv (developer)
2019-10-22 21:53

     TColStd_ListOfTransient lights;
-       for(myView->Viewer()->InitActiveLights(); myView->Viewer()->MoreActiveLights(); myView->Viewer()->NextActiveLights())

+    for (V3d_ListOfLightIterator anIter = myView->Viewer()->ActiveLightIterator(); anIter.More(); 
anIter.Next())
     {
-        lights.Append(myView->Viewer()->ActiveLight());
+        lights.Append (anIter.Value());
     }
     TColStd_ListIteratorOfListOfTransient itrLights(lights);
     for (; itrLights.More(); itrLights.Next())

While you close to these lines - please also correct lines below with proper collection instead of TColStd_ListOfTransient + redundant DownCast().
(0088556)
git (administrator)
2019-10-23 16:29

Branch CR29367_2 has been updated by mzernova.

SHA-1: ace5a89b346895efe57535693b6a00d8e6ecc4fa


Detailed log of new commits:

Author: mzernova
Date: Wed Oct 23 16:26:51 2019 +0300

    remarks from kgv

(0088671)
git (administrator)
2019-10-30 16:34

Branch CR29367_3 has been created by osa.

SHA-1: fad83d149fdeb7be71ba08a969e26ede226b2cba


Detailed log of new commits:

Author: osa
Date: Wed Oct 30 16:33:01 2019 +0300

    0029367: Visualization - simplify interface of V3d_View and V3d_Viewer
    
    The interface of V3d_View and V3d_Viewer has been simplified. For the fields myDefinedViews, myActiveViews, myDefinedLights, myActiveLights were added appropriate methods returning the internal raw data.
    Make the next methods deprecated: IfMoreLights(), InitActiveLights(), MoreActiveLights(), NextActiveLights(), ActiveLight() and InitActiveViews(), MoreActiveViews(), NextActiveViews(), ActiveView(), InitDefinedViews(), MoreDefinedViews(), NextDefinedViews(), DefinedView(), InitActiveLights(), MoreActiveLights(), NextActiveLights(), ActiveLight(), InitDefinedLights(), MoreDefinedLights(), NextDefinedLights(), DefinedLight().
    
    Remove deprecated methods added in scope of tasks 0029290 and 0028987 (Target Version 7.3.0).
(0088673)
git (administrator)
2019-10-30 16:58

Branch CR29367_3 has been updated forcibly by osa.

SHA-1: 309c383346e5e2758368ee912b693b2093697637
(0088674)
git (administrator)
2019-10-30 17:04

Branch CR29367_3 has been updated forcibly by osa.

SHA-1: fa3569d3115f621c2d44dee91210f0d434578b8e
(0088679)
git (administrator)
2019-10-31 09:43

Branch CR29367_3 has been updated forcibly by osa.

SHA-1: faf96ed8a94be1090efd34ab0d1d802545374720
(0088680)
osa (developer)
2019-10-31 09:44

The patches OCCT CR29367_3 and OCCT Products CR29367 are ready to review.

http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR29367_3-CR29367-OSA/view/ [^]
(0088681)
kgv (developer)
2019-10-31 09:48

-  //! Begins the iteration scanning for sensitive primitives.
-  Standard_DEPRECATED("Deprecated method, Selections() should be used instead")
-  void Init() { mycurrent = 1; }

The methods were removed, but class field "mycurrent" still exits.
(0088682)
git (administrator)
2019-10-31 09:56

Branch CR29367_3 has been updated by osa.

SHA-1: 93e834164b5ad07f47a232f41f8173f8ebd6cf9d


Detailed log of new commits:

Author: osa
Date: Thu Oct 31 09:55:15 2019 +0300

    #kgv remarks

(0088683)
kgv (developer)
2019-10-31 09:57

  22 V3d_PositionalLight::V3d_PositionalLight (const gp_Pnt& thePos,
  23                                           const Quantity_Color& theColor)
  24 : V3d_PositionLight (Graphic3d_TOLS_POSITIONAL, Handle(V3d_Viewer)())
  25 {

As there no more constructors taking V3d_Viewer, this argument can be removed now from V3d_PositionLight constructor with V3d_Viewer forward declaration and <V3d_Viewer.hxx> include.
(0088684)
git (administrator)
2019-10-31 10:21

Branch CR29367_3 has been updated by osa.

SHA-1: 48d6dfbc6dd5c5659ddc87f08654415a01837c6f


Detailed log of new commits:

Author: osa
Date: Thu Oct 31 10:20:01 2019 +0300

    #kgv remarks

(0088685)
git (administrator)
2019-10-31 10:22

Branch CR29367_4 has been created by osa.

SHA-1: 3d5b92d077d07fb17e94c382fb8645ed7353b07f


Detailed log of new commits:

Author: osa
Date: Wed Oct 30 16:33:01 2019 +0300

    0029367: Visualization - simplify interface of V3d_View and V3d_Viewer
    
    The interface of V3d_View and V3d_Viewer has been simplified.
    For the fields myDefinedViews, myActiveViews, myDefinedLights, myActiveLights were added appropriate methods returning the internal raw data.
    Make the next methods deprecated:
    IfMoreLights(), InitActiveLights(), MoreActiveLights(), NextActiveLights(), ActiveLight() and
    InitActiveViews(), MoreActiveViews(), NextActiveViews(), ActiveView(), InitDefinedViews(), MoreDefinedViews(), NextDefinedViews(), DefinedView(),
    InitActiveLights(), MoreActiveLights(), NextActiveLights(), ActiveLight(), InitDefinedLights(), MoreDefinedLights(), NextDefinedLights(), DefinedLight().
    
    Remove deprecated methods added in scope of tasks 0029290 and 0028987 (Target Version 7.3.0):
    SelectMgr_SelectableObject: Init(), More(), Next(), CurrentSelection().
    SelectMgr_Selection: Init(), More(), Next(), Sensitive().
    V3d_AmbientLight: one constructor.
    V3d_DirectionalLight: two constructors.
    V3d_PositionalLight: one constructor.
    V3d_SpotLight: two constructors.
(0088686)
osa (developer)
2019-10-31 10:23

The patch was updated
(0088844)
git (administrator)
2019-11-10 11:41

Branch CR29367_4 has been deleted by inv.

SHA-1: 3d5b92d077d07fb17e94c382fb8645ed7353b07f
(0088845)
git (administrator)
2019-11-10 11:41

Branch CR29367_3 has been deleted by inv.

SHA-1: 48d6dfbc6dd5c5659ddc87f08654415a01837c6f
(0088856)
git (administrator)
2019-11-10 11:41

Branch CR29367_2 has been deleted by inv.

SHA-1: ace5a89b346895efe57535693b6a00d8e6ecc4fa
(0088866)
git (administrator)
2019-11-10 11:42

Branch CR29367_1 has been deleted by inv.

SHA-1: 9e5a5f9a5b0b8ac9468b6f2f94b840d221f3472f
(0088867)
git (administrator)
2019-11-10 11:42

Branch CR29367 has been deleted by inv.

SHA-1: ddaa9992d5b4b22763ca3c1b2802f00b7d528174

- Related Changesets
occt: master f7fc0c03
Timestamp: 2019-10-30 13:33:01
Author: osa
Committer: apn
Details ] Diff ]
0029367: Visualization - simplify interface of V3d_View and V3d_Viewer

The interface of V3d_View and V3d_Viewer has been simplified.
For the fields myDefinedViews, myActiveViews, myDefinedLights, myActiveLights were added appropriate methods returning the internal raw data.
Make the next methods deprecated:
IfMoreLights(), InitActiveLights(), MoreActiveLights(), NextActiveLights(), ActiveLight() and
InitActiveViews(), MoreActiveViews(), NextActiveViews(), ActiveView(), InitDefinedViews(), MoreDefinedViews(), NextDefinedViews(), DefinedView(),
InitActiveLights(), MoreActiveLights(), NextActiveLights(), ActiveLight(), InitDefinedLights(), MoreDefinedLights(), NextDefinedLights(), DefinedLight().

Remove deprecated methods added in scope of tasks 0029290 and 0028987 (Target Version 7.3.0):
SelectMgr_SelectableObject: Init(), More(), Next(), CurrentSelection().
SelectMgr_Selection: Init(), More(), Next(), Sensitive().
V3d_AmbientLight: one constructor.
V3d_DirectionalLight: two constructors.
V3d_PositionalLight: one constructor.
V3d_SpotLight: two constructors.
mod - samples/mfc/standard/01_Geometry/src/GeomSources.cpp Diff ] File ]
mod - samples/mfc/standard/04_Viewer3d/src/TexturesExt_Presentation.cpp Diff ] File ]
mod - samples/mfc/standard/04_Viewer3d/src/Viewer3dDoc.cpp Diff ] File ]
mod - samples/mfc/standard/04_Viewer3d/src/Viewer3dView.cpp Diff ] File ]
mod - samples/mfc/standard/07_Triangulation/src/TriangulationDoc.cpp Diff ] File ]
mod - samples/mfc/standard/10_Convert/src/WNT/OCCDemoDoc.cpp Diff ] File ]
mod - samples/mfc/standard/Common/OCC_3dBaseDoc.cpp Diff ] File ]
mod - src/AIS/AIS_ColorScale.cxx Diff ] File ]
mod - src/SelectMgr/SelectMgr_SelectableObject.cxx Diff ] File ]
mod - src/SelectMgr/SelectMgr_SelectableObject.hxx Diff ] File ]
mod - src/SelectMgr/SelectMgr_Selection.cxx Diff ] File ]
mod - src/SelectMgr/SelectMgr_Selection.hxx Diff ] File ]
mod - src/V3d/V3d_AmbientLight.cxx Diff ] File ]
mod - src/V3d/V3d_AmbientLight.hxx Diff ] File ]
mod - src/V3d/V3d_DirectionalLight.cxx Diff ] File ]
mod - src/V3d/V3d_DirectionalLight.hxx Diff ] File ]
mod - src/V3d/V3d_PositionalLight.cxx Diff ] File ]
mod - src/V3d/V3d_PositionalLight.hxx Diff ] File ]
mod - src/V3d/V3d_PositionLight.cxx Diff ] File ]
mod - src/V3d/V3d_PositionLight.hxx Diff ] File ]
mod - src/V3d/V3d_SpotLight.cxx Diff ] File ]
mod - src/V3d/V3d_SpotLight.hxx Diff ] File ]
mod - src/V3d/V3d_View.hxx Diff ] File ]
mod - src/V3d/V3d_Viewer.hxx Diff ] File ]
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff ] File ]
mod - tools/View/View_Displayer.cxx Diff ] File ]

- Issue History
Date Modified Username Field Change
2017-12-05 06:52 Vico Liang New Issue
2017-12-05 06:52 Vico Liang Assigned To => kgv
2017-12-05 08:30 kgv Relationship added related to 0029290
2017-12-05 08:33 kgv Relationship added related to 0028987
2019-09-04 13:04 abv Target Version 7.4.0 => 7.5.0*
2019-09-17 10:23 kgv Assigned To kgv => user897
2019-09-17 10:23 kgv Severity minor => integration request
2019-09-17 10:23 kgv Status new => assigned
2019-09-17 10:23 kgv Summary Simplify interface of V3d_View and V3d_Viewer => Visualization - simplify interface of V3d_View and V3d_Viewer
2019-09-17 10:24 kgv Relationship added related to 0030972
2019-10-09 14:54 git Note Added: 0087977
2019-10-09 14:57 user897 Note Added: 0087979
2019-10-09 14:57 user897 Assigned To user897 => kgv
2019-10-09 14:57 user897 Status assigned => resolved
2019-10-09 14:57 user897 Steps to Reproduce Updated View Revisions
2019-10-09 15:08 kgv Note Added: 0087980
2019-10-09 15:08 kgv Assigned To kgv => user897
2019-10-09 15:08 kgv Status resolved => assigned
2019-10-17 18:46 git Note Added: 0088280
2019-10-17 18:46 git Note Added: 0088281
2019-10-18 14:32 user897 Note Added: 0088304
2019-10-18 14:32 user897 Assigned To user897 => osa
2019-10-18 14:32 user897 Status assigned => resolved
2019-10-18 14:49 kgv Note Added: 0088307
2019-10-18 15:53 git Note Added: 0088312
2019-10-18 16:06 git Note Added: 0088313
2019-10-18 17:30 user897 Note Added: 0088320
2019-10-20 19:50 kgv Note Added: 0088367
2019-10-20 19:50 kgv Assigned To osa => user897
2019-10-20 19:50 kgv Status resolved => assigned
2019-10-21 09:49 kgv Note Added: 0088377
2019-10-22 18:17 git Note Added: 0088431
2019-10-22 18:18 user897 Assigned To user897 => osa
2019-10-22 21:53 kgv Note Added: 0088432
2019-10-23 16:29 git Note Added: 0088556
2019-10-30 16:34 git Note Added: 0088671
2019-10-30 16:58 git Note Added: 0088673
2019-10-30 17:04 git Note Added: 0088674
2019-10-31 09:43 git Note Added: 0088679
2019-10-31 09:44 osa Note Added: 0088680
2019-10-31 09:44 osa Assigned To osa => kgv
2019-10-31 09:44 osa Status assigned => resolved
2019-10-31 09:48 kgv Note Added: 0088681
2019-10-31 09:56 git Note Added: 0088682
2019-10-31 09:57 kgv Note Added: 0088683
2019-10-31 09:59 kgv Assigned To kgv => osa
2019-10-31 09:59 kgv Status resolved => assigned
2019-10-31 10:21 git Note Added: 0088684
2019-10-31 10:22 git Note Added: 0088685
2019-10-31 10:23 osa Note Added: 0088686
2019-10-31 10:23 osa Assigned To osa => kgv
2019-10-31 10:23 osa Status assigned => resolved
2019-10-31 10:42 kgv Assigned To kgv => bugmaster
2019-10-31 10:42 kgv Status resolved => reviewed
2019-11-02 03:17 apn Note Added: 0088706
2019-11-02 03:18 apn Note Deleted: 0088706
2019-11-02 17:43 apn Changeset attached => occt master f7fc0c03
2019-11-02 17:43 apn Assigned To bugmaster => apn
2019-11-02 17:43 apn Status reviewed => verified
2019-11-02 17:43 apn Resolution open => fixed
2019-11-10 11:41 git Note Added: 0088844
2019-11-10 11:41 git Note Added: 0088845
2019-11-10 11:41 git Note Added: 0088856
2019-11-10 11:42 git Note Added: 0088866
2019-11-10 11:42 git Note Added: 0088867


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker