View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0029349 | Open CASCADE | OCCT:Foundation Classes | public | 2017-11-28 08:39 | 2018-06-29 21:19 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | integration request | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.3.0 | Fixed in Version | 7.3.0 | ||
| Summary | 0029349: Foundation Classes, OSD_Timer - add missing theThisThreadOnly constructor option available in OSD_Chronometer | ||||
| Description | OSD_Timer constructor does not provide options for initializing OSD_Chronometer, making it stuck on measuring whole process CPU time, which makes OSD_Chronometer within OSD_Timer instance a useless burden in case if thread-only time should be measured instead. | ||||
| Steps To Reproduce | N/A | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Branch CR29349 has been created by kgv. SHA-1: 80dcd314b7dc8b9d9f306fc38a5853a03d92fe36 Detailed log of new commits: Author: kgv Date: Tue Nov 28 08:42:40 2017 +0300 0029349: Foundation Classes, OSD_Timer - add missing theThisThreadOnly constructor option available in OSD_Chronometer OSD_Timer constructor now has theThisThreadOnly option passed to OSD_Chronometer, which is FALSE by default. OSD_Chronometer now provides methods ::UserTimeCPU(), ::SystemTimeCPU() allowing to fetch CPU times without akward syntax through overloaded ::Show(). |
|
|
Patch is ready for review. |
|
|
Some remarks: 1. OSD_Chronometer::timeToHoursMinutesSeconds() is public but starts with lower case -- should be either private or starting with uppercase 2. Method timeToHoursMinutesSeconds() is defined in OSD_Chronometer but used only in OSD_Timer; please move closer to location where it is used. Do we need it to be public at all? 3. Method OSD_Chronometer::Show (Standard_OStream& os) could be refactored to call Show(Standard_Real& theUserSec, Standard_Real& theSystemSec) to avoid code duplication for querying time 4. I see no reason to move implementation of the latter method Show() to header -- it is better to keep it in CXX |
|
|
Branch CR29349 has been updated forcibly by kgv. SHA-1: 4cf9f977e040a66077665ed4b27a117ece370a2b |
|
|
Branch CR29349_1 has been created by kgv. SHA-1: 7c2161bce774f477ba29dc138f71f3244a7a96e6 Detailed log of new commits: Author: kgv Date: Tue Nov 28 08:42:40 2017 +0300 0029349: Foundation Classes, OSD_Timer - add missing theThisThreadOnly constructor option available in OSD_Chronometer OSD_Timer constructor now has theThisThreadOnly option passed to OSD_Chronometer, which is FALSE by default. OSD_Chronometer now provides methods ::UserTimeCPU(), ::SystemTimeCPU() allowing to fetch CPU times without akward syntax through overloaded ::Show(). |
|
|
Remarks have been applied. http://jenkins-test-10.nnov.opencascade.com/view/CR29349_1-master-KGV |
|
|
No remarks, please test |
|
|
Combination - OCCT branch : CR29349_1 SHA - 7c2161bce774f477ba29dc138f71f3244a7a96e6 Products branch : master SHA - e6803066bfddb413c99c934cc8af4386abcbc679 was compiled on Linux, MacOS and Windows platforms and tested on optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian70-64: OCCT Total CPU difference: 20046.18000000047 / 19837.270000000357 [+1.05%] Products Total CPU difference: 8020.620000000084 / 8039.350000000084 [-0.23%] Windows-64-VC10: OCCT Total CPU difference: 17896.34111939866 / 17832.614710898575 [+0.36%] Products Total CPU difference: 8019.57460719996 / 8019.621407499985 [-0.00%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR29349 has been deleted by kgv. SHA-1: 4cf9f977e040a66077665ed4b27a117ece370a2b |
|
|
Branch CR29349_1 has been deleted by kgv. SHA-1: 7c2161bce774f477ba29dc138f71f3244a7a96e6 |
|
occt: master 2da51263 2017-11-28 05:42:40 Committer: bugmaster Details Diff |
0029349: Foundation Classes, OSD_Timer - add missing theThisThreadOnly constructor option available in OSD_Chronometer OSD_Timer constructor now has theThisThreadOnly option passed to OSD_Chronometer, which is FALSE by default. OSD_Chronometer now provides methods ::UserTimeCPU(), ::SystemTimeCPU() allowing to fetch CPU times without akward syntax through overloaded ::Show(). |
Affected Issues 0029349 |
|
| mod - src/OSD/OSD_Chronometer.cxx | Diff File | ||
| mod - src/OSD/OSD_Chronometer.hxx | Diff File | ||
| mod - src/OSD/OSD_Timer.cxx | Diff File | ||
| mod - src/OSD/OSD_Timer.hxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-11-28 08:39 | kgv | New Issue | |
| 2017-11-28 08:39 | kgv | Assigned To | => abv |
| 2017-11-28 08:44 | git | Note Added: 0072513 | |
| 2017-11-28 08:44 | kgv | Note Added: 0072514 | |
| 2017-11-28 08:44 | kgv | Status | new => resolved |
| 2017-11-28 09:07 |
|
Note Added: 0072515 | |
| 2017-11-28 09:07 |
|
Status | resolved => assigned |
| 2017-11-28 09:18 | git | Note Added: 0072516 | |
| 2017-11-28 09:29 | git | Note Added: 0072517 | |
| 2017-11-28 09:29 | kgv | Note Added: 0072518 | |
| 2017-11-28 09:29 | kgv | Status | assigned => resolved |
| 2017-11-28 10:02 |
|
Note Added: 0072520 | |
| 2017-11-28 10:02 |
|
Assigned To | abv => bugmaster |
| 2017-11-28 10:02 |
|
Status | resolved => reviewed |
| 2017-11-28 12:25 | kgv | Note Edited: 0072518 | |
| 2017-11-28 13:38 | bugmaster | Note Added: 0072532 | |
| 2017-11-28 13:38 | bugmaster | Status | reviewed => tested |
| 2017-11-28 13:39 | bugmaster | Test case number | => Not required |
| 2017-12-02 16:59 | bugmaster | Changeset attached | => occt master 2da51263 |
| 2017-12-02 16:59 | bugmaster | Status | tested => verified |
| 2017-12-02 16:59 | bugmaster | Resolution | open => fixed |
| 2017-12-07 21:08 | git | Note Added: 0072829 | |
| 2017-12-07 21:08 | git | Note Added: 0072830 | |
| 2018-02-20 12:58 |
|
Target Version | 7.4.0 => 7.3.0 |
| 2018-06-29 21:15 |
|
Fixed in Version | => 7.3.0 |
| 2018-06-29 21:19 |
|
Status | verified => closed |
