View Issue Details

IDProjectCategoryView StatusLast Update
0029249Open CASCADEOCCT:Configurationpublic2018-06-29 21:19
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2013 
Product Version7.2.0 
Target Version7.3.0Fixed in Version7.3.0 
Summary0029249: Configuration - Standard_Failure compilation fails on VS2013 + Intel Compiler due to unavailability of thread_local
Description
1>  Standard_Failure.cxx
1>C:\OCCT\src\Standard\Standard_Failure.cxx(81): error # 303: explicit type is missing ("int" assumed)
1>    static Standard_THREADLOCAL Handle(Standard_Failure) RaisedError;


> "c:\Program Files\CMake\bin\cmake" -G "Visual Studio 12 2013 Win64" -T "Intel C++ Compiler 17.0"

From Intel documentation:
> N2659 Thread-local storage:
> Yes on Linux/OS X, Yes on Windows in VS2015 mode
> [Version 15.0*1 & Later].
https://software.intel.com/en-us/articles/c0x-features-supported-by-intel-c-compiler

Within Standard_Failure.cxx:
#elif (defined(__INTEL_COMPILER) && __INTEL_COMPILER > 1400) || \
      (defined(_MSC_VER) && _MSC_VER >= 1900) /* MSVC++ >= 14 */ || \
      (defined(__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8))) /* GCC >= 4.8 */
  #define Standard_THREADLOCAL thread_local

So, I suppose that Intel Compiler relies on features of MSVC C++ Runtime libraries, and thread_local is available only within VS2015+.

Thus, the compiler check should be corrected somehow...

TagsNo tags attached.
Test case numberNot required

Relationships

child of 0028217 closedapn Community Error handling is not thread safe and causing memory corruption and sporadic crashes 

Activities

git

2017-10-24 11:21

administrator   ~0071728

Branch CR29249 has been created by kgv.

SHA-1: 4c4ff4a6a208c53f894ec52594f3c87f7d85f2d5


Detailed log of new commits:

Author: kgv
Date: Tue Oct 24 11:21:03 2017 +0300

    0029249: Configuration - Standard_Failure compilation fails on VS2013 + Intel Compiler due to unavailability of thread_local
    
    Check __INTEL_COMPILER version in combination with _MSC_VER on Windows.

kgv

2017-10-24 11:21

developer   ~0071729

Please check compilation using Intel compiler (and other compilers).

git

2017-11-08 18:24

administrator   ~0072076

Branch CR29249 has been deleted by kgv.

SHA-1: 4c4ff4a6a208c53f894ec52594f3c87f7d85f2d5

Related Changesets

occt: master 777ca20a

2017-10-24 08:21:03

kgv


Committer: bugmaster Details Diff
0029249: Configuration - Standard_Failure compilation fails on VS2013 + Intel Compiler due to unavailability of thread_local

Check __INTEL_COMPILER version in combination with _MSC_VER on Windows.
Affected Issues
0029249
mod - src/Standard/Standard_Failure.cxx Diff File

Issue History

Date Modified Username Field Change
2017-10-19 14:03 kgv New Issue
2017-10-19 14:03 kgv Assigned To => bugmaster
2017-10-19 14:03 kgv Assigned To bugmaster => abv
2017-10-19 14:04 kgv Relationship added child of 0028217
2017-10-24 11:21 git Note Added: 0071728
2017-10-24 11:21 kgv Note Added: 0071729
2017-10-24 11:21 kgv Assigned To abv => bugmaster
2017-10-24 11:21 kgv Status new => feedback
2017-11-02 18:34 bugmaster Changeset attached => occt master 777ca20a
2017-11-02 18:34 bugmaster Status feedback => verified
2017-11-02 18:34 bugmaster Resolution open => fixed
2017-11-08 18:24 git Note Added: 0072076
2017-12-12 10:35 bugmaster Test case number => Not required
2018-06-29 21:15 aiv Fixed in Version => 7.3.0
2018-06-29 21:19 aiv Status verified => closed