View Issue Details

IDProjectCategoryView StatusLast Update
0029187Open CASCADEOCCT:VISpublic2021-09-03 14:13
Reporterapn Assigned Tobugmaster  
PrioritynormalSeverityfeature 
Status assignedResolutionopen 
PlatformmacOS Sierra 10.12 
Product Version6.8.0 
Target Version7.7.0 
Summary0029187: VIS - TKIVtkDraw should support Cocoa on macOS
DescriptionUSE_VTK option was turned on for successfully testing occt on macOS platform. I'm trying to build occt with vtk-7.1.1 (built with option VTK_USE_X) and get following error:
/OCCT_SRC/src/IVtkDraw/IVtkDraw.cxx:217:15: error: use of undeclared identifier 'Xw_Window'; did you mean 'XtWindow'?
/OCCT_SRC/src/IVtkDraw/IVtkDraw.cxx:217:15: error: template argument for template type parameter must be a type
static Handle(Xw_Window)& GetWindow()
              ^~~~~~~~~

Used vtk: /Users/mnt/tools/WOK680/3rdparty/mac64/vtk-7.1.1
TagsNo tags attached.
Test case numberNot needed

Relationships

related to 0032425 assignedbugmaster Tests - adjusting test cases for macOS arm64 platforms 
child of 0022877 closedbugmaster Draw Harness - add plugin for VIS component 
child of 0023243 closedbugmaster Adapt OpenGL viewer for using in Cocoa applications on Mac OS X 

Activities

git

2017-10-11 15:57

administrator   ~0071346

Branch CR29187 has been created by apn.

SHA-1: ee7db175d70852c985cfe0923a0362094cebd5f4


Detailed log of new commits:

Author: apn
Date: Wed Oct 11 15:56:44 2017 +0300

    0029187: VIS - TKIVtkDraw should support Cocoa on macOS
    
    Adding support of Cocoa on macOS
    Fox launching test cases on macOS
    Test cases failed when $lst starts with numeral, because upvar guesses that its first parameter is level rather than otherVar.
    The fix is to explicitly supply level to 1 (default value if uplevel is omitted) to avoid tcl exception "expected integer but got 3dviewer".

git

2017-10-12 18:01

administrator   ~0071382

Branch CR29187 has been updated forcibly by apn.

SHA-1: 2c9aea2ded19f8f5bd85d360c967cf75796345dc

git

2017-10-12 18:26

administrator   ~0071383

Branch CR29187 has been updated forcibly by apn.

SHA-1: 64040ebb714549e3bb46d68709dbfd4ad0655850

apn

2017-10-13 18:40

administrator   ~0071424

Dear kgv, could you please review CR29187.

kgv

2017-10-13 19:00

developer   ~0071428

> Solve compatibility problem with VTK-7.x.x,
> since vtkRenderingFreeTypeOpenGL used only if VTK_OPENGL2_BACKEND is defined.
It looks unrelated to the bug - please move correction for VTK-7 compatibility to another issue.

> Test cases failed when $lst starts with numeral,
> because upvar guesses that its first parameter is level rather than otherVar.
Sorry, how this issue occurred?
It also looks unrelated to this bug.

#ifndef _WIN32
 #include <X11/X.h>
 #include <X11/Shell.h>
 #include <X11/Xlib.h>
 #include <GL/glx.h>
-#include <Xw_Window.hxx>
 #include <vtkXRenderWindowInteractor.h>
 #include <vtkXOpenGLRenderWindow.h>
 #include <X11/Xutil.h>
 #include <tk.h>
#endif

Shouldn't all these X11 includes fail on macOS?

+#elif defined(__APPLE__) && !defined(MACOSX_USE_GLX)
+  // __APPLE__
+#else
+  // _WIN32
+  aRenWin->SetWindowId((void*)GetWindow()->HWindow());
+#endif

How this is supposed to work if Cocoa_Window is not associated with vtkRenderWindow in any way?
Also - broken indentation on these lines.

git

2017-11-01 12:53

administrator   ~0071904

Branch CR29187 has been updated forcibly by apn.

SHA-1: 18bf6aa82f1a4aae7011dcbd1a7b7b1cb55e1a31

Issue History

Date Modified Username Field Change
2017-10-05 14:35 apn New Issue
2017-10-05 14:35 apn Assigned To => kgv
2017-10-05 14:42 kgv Assigned To kgv => san
2017-10-05 14:42 kgv Category OCCT:Visualization => OCCT:VIS
2017-10-05 14:42 kgv Summary Compilation error in IVtkDraw => VIS - TKIVtkDraw should support Cocoa on macOS
2017-10-05 14:42 kgv Relationship added child of 0022877
2017-10-11 15:57 git Note Added: 0071346
2017-10-12 18:01 git Note Added: 0071382
2017-10-12 18:26 git Note Added: 0071383
2017-10-13 18:40 apn Test case number => Not needed
2017-10-13 18:40 apn Note Added: 0071424
2017-10-13 18:40 apn Assigned To san => kgv
2017-10-13 18:40 apn Status new => resolved
2017-10-13 19:00 kgv Note Added: 0071428
2017-10-13 19:00 kgv Assigned To kgv => apn
2017-10-13 19:00 kgv Status resolved => assigned
2017-11-01 12:53 git Note Added: 0071904
2019-07-19 11:38 apn Target Version 7.4.0 => 7.5.0
2020-09-11 16:50 utverdov Target Version 7.5.0 => Unscheduled
2020-09-11 16:54 kgv Severity minor => feature
2020-09-11 16:54 kgv Product Version => 6.8.0
2020-09-11 16:55 kgv Relationship added related to 0023243
2020-09-11 16:55 kgv Relationship replaced child of 0023243
2020-09-21 17:19 bugmaster Assigned To apn => bugmaster
2021-06-10 16:59 kgv Relationship added related to 0032286
2021-06-10 16:59 kgv Relationship deleted related to 0032286
2021-06-10 16:59 kgv Relationship added related to 0032425
2021-09-03 14:13 bugmaster Target Version Unscheduled => 7.7.0