View Issue Details

IDProjectCategoryView StatusLast Update
0029169Open CASCADEOCCT:Configurationpublic2018-06-29 21:19
Reporterkgv Assigned Tobugmaster  
PrioritylowSeverityminor 
Status closedResolutionfixed 
Product Version7.2.0 
Target Version7.3.0Fixed in Version7.3.0 
Summary0029169: Configuration - fix compilation with undefined UNICODE on Windows
DescriptionOCCT is expected to be compiled with UNICODE macros on Windows, however in some cases it can be undefined leading to compilation errors.
Steps To Reproduce0. Install Code::Blocks with MinGW
1. Generate Code::Blocks project on Windows running "genproj cbp"
2. Start codeblocks.bat
3. Build TKernel
TagsNo tags attached.
Test case numberNot required

Relationships

child of 0028110 closedapn Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio 

Activities

git

2017-09-30 19:52

administrator   ~0071084

Branch CR29169 has been created by kgv.

SHA-1: a783861e304be3bfe73bba36b2d89a89a6540944


Detailed log of new commits:

Author: kgv
Date: Sat Sep 30 19:52:10 2017 +0300

    0029169: Configuration - fix compilation with undefined UNICODE on Windows
    
    Eliminated usage of TEXT macros, usage of OSVERSIONINFO instead of OSVERSIONINFOW.
    LoadIcon/LoadCursor are now used instead of LoadIconW/LoadCursorW
    when passing macros to standard resources (which depend on UNICODE flag).

kgv

2017-09-30 19:52

developer   ~0071085

Patch is ready for review.

abv

2017-10-01 13:53

manager   ~0071091

Reviewed with no remarks

git

2017-10-01 21:13

administrator   ~0071100

Branch CR29169 has been updated forcibly by abv.

SHA-1: d6b241ef46f85ac731a033c1cad43bd28f4b52a6

git

2017-10-01 22:07

administrator   ~0071103

Branch CR29169 has been updated forcibly by abv.

SHA-1: 2bd1ffe4423029fe3b0a6808e298ca37e60b8a68

bugmaster

2017-10-03 09:42

administrator   ~0071137

Tested in framework of testing issue 29170

git

2017-10-14 12:20

administrator   ~0071475

Branch CR29169 has been deleted by kgv.

SHA-1: 2bd1ffe4423029fe3b0a6808e298ca37e60b8a68

Related Changesets

occt: master c85a994a

2017-09-30 16:52:10

kgv


Committer: bugmaster Details Diff
0029169: Configuration - fix compilation with undefined UNICODE on Windows

Eliminated usage of TEXT macros, usage of OSVERSIONINFO instead of OSVERSIONINFOW.
LoadIcon/LoadCursor are now used instead of LoadIconW/LoadCursorW
when passing macros to standard resources (which depend on UNICODE flag).
Affected Issues
0029169
mod - src/Draw/init.cxx Diff File
mod - src/OSD/OSD_Host.cxx Diff File
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff File
mod - src/WNT/WNT_WClass.cxx Diff File

Issue History

Date Modified Username Field Change
2017-09-30 19:46 kgv New Issue
2017-09-30 19:46 kgv Assigned To => kgv
2017-09-30 19:52 git Note Added: 0071084
2017-09-30 19:52 kgv Note Added: 0071085
2017-09-30 19:52 kgv Assigned To kgv => abv
2017-09-30 19:52 kgv Priority normal => low
2017-09-30 19:52 kgv Status new => resolved
2017-09-30 19:53 kgv Relationship added child of 0028110
2017-10-01 13:53 abv Note Added: 0071091
2017-10-01 13:53 abv Status resolved => reviewed
2017-10-01 13:53 abv Steps to Reproduce Updated
2017-10-01 13:53 abv Target Version 7.4.0 => 7.3.0
2017-10-01 21:13 git Note Added: 0071100
2017-10-01 22:07 git Note Added: 0071103
2017-10-03 09:42 bugmaster Note Added: 0071137
2017-10-03 09:42 bugmaster Status reviewed => tested
2017-10-03 09:52 bugmaster Test case number => Not required
2017-10-06 14:55 bugmaster Changeset attached => occt master c85a994a
2017-10-06 14:55 bugmaster Assigned To abv => bugmaster
2017-10-06 14:55 bugmaster Status tested => verified
2017-10-06 14:55 bugmaster Resolution open => fixed
2017-10-14 12:20 git Note Added: 0071475
2018-06-29 21:15 aiv Fixed in Version => 7.3.0
2018-06-29 21:19 aiv Status verified => closed