0028966: Coding Rules - remove Adaptor2d_HCurve2d, Adaptor3d_HCurve and Adaptor3d_HSurface classes - MantisBT

MantisBT

Mantis Bug Tracker Workflow

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0028966

Community

[OCCT] OCCT:Coding

public

2017-08-01 15:27

2017-09-15 13:38

Reporter

Vico Liang

Assigned To

kgv

Priority

low

Severity

integration request

Status

new

Resolution

open

Platform

OS

OS Version

Product Version

Target Version

[OCCT] Unscheduled

Fixed in Version

Summary

0028966: Coding Rules - remove Adaptor2d_HCurve2d, Adaptor3d_HCurve and Adaptor3d_HSurface classes

Description

classes Adaptor2d_HCurve2d, Adaptor3d_HCurve, Adaptor3d_HSurface and their subclasses can be removed and their Handle object can be replaced by NCollection_Handle. It's rather boring to write such a wrapper class for any new user defined adaptor curve or surface.

Tags

No tags attached.

Test case number

Relationships

related to	0026373	new	abv	Open CASCADE	Merge NCollection_Handle with opencascade::handle
related to	0024487	closed	abv	Open CASCADE	Getting rid of generic CDL classes
related to	0023997	feedback	abv	Open CASCADE	Getting rid of generic classes in DataExchange

Notes
(0069083) kgv (developer) 2017-08-03 12:08 edited on: 2017-08-03 12:09	Package_HName classes in general (not only within Adaptor2d/Adaptor3d) are not just a wrappers over another existing non-transient classes. They provide own API (method set, which is not always consistent to the wrapped classes) and, therefore, cannot be trivially replaced by NCollection_Handle or NCollection_Shared. Moving in this direction would lead to API changes requiring noticeable modifications inside OCCT itself, as well as porting efforts for existing application. Although such duplication does not look nice, it is questionable if such breaking changes are reasonable.

Issue History
Date Modified	Username	Field	Change
2017-08-01 15:27	Vico Liang	New Issue
2017-08-01 15:27	Vico Liang	Assigned To	=> kgv
2017-08-03 11:58	kgv	Relationship added	related to 0026373
2017-08-03 12:02	kgv	Severity	minor => integration request
2017-08-03 12:02	kgv	Summary	Remove Adaptor2d_HCurve2d, Adaptor3d_HCurve and Adaptor3d_HSurface classes => Coding Rules - remove Adaptor2d_HCurve2d, Adaptor3d_HCurve and Adaptor3d_HSurface classes
2017-08-03 12:03	kgv	Relationship added	related to 0024487
2017-08-03 12:03	kgv	Relationship added	related to 0023997
2017-08-03 12:08	kgv	Note Added: 0069083
2017-08-03 12:09	kgv	Note Edited: 0069083	View Revisions
2017-08-03 12:09	kgv	Priority	normal => low
2017-09-15 13:38	abv	Target Version	7.4.0* => Unscheduled

Copyright © 2000 - 2018 MantisBT Team