View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0028959 | Open CASCADE | OCCT:Configuration | public | 2017-07-29 09:38 | 2017-09-29 16:29 |
| Reporter | Assigned To | ||||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 7.1.0 | ||||
| Target Version | 7.2.0 | Fixed in Version | 7.2.0 | ||
| Summary | 0028959: Configuration, genproj - provide warning on update of scripts in root folder (msvc.bat etc.) | ||||
| Description | Procedure genproj.bat currently overrides file msvc.bat in the root folder by copying template from adm/templates/msvc.bat without any message. It can be quite confusing -- when you modify msvc.bat, it gets overridden silently and your changes get lost. To improve the situation, warning message can be given on override (unless the files are already the same); old copy can be saved in .bak file. | ||||
| Steps To Reproduce | genproj.bat | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Branch CR28959 has been created by abv. SHA-1: 5993c8c6cd261a453a96cff372c06dc546ae7cce Detailed log of new commits: Author: abv Date: Sat Jul 29 09:42:16 2017 +0300 0028959: Configuration, genproj - provide warning on update of scripts in root folder (msvc.bat etc.) When updating files msvc.bat, env.bat/sh, and draw.bat/sh in the root folder by copying template from adm/templates, procedure genproj will give a warning (unless the files are already the same); if the target file is newer, its copy is saved with additional extension .bak. |
|
|
Fix pushed to CR28959, please review. Note that env.bat is now copied verbatim; in previous version it was copied with substitution of CASROOT macro; this was obsolete since env.bat does not contain such macro any more. |
|
|
No remark, please take the patch. |
|
|
Sorry, template for env.sh still contains __CASROOT__ substitution; to be removed and checked |
|
|
Branch CR28959_1 has been created by abv. SHA-1: 708d8ca813a57fb1b17eb0dae5f23a47f1ce7a39 Detailed log of new commits: Author: abv Date: Sat Jul 29 09:42:16 2017 +0300 0028959: Configuration, genproj - provide warning on update of scripts in root folder (msvc.bat etc.) When updating files msvc.bat and draw.bat/sh in the root folder by copying template from adm/templates, procedure genproj will give a warning (unless the files are already the same); if the target file is newer, its copy is saved with additional extension .bak. |
|
|
Previous change was incorrect: in the current approach, products have their own env.bat/sh located in the folder which is current for genproj, and it should not be overwritten. Branch CR28959_1 contains only generation of warning, and no change of the logic. Please integrate. |
|
|
Branch CR28959 has been deleted by kgv. SHA-1: 5993c8c6cd261a453a96cff372c06dc546ae7cce |
|
|
Branch CR28959_1 has been deleted by kgv. SHA-1: 708d8ca813a57fb1b17eb0dae5f23a47f1ce7a39 |
|
occt: master 471a2ca0 2017-07-29 06:42:16
Committer: abv Details Diff |
0028959: Configuration, genproj - provide warning on update of scripts in root folder (msvc.bat etc.) When updating files msvc.bat and draw.bat/sh in the root folder by copying template from adm/templates, procedure genproj will give a warning (unless the files are already the same); if the target file is newer, its copy is saved with additional extension .bak. |
Affected Issues 0028959 |
|
| mod - adm/genproj.tcl | Diff File | ||
| mod - dox/dev_guides/building/code_blocks.md | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-07-29 09:38 |
|
New Issue | |
| 2017-07-29 09:38 |
|
Assigned To | => bugmaster |
| 2017-07-29 09:42 | git | Note Added: 0068861 | |
| 2017-07-29 09:50 |
|
Assigned To | bugmaster => kgv |
| 2017-07-29 09:50 |
|
Status | new => resolved |
| 2017-07-29 09:50 |
|
Steps to Reproduce Updated | |
| 2017-07-29 09:53 |
|
Note Added: 0068862 | |
| 2017-07-29 09:53 |
|
Steps to Reproduce Updated | |
| 2017-07-29 09:53 | kgv | Note Added: 0068863 | |
| 2017-07-29 09:53 | kgv | Assigned To | kgv => bugmaster |
| 2017-07-29 09:53 | kgv | Status | resolved => reviewed |
| 2017-07-29 09:53 | kgv | Steps to Reproduce Updated | |
| 2017-07-29 09:55 |
|
Steps to Reproduce Updated | |
| 2017-07-29 10:07 |
|
Note Added: 0068864 | |
| 2017-07-29 10:07 |
|
Assigned To | bugmaster => abv |
| 2017-07-29 10:07 |
|
Status | reviewed => assigned |
| 2017-08-17 12:31 | git | Note Added: 0069515 | |
| 2017-08-17 12:34 |
|
Note Added: 0069516 | |
| 2017-08-17 12:34 |
|
Assigned To | abv => bugmaster |
| 2017-08-17 12:34 |
|
Status | assigned => resolved |
| 2017-08-17 12:35 |
|
Status | resolved => reviewed |
| 2017-08-17 12:36 | bugmaster | Status | reviewed => tested |
| 2017-08-18 12:53 |
|
Changeset attached | => occt master 471a2ca0 |
| 2017-08-18 12:53 |
|
Assigned To | bugmaster => abv |
| 2017-08-18 12:53 |
|
Status | tested => verified |
| 2017-08-18 12:53 |
|
Resolution | open => fixed |
| 2017-08-18 13:09 | bugmaster | Test case number | => Not required |
| 2017-08-18 17:00 | git | Note Added: 0069642 | |
| 2017-08-18 17:00 | git | Note Added: 0069643 | |
| 2017-09-29 16:17 |
|
Fixed in Version | => 7.2.0 |
| 2017-09-29 16:29 |
|
Status | verified => closed |
