View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0028854 | Community | OCCT:Foundation Classes | public | 2017-06-19 11:03 | 2017-09-29 16:29 |
| Reporter | BenjaminBihler | Assigned To | bugmaster | ||
| Priority | normal | Severity | text | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.2.0 | Fixed in Version | 7.2.0 | ||
| Summary | 0028854: The documentation should state where handle reference counting happens | ||||
| Description | One could think that reference counting happens in handles themselves which would probably forbid creating two distinct handles for the same plain pointer. But actually reference counting is part of Standard_Transient. | ||||
| Steps To Reproduce | Not required | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Branch CR28854 has been created by BenjaminBihler. SHA-1: f4970bf566ca93830856cee65a7b0663c545dded Detailed log of new commits: Author: Benjamin Bihler Date: Mon Jun 19 10:59:22 2017 +0200 0028854: The documentation should state where handle reference counting happens Corrected typo. Author: Benjamin Bihler Date: Mon Jun 19 10:55:26 2017 +0200 0028854: The documentation should state where handle reference counting happens The class commend in Standard_Handle.hxx explains the difference to shared pointers now. |
|
|
Branch CR28854_1 has been created by abv. SHA-1: 7260c9e163b15190868826e37a1bdf2fed115693 Detailed log of new commits: Author: Benjamin Bihler Date: Mon Jun 19 11:55:26 2017 +0300 0028854: The documentation should state where handle reference counting happens The comment to class opencascade::handle<> in Standard_Handle.hxx now explains better the features differing it from std::shared_ptr<>. |
|
|
The changes are reviewed with some amendments; please integrate. Note that no testing is needed -- changes are only in comments. |
|
|
Branch CR28854 has been deleted by kgv. SHA-1: f4970bf566ca93830856cee65a7b0663c545dded |
|
|
Branch CR28854_1 has been deleted by kgv. SHA-1: 7260c9e163b15190868826e37a1bdf2fed115693 |
|
occt: master 1aa738dd 2017-06-19 08:55:26 Committer: bugmaster Details Diff |
0028854: The documentation should state where handle reference counting happens The comment to class opencascade::handle<> in Standard_Handle.hxx now explains better the features differing it from std::shared_ptr<>. |
Affected Issues 0028854 |
|
| mod - src/Standard/Standard_Handle.hxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-06-19 11:03 | BenjaminBihler | New Issue | |
| 2017-06-19 11:03 | BenjaminBihler | Assigned To | => BenjaminBihler |
| 2017-06-19 12:37 | git | Note Added: 0067511 | |
| 2017-06-19 12:37 | BenjaminBihler | Assigned To | BenjaminBihler => abv |
| 2017-06-19 12:37 | BenjaminBihler | Status | new => resolved |
| 2017-06-19 12:37 | BenjaminBihler | Steps to Reproduce Updated | |
| 2017-08-18 17:24 | git | Note Added: 0069672 | |
| 2017-08-21 09:27 |
|
Note Added: 0069691 | |
| 2017-08-21 09:27 |
|
Assigned To | abv => bugmaster |
| 2017-08-21 09:27 |
|
Status | resolved => reviewed |
| 2017-08-21 09:51 | bugmaster | Status | reviewed => tested |
| 2017-08-21 09:51 | bugmaster | Test case number | => Not required |
| 2017-08-25 15:02 | bugmaster | Changeset attached | => occt master 1aa738dd |
| 2017-08-25 15:02 | bugmaster | Status | tested => verified |
| 2017-08-25 15:02 | bugmaster | Resolution | open => fixed |
| 2017-08-25 16:13 | git | Note Added: 0069898 | |
| 2017-08-25 16:13 | git | Note Added: 0069899 | |
| 2017-09-29 16:17 |
|
Fixed in Version | => 7.2.0 |
| 2017-09-29 16:29 |
|
Status | verified => closed |
