View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0028814 | Open CASCADE | OCCT:Documentation | public | 2017-06-05 16:12 | 2017-09-29 16:25 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | integration request | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.2.0 | Fixed in Version | 7.2.0 | ||
| Summary | 0028814: Documentation - suggest using # instead of // for temporary comments in commit description | ||||
| Description | Existing bug advancement workflow suggest the following syntax:Minor corrections ... Minor commits should have a single-line message starting with //. These messages will be ignored when the branch is squashed at integration. The // syntax is familiar to C++ developers, but incompatible with native git tools. When using git, the automatically added comments (e.g. within merge conflict or re-base operation) are started with #, and such comments are automatically withdrawn while confirming commit description within rebase operation. Therefore, it is proposed using # instead of // for consistency with native git tools (or allow both). | ||||
| Steps To Reproduce | N/A | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Branch CR28814 has been created by kgv. SHA-1: f40d05c0709d108217b81ef046cd922e0b1e9e82 Detailed log of new commits: Author: kgv Date: Mon Jun 5 16:15:04 2017 +0300 0028814: Documentation - suggest using # instead of // for temporary comments in commit description |
|
|
Patch is ready for review. |
|
|
No remarks, please integrate. Please also announce this change internally |
|
|
Branch CR28814 has been deleted by kgv. SHA-1: f40d05c0709d108217b81ef046cd922e0b1e9e82 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-06-05 16:12 | kgv | New Issue | |
| 2017-06-05 16:12 | kgv | Assigned To | => kgv |
| 2017-06-05 16:15 | git | Note Added: 0067083 | |
| 2017-06-05 16:15 | kgv | Note Added: 0067084 | |
| 2017-06-05 16:15 | kgv | Assigned To | kgv => abv |
| 2017-06-05 16:15 | kgv | Status | new => resolved |
| 2017-06-07 11:13 |
|
Note Added: 0067171 | |
| 2017-06-07 11:13 |
|
Assigned To | abv => bugmaster |
| 2017-06-07 11:13 |
|
Status | resolved => reviewed |
| 2017-06-09 14:06 | bugmaster | Changeset attached | => occt master d2e4d7b9 |
| 2017-06-09 14:06 | bugmaster | Status | reviewed => verified |
| 2017-06-09 14:06 | bugmaster | Resolution | open => fixed |
| 2017-06-13 17:34 | git | Note Added: 0067354 | |
| 2017-09-29 16:18 |
|
Fixed in Version | => 7.2.0 |
| 2017-09-29 16:25 |
|
Status | verified => closed |
