View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0028704Open CASCADEOCCT:Codingpublic2017-05-02 08:592017-09-29 16:25
Reporterkgv Assigned Tomkv 
PrioritynormalSeverityintegration request 
Status closedResolutionfixed 
Target Version7.2.0Fixed in Version7.2.0 
Summary0028704: Coding Rules - recommend adding the class header first in its source file
DescriptionIt is usual practice to put class header file first in its source file, however the current coding rules do not clarify it.

This simplifies source file identification and helps implicitly validate header file to avoid common C++ problem - missed inclusion of header files by header file.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot needed

Activities

git

2017-05-02 09:09

administrator   ~0065662

Branch CR28704 has been created by kgv.

SHA-1: bcfe48e60192f639f9cb13c164a00d53f374147c


Detailed log of new commits:

Author: kgv
Date: Tue May 2 09:09:27 2017 +0300

    0028704: Coding Rules - recommend adding the class header first in its source file

kgv

2017-05-02 09:09

developer   ~0065663

Patch is ready for review.

abv

2017-05-03 16:38

manager   ~0065727

No remarks, please integrate - no testing is needed

mkv

2017-05-03 18:09

tester   ~0065730

Dear ysn,
could you please review.

ysn

2017-05-11 15:21

developer   ~0065833

I have no remarks.

git

2017-05-11 15:55

administrator   ~0065834

Branch CR28704 has been updated forcibly by mkv.

SHA-1: 629362c6fafe99973b355730e2b677f716c73d2c

mkv

2017-05-11 15:57

tester   ~0065835

TESTED.

git

2017-05-29 16:06

administrator   ~0066763

Branch CR28704 has been deleted by kgv.

SHA-1: 629362c6fafe99973b355730e2b677f716c73d2c

Related Changesets

occt: master 629362c6

2017-05-02 06:09:27

kgv


Committer: mkv Details Diff		 0028704: Coding Rules - recommend adding the class header first in its source file Affected Issues
0028704
mod - dox/dev_guides/contribution/coding_rules.md Diff File

Issue History

Date Modified Username Field Change
2017-05-02 08:59 kgv New Issue
2017-05-02 08:59 kgv Assigned To => kgv
2017-05-02 09:09 git Note Added: 0065662
2017-05-02 09:09 kgv Note Added: 0065663
2017-05-02 09:09 kgv Assigned To kgv => abv
2017-05-02 09:09 kgv Status new => resolved
2017-05-03 16:38 abv Note Added: 0065727
2017-05-03 16:38 abv Assigned To abv => bugmaster
2017-05-03 16:38 abv Status resolved => reviewed
2017-05-03 18:09 mkv Note Added: 0065730
2017-05-03 18:09 mkv Assigned To bugmaster => ysn
2017-05-03 18:09 mkv Status reviewed => feedback
2017-05-11 15:21 ysn Assigned To ysn => mkv
2017-05-11 15:21 ysn Note Added: 0065833
2017-05-11 15:21 ysn Assigned To mkv => bugmaster
2017-05-11 15:21 ysn Status feedback => reviewed
2017-05-11 15:55 git Note Added: 0065834
2017-05-11 15:56 mkv Status reviewed => tested
2017-05-11 15:56 mkv Test case number => Not needed
2017-05-11 15:57 mkv Note Added: 0065835
2017-05-19 13:25 mkv Changeset attached => occt master 629362c6
2017-05-19 13:25 mkv Assigned To bugmaster => mkv
2017-05-19 13:25 mkv Status tested => verified
2017-05-19 13:25 mkv Resolution open => fixed
2017-05-29 16:06 git Note Added: 0066763
2017-09-29 16:18 aiv Fixed in Version => 7.2.0
2017-09-29 16:25 aiv Status verified => closed