| |
| Anonymous | Login | 2021-01-16 03:15 MSK |  |
| My View | View Issues | Change Log | Roadmap |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
| 0028642 | Open CASCADE | [OCCT] OCCT:Modeling Algorithms | public | 2017-04-07 20:56 | 2020-09-14 22:54 | ||||||||
| Reporter | isn | ||||||||||||
| Assigned To | isn | ||||||||||||
| Priority | normal | Severity | minor | ||||||||||
| Status | assigned | Resolution | open | ||||||||||
| Platform | OS | OS Version | |||||||||||
| Product Version | |||||||||||||
| Target Version | [OCCT] 7.6.0* | Fixed in Version | |||||||||||
| Summary | 0028642: BRepOffsetAPI_ThruSections/BRepFill_Generator are modifying the input shape sections | ||||||||||||
| Description | BRepOffsetAPI_ThruSections/BRepFill_Generator algorithms sometimes modify the properties (flags, tolerances, etc..) of the input shape(s) (wire sections). | ||||||||||||
| Steps To Reproduce | (modified version of thrusection specific A1) vertex v1 0 0 0 vertex v2 5 5 0 vertex v3 0 10 0 vertex v4 5 2.5 20 vertex v5 5 2.5 -20 edge e1 v1 v2 edge e2 v2 v3 edge e3 v3 v1 wire w1 e1 e2 e3 setflags v4 locked setflags w1 locked setflags v5 locked thrusections result 0 1 v4 w1 v5 A result of this is an exception ("Algorithm is not done") | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Test case number | |||||||||||||
| Attached Files | |||||||||||||
 Relationships |
 Notes |
|
|
(0065838) git (administrator) 2017-05-11 16:19 |
Branch CR28642 has been created by isn. SHA-1: fe0221c062058e325e60c9c1ca3cdf394a8abeef Detailed log of new commits: Author: isn Date: Wed Apr 5 15:16:40 2017 +0300 0028642: BRepOffsetAPI_ThruSections/BRepFill_Generator are modifying the input shape sections 1) BRepFill_Generator and BRepOffsetAPI_ThruSections now supports 'non-destructive' mode for the input shapes (sections wires). The shape history of this algorithms also has been modified. 2) New test grids (based on the previous ones) has been added. This new cases uses locked shape as input arguments 3) mutable-flag has been added to 'thrusections' command |
|
(0073277) git (administrator) 2018-01-09 17:59 |
Branch CR28642_1 has been created by isn. SHA-1: e589c2c19e0058689a24ad063805b9b66e5108f4 Detailed log of new commits: Author: isn Date: Wed Apr 5 15:16:40 2017 +0300 0028642: BRepOffsetAPI_ThruSections/BRepFill_Generator are modifying the input shape sections 1) BRepFill_Generator and BRepOffsetAPI_ThruSections now supports 'non-destructive' mode for the input shapes (sections wires). The shape history of this algorithms also has been modified. 2) New test grids (based on the previous ones) has been added. This new cases uses locked shape as input arguments 3) mutable-flag has been added to 'thrusections' command |
|
(0073281) isn (developer) 2018-01-10 12:39 |
jenkins test job - CR28642_1-master-isn |
|
(0073348) msv (developer) 2018-01-11 12:46 |
Do the differences in images show regressions? Please check this: Products/Windows-64-VC10: IMAGE sat read_parallel_1 A7: A7.png differs Products/Debian70-64: IMAGE sat read_parallel_1 B7: B7.png differs tests/thrusection/grids.list - mess in the file. After fix it is needed to re-test. src/BRepTest/BRepTest_SweepCommands.cxx - 382: "-save" => "-safe". - add description of the new option in help. src/BRepOffsetAPI/BRepOffsetAPI_ThruSections.hxx - 149,157: add descriptions - rename GetMutableInput to IsMutableInput. src/BRepOffsetAPI/BRepOffsetAPI_ThruSections.cxx - 515: I think it must be cleared in very beginning of Build(). - why myBFGenerator->Modified is called without checking IsModified almost everywhere? - 990: do not use reference for a double value. - 999: let leave it as is in this fix. - 1374: move this code to the scope where FirstEdge is used. src/BRepFill/BRepFill_Generator.hxx - rename GetMutableInput to IsMutableInput. src/BRepFill/BRepFill_Generator.cxx - 617: no, degen edge must not be shared between faces. - 860-870: do this only if degen1/degen2 is false. Add comments what for this code is and why such conditions are used. - 979: if Edge1 is a new one then GeneratedShapes() will work incorrect. It must return generated shapes from the input one. - 993: yes, it will allow avoiding repeated copying. - 1013: use more simple TopoDS_Iterator here. |
|
(0073479) git (administrator) 2018-01-17 16:53 |
Branch CR28642_2 has been created by isn. SHA-1: a3868a3600255002013298899a6d86a71e5a1c3f Detailed log of new commits: Author: isn Date: Tue Jan 16 16:16:12 2018 +0300 corrections Author: isn Date: Wed Apr 5 15:16:40 2017 +0300 0028642: BRepOffsetAPI_ThruSections/BRepFill_Generator are modifying the input shape sections 1) BRepFill_Generator and BRepOffsetAPI_ThruSections now supports 'non-destructive' mode for the input shapes (sections wires). The shape history of this algorithms also has been modified. 2) New test grids (based on the previous ones) has been added. This new cases uses locked shape as input arguments 3) mutable-flag has been added to 'thrusections' command |
|
(0073493) git (administrator) 2018-01-18 16:10 |
Branch CR28642_2 has been updated forcibly by isn. SHA-1: 8ba7a91005d74fd40656c5e385c1462ce5ba783c |
|
(0073500) isn (developer) 2018-01-18 19:53 |
test job is /view/CR28642_2-master-isn/ -- >>IMAGE sat read_parallel_1 A7: A7.png differs >>IMAGE sat read_parallel_1 B7: B7.png differs not reproduced anymore |
|
(0073517) msv (developer) 2018-01-19 13:57 |
Why didn't you followed all previous remarks? Some of below are repetitions of above. src/BRepOffsetAPI/BRepOffsetAPI_ThruSections.cxx - 515: Remove comment and do the proposed above. - 1368: incorrect change. I meant to move all the code 1362-1373 to 1398. - 988: do not use reference for a double value. - 997: remove comment src/BRepFill/BRepFill_Generator.cxx - 977-979: unused variable aRED. - 980: move this line in the scope of below "if". - 1004-1005: remove extra check. - 1024: replace explorer with TopoDS_Iterator here. |
|
(0073532) git (administrator) 2018-01-19 15:59 |
Branch CR28642_2 has been updated by isn. SHA-1: cdd5ead5ad333885019ebb5dbf6cd620a57a5ece Detailed log of new commits: Author: isn Date: Fri Jan 19 15:58:41 2018 +0300 remarks |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-04-07 20:56 | isn | New Issue | |
| 2017-04-07 20:56 | isn | Assigned To | => msv |
| 2017-04-07 20:57 | isn | Assigned To | msv => isn |
| 2017-04-07 20:57 | isn | Status | new => assigned |
| 2017-04-07 20:58 | isn | Steps to Reproduce Updated | View Revisions |
| 2017-04-07 20:59 | isn | Description Updated | View Revisions |
| 2017-04-10 18:07 | isn | Relationship added | child of 0027166 |
| 2017-05-11 16:19 | git | Note Added: 0065838 | |
| 2017-07-24 09:22 | msv | Target Version | 7.2.0 => 7.3.0 |
| 2017-12-05 17:09 | msv | Target Version | 7.3.0 => 7.4.0 |
| 2018-01-09 17:59 | git | Note Added: 0073277 | |
| 2018-01-10 12:39 | isn | Note Added: 0073281 | |
| 2018-01-10 12:39 | isn | Assigned To | isn => msv |
| 2018-01-10 12:39 | isn | Status | assigned => resolved |
| 2018-01-11 12:46 | msv | Note Added: 0073348 | |
| 2018-01-11 12:46 | msv | Assigned To | msv => isn |
| 2018-01-11 12:46 | msv | Status | resolved => assigned |
| 2018-01-17 16:53 | git | Note Added: 0073479 | |
| 2018-01-18 16:10 | git | Note Added: 0073493 | |
| 2018-01-18 19:53 | isn | Note Added: 0073500 | |
| 2018-01-18 19:53 | isn | Assigned To | isn => msv |
| 2018-01-18 19:53 | isn | Status | assigned => resolved |
| 2018-01-19 13:57 | msv | Note Added: 0073517 | |
| 2018-01-19 13:58 | msv | Assigned To | msv => isn |
| 2018-01-19 13:58 | msv | Status | resolved => assigned |
| 2018-01-19 15:59 | git | Note Added: 0073532 | |
| 2019-08-12 16:54 | msv | Target Version | 7.4.0 => 7.5.0 |
| 2020-09-14 22:54 | msv | Target Version | 7.5.0 => 7.6.0* |
|
Issue History |
| Copyright © 2000 - 2021 MantisBT Team |
 |