View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0028622Open CASCADEOCCT:Configurationpublic2017-04-03 16:232017-05-12 11:36
ReporteribsAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionwon't fix 
OSOS X El Capitan 
Product Version7.3.0 
Target Version7.2.0 
Summary0028622: Configuration - xcode.sh doesn't consider ios case
Descriptionif genproj is run with "ios" , generated xcode.sh fails due to it contains a hard-coded path to OCCT workspace file (open -a Xcode ./adm/mac/xcd/OCCT.xcworkspace)
Steps To Reproduce./genproj xcd ios
TagsNo tags attached.
Test case numberNot needed

Activities

git

2017-04-11 15:24

administrator   ~0065140

Branch CR28622 has been created by ibs.

SHA-1: ecc6e781461cdd07617739cdfbc549bb37eb63aa


Detailed log of new commits:

Author: ibs
Date: Tue Apr 11 15:22:18 2017 +0300

    0028622: Configuration - xcode.sh doesn't consider ios case
    
    xcode.sh is generated from a template taking into account current platform (mac|ios)

git

2017-04-11 16:55

administrator   ~0065147

Branch CR28622 has been updated forcibly by ibs.

SHA-1: 196e99db87f6f319b7fe8cfc3888617a679ad96b

git

2017-04-24 13:32

administrator   ~0065466

Branch CR28622 has been updated forcibly by ibs.

SHA-1: aab24f0f0389827be667f39b5602f56472ff794b

ibs

2017-04-24 13:33

developer   ~0065467

sky, could you review the CR28622 occt branch?

kgv

2017-04-24 22:28

developer   ~0065493

Last edited: 2017-04-24 22:31

 
-open -a Xcode ./adm/mac/xcd/OCCT.xcworkspace
+open -a Xcode ./adm/__PLATFORM__/xcd/OCCT.xcworkspace
...
-      "xcd"   { file copy -force -- "$::THE_CASROOT/adm/templates/xcode.sh"      "$::path/xcode.sh" }
+      "xcd"   {
+        set aFileTmpl [open "$::THE_CASROOT/adm/templates/xcode.sh.in" "r"]
+        
+        set aContent [read $aFileTmpl]
+        close $aFileTmpl
+
+        regsub -all -- {__PLATFORM__} $aContent "$thePlatform" aContent
+
+        set anXCodeFile [open "$::path/xcode.sh" "w"]
+        fconfigure $anXCodeFile -translation lf
+        puts $anXCodeFile $aContent
+        close $anXCodeFile
+        
+      }

The patch introduces new approach inconsistent to codeblocks.sh, where environment variable $WOKSTATION is used to identify platform in runtime.

Though current way use by env.sh to define $WOKSTATION is not applicable for iOS, since both iOS and macOS targets are equally possible on macOS host - so it can be passed only through additional argument or as independent xcode_ios.sh script file. So that the single working directory can be used for building OCCT for several platforms at once (though there will be a collision with custom.sh).

By the way, the reason why this problem was not handled in the first place is that xcode.sh was useless for iOS (paths to 3rd-parties are hard-coded into XCode project and Draw Harness can not be launched from XCode anyway) - so I have just opened XCode project file and built project without using any xcode.sh script.

Did something changed and xcode.sh become useful somehow for iOS, or patch is just for consistency with other platforms?

ibs

2017-04-25 15:09

developer   ~0065510

the patch is only for consistency. considering all the above, there is no need in this patch.

ibs

2017-04-25 15:09

developer   ~0065511

dear bugmaster, please close the issue

git

2017-05-12 11:36

administrator   ~0065951

Branch CR28622 has been deleted by kgv.

SHA-1: aab24f0f0389827be667f39b5602f56472ff794b

Issue History

Date Modified Username Field Change
2017-04-03 16:23 ibs New Issue
2017-04-03 16:23 ibs Assigned To => ibs
2017-04-11 15:24 git Note Added: 0065140
2017-04-11 16:55 git Note Added: 0065147
2017-04-13 14:35 mkv Test case number => Not needed
2017-04-24 13:32 git Note Added: 0065466
2017-04-24 13:33 ibs Note Added: 0065467
2017-04-24 13:33 ibs Assigned To ibs => ski
2017-04-24 13:33 ibs Status new => resolved
2017-04-24 13:33 ibs Steps to Reproduce Updated
2017-04-24 22:28 kgv Note Added: 0065493
2017-04-24 22:28 kgv Assigned To ski => ibs
2017-04-24 22:28 kgv Status resolved => assigned
2017-04-24 22:29 kgv Note Edited: 0065493
2017-04-24 22:29 kgv Note Edited: 0065493
2017-04-24 22:31 kgv Note Edited: 0065493
2017-04-25 15:09 ibs Note Added: 0065510
2017-04-25 15:09 ibs Note Added: 0065511
2017-04-25 15:09 ibs Assigned To ibs => bugmaster
2017-04-25 15:09 ibs Status assigned => feedback
2017-04-25 15:09 ibs Resolution open => won't fix
2017-04-26 09:55 bugmaster Status feedback => closed
2017-05-12 11:36 git Note Added: 0065951