0028414: Data Exchange - Step entity not correctly read

(0063235)
abv (manager)
2017-01-31 09:47

Among available STEP viewers:
- Autodesk A360 and GOM Inspect (based on Hoops by TechSoft3D), PTC Creo Elements show this face as almost full torus;
- OCCT, FreeCAD, RGK show it as small part;
- Rhino fails to open it;
- STEP NC shows broken shape.

Thus translation of toruses to and from STEP definitely deserves to be checked.

(0073218)
gdw (developer)
2018-01-02 12:25

Hello,
What is the status of this issue?
Thks in advance
--
gdw

(0073228)
eryar (developer)
2018-01-04 04:34

Hi gdw,

I think this may have relationships with 0027722:
https://tracker.dev.opencascade.org/view.php?id=27722 [^]

(0075740)
gdw (developer)
2018-04-28 12:56

Hello,
The problem seems to be not related to the ellipse but preferably to the BSP subtraction.

In the file bug_tore, if
0000329 = ADVANCED_FACE( '', ( #749 ), #750, .T. );

is replaced by
0000329 = ADVANCED_FACE( '', ( ), #750, .T. );

the tore is read by occ; otherwise, only the cookie is read...

Hope this help
--
Guilhem

(0075755)
gdw (developer)
2018-05-01 17:39

Hi,

After investigations, the problem seems to come from the way the tore is cut by the wire in the ADVANCED_FACE: the part that should kept is 'outside' while occ keeps 'inside', as shown in the screenshots (the yellow one is correct while the gray one is what occ produces).
Currently I am trying to investigate in BrepMesh_FastDiscret.cxx that actually triangule the tore...
Help will infinitely appreciated!
--
Guilhem

(0075949)
gdw (developer)
2018-05-12 10:52

More over, the problem seems to come when some B_SPLINE_CURVE_WITH_KNOTS are involved in the EdgeLoop of the ADVANCED_FACE; not sure that the problem is limited if the surface of the ADVANCED_FACE is a torus...
Feedback and help greatly appreciated!

(0076020)
gdw (developer)
2018-05-18 08:16

We have temporarily fixed the problem by suppressing the edge part of the advanced face if the target form is a toroids and if the edges are made exclusively with knots surface. This inly a work around...

(0078684)
gdw (developer)
2018-08-19 13:14

For more information, the problem comes from FACE_OUTER_BOUND...

(0096872)
git (administrator)
2020-11-18 11:25

Branch CR28414 has been created by skl.

SHA-1: bb7eb4c1dcfbf802ef04563fa71057a66e5c9354

Detailed log of new commits:

Author: skl
Date: Wed Nov 18 11:25:19 2020 +0300

    0028414: Step entity not correctly read.

    Temporary check

(0096888)
git (administrator)
2020-11-18 17:20

Branch CR28414 has been updated forcibly by skl.

SHA-1: 004ecab95df2de6782e447fe3c11a6476e1aa640

(0096926)
git (administrator)
2020-11-21 06:56

Branch CR28414 has been updated forcibly by skl.

SHA-1: c896d7915a7b5778780886baea246d40d41b5a01

(0096991)
git (administrator)
2020-11-22 08:49

Branch CR28414 has been updated by skl.

SHA-1: 619d87b8f54e5c84a51977aab8cefdee64292934

Detailed log of new commits:

Author: skl
Date: Sun Nov 22 08:49:42 2020 +0300

    0028414: Data Exchange - Step entity not correctly read

    Check temporary solution.

(0097012)
git (administrator)
2020-11-23 17:46

Branch CR28414 has been updated forcibly by skl.

SHA-1: 19a36cbd1a6a827b973504a2f70bc8cc1b016153

(0097019)
git (administrator)
2020-11-24 07:52

Branch CR28414 has been updated by skl.

SHA-1: ddcc1b69c480fa442357e07a5008b7f550445c1a

Detailed log of new commits:

Author: skl
Date: Tue Nov 24 07:52:37 2020 +0300

    0028414: Data Exchange - Step entity not correctly read

    Temporary check

(0097031)
git (administrator)
2020-11-24 15:14

Branch CR28414 has been updated by skl.

SHA-1: fb9dc489fa78bf7b76a0d9b8d94ca5141f068d5a

Detailed log of new commits:

Author: skl
Date: Tue Nov 24 15:13:57 2020 +0300

    0028414: Data Exchange - Step entity not correctly read

    Next version of fix.

(0097105)
skl (developer)
2020-11-27 11:25

Please add attached file bug28414.stp to repository.

(0097106)
git (administrator)
2020-11-27 11:32

Branch CR28414 has been updated forcibly by skl.

SHA-1: 1269f76c49956bd40f960e68df86c7cad3d5c44b

(0097147)
git (administrator)
2020-11-30 09:41

Branch CR28414 has been updated forcibly by skl.

SHA-1: 6284b2343419ec0f0e6ce085f654cfa68ffe34d1

(0097148)
git (administrator)
2020-11-30 09:51

Branch CR28414 has been updated forcibly by skl.

SHA-1: c7f54f5a958998dc3e8bdd82bd832e42c5c671a7

(0097152)
git (administrator)
2020-11-30 11:28

Branch CR28414 has been updated forcibly by skl.

SHA-1: 05acd7b3ff27b5f086fdf150204e04e8a72f7b59

(0097157)
git (administrator)
2020-11-30 11:49

Branch CR28414 has been updated forcibly by skl.

SHA-1: 2f271272bc9a0b891641f40e065b5033f6809609

(0097188)
git (administrator)
2020-12-01 11:21

Branch CR28414 has been updated forcibly by skl.

SHA-1: 1845b616e017458971d19fba0a48b344231bacd2

(0097189)
skl (developer)
2020-12-01 11:24

For entity FACE_BOUND if surface is torus and orientation is True temporary natural bound is created. Later in the ShapeFix_Face this bound is removed but special flag myTorusReverseFlag is activated. Value of this flag is used for decision what part of torus must be used.

Result of tests:
http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR28414-master-skl/view/COMPARE/ [^]

(0097252)
gka (developer)
2020-12-02 18:26

Dear Sergey.

Could you please return previous formatting and add detail comments for new flag added for healing of toroidal faces and modified behavior.

(0097257)
git (administrator)
2020-12-03 10:05

Branch CR28414 has been updated forcibly by skl.

SHA-1: 88f4030f0529b339d964d492b4fc69e14f6486c7

(0097263)
skl (developer)
2020-12-03 12:10

Result of tests:
http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR28414-master-skl/view/COMPARE/ [^]

(0097316)
gka (developer)
2020-12-04 12:47

Dear Andrey.

Could you please review this fix.

Issue History
Date Modified	Username	Field	Change
2017-01-30 19:28	gdw	New Issue
2017-01-30 19:28	gdw	Assigned To	=> san
2017-01-30 19:28	gdw	File Added: StepBug.zip
2017-01-30 19:36	san	Assigned To	san => gka
2017-01-30 19:36	san	Category	PRODUCTS:Volume Rendering => OCCT:Data Exchange
2017-01-31 09:47	abv	Note Added: 0063235
2017-02-02 14:22	abv	Relationship added	related to 0025523
2017-08-30 14:57	mkv	Test case number	=> bugs step bug28414
2017-10-02 15:45	apv	Test case number	bugs step bug28414 => Not required
2018-01-02 12:25	gdw	Note Added: 0073218
2018-01-04 04:34	eryar	Note Added: 0073228
2018-04-28 12:56	gdw	File Added: bug_tore.stp
2018-04-28 12:56	gdw	Note Added: 0075740
2018-05-01 17:33	gdw	File Added: Capture d’écran 2018-05-01 à 16.32.27.png
2018-05-01 17:34	gdw	File Added: Capture d’écran 2018-05-01 à 16.32.54.png
2018-05-01 17:39	gdw	Note Added: 0075755
2018-05-12 10:52	gdw	Note Added: 0075949
2018-05-18 08:16	gdw	Note Added: 0076020
2018-05-26 21:10	abv	Target Version	=> 7.4.0
2018-05-26 21:10	abv	Relationship added	related to 0029564
2018-08-19 13:14	gdw	Note Added: 0078684
2019-09-04 15:36	abv	Target Version	7.4.0 => 7.5.0
2020-09-17 19:49	gka	Target Version	7.5.0 => 7.6.0*
2020-11-12 13:54	szy	Assigned To	gka => skl
2020-11-12 13:54	szy	Status	new => assigned
2020-11-18 11:25	git	Note Added: 0096872
2020-11-18 11:40	kgv	Summary	Step entity not correctly read. => Data Exchange - Step entity not correctly read
2020-11-18 17:20	git	Note Added: 0096888
2020-11-21 06:56	git	Note Added: 0096926
2020-11-22 08:49	git	Note Added: 0096991
2020-11-23 17:46	git	Note Added: 0097012
2020-11-24 07:52	git	Note Added: 0097019
2020-11-24 15:14	git	Note Added: 0097031
2020-11-27 11:23	skl	File Added: bug28414.stp
2020-11-27 11:25	skl	Note Added: 0097105
2020-11-27 11:32	git	Note Added: 0097106
2020-11-30 09:41	git	Note Added: 0097147
2020-11-30 09:51	git	Note Added: 0097148
2020-11-30 11:28	git	Note Added: 0097152
2020-11-30 11:49	git	Note Added: 0097157
2020-12-01 11:21	git	Note Added: 0097188
2020-12-01 11:24	skl	Note Added: 0097189
2020-12-01 11:24	skl	Assigned To	skl => gka
2020-12-01 11:24	skl	Status	assigned => resolved
2020-12-01 11:24	skl	Steps to Reproduce Updated	View Revisions
2020-12-02 18:26	gka	Note Added: 0097252
2020-12-02 18:26	gka	Assigned To	gka => skl
2020-12-02 18:26	gka	Status	resolved => assigned
2020-12-03 10:05	git	Note Added: 0097257
2020-12-03 12:10	skl	Note Added: 0097263
2020-12-03 12:10	skl	Assigned To	skl => gka
2020-12-03 12:10	skl	Status	assigned => resolved
2020-12-04 12:47	gka	Note Added: 0097316
2020-12-04 12:47	gka	Assigned To	gka => abv
2020-12-04 12:47	gka	Status	resolved => assigned
2020-12-04 12:48	gka	Assigned To	abv => gka
2020-12-04 12:48	gka	Status	assigned => resolved
2020-12-09 13:49	abv	Assigned To	gka => abv
2020-12-12 07:45	abv	Relationship added	related to 0027722

Notes
(0063235) abv (manager) 2017-01-31 09:47	Among available STEP viewers: - Autodesk A360 and GOM Inspect (based on Hoops by TechSoft3D), PTC Creo Elements show this face as almost full torus; - OCCT, FreeCAD, RGK show it as small part; - Rhino fails to open it; - STEP NC shows broken shape. Thus translation of toruses to and from STEP definitely deserves to be checked.

(0073218) gdw (developer) 2018-01-02 12:25	Hello, What is the status of this issue? Thks in advance -- gdw

(0073228) eryar (developer) 2018-01-04 04:34	Hi gdw, I think this may have relationships with 0027722: https://tracker.dev.opencascade.org/view.php?id=27722 [^]

(0075740) gdw (developer) 2018-04-28 12:56	Hello, The problem seems to be not related to the ellipse but preferably to the BSP subtraction. In the file bug_tore, if 0000329 = ADVANCED_FACE( '', ( #749 ), #750, .T. ); is replaced by 0000329 = ADVANCED_FACE( '', ( ), #750, .T. ); the tore is read by occ; otherwise, only the cookie is read... Hope this help -- Guilhem

(0075755) gdw (developer) 2018-05-01 17:39	Hi, After investigations, the problem seems to come from the way the tore is cut by the wire in the ADVANCED_FACE: the part that should kept is 'outside' while occ keeps 'inside', as shown in the screenshots (the yellow one is correct while the gray one is what occ produces). Currently I am trying to investigate in BrepMesh_FastDiscret.cxx that actually triangule the tore... Help will infinitely appreciated! -- Guilhem

(0075949) gdw (developer) 2018-05-12 10:52	More over, the problem seems to come when some B_SPLINE_CURVE_WITH_KNOTS are involved in the EdgeLoop of the ADVANCED_FACE; not sure that the problem is limited if the surface of the ADVANCED_FACE is a torus... Feedback and help greatly appreciated!

(0076020) gdw (developer) 2018-05-18 08:16	We have temporarily fixed the problem by suppressing the edge part of the advanced face if the target form is a toroids and if the edges are made exclusively with knots surface. This inly a work around...

(0078684) gdw (developer) 2018-08-19 13:14	For more information, the problem comes from FACE_OUTER_BOUND...

(0096872) git (administrator) 2020-11-18 11:25	Branch CR28414 has been created by skl. SHA-1: bb7eb4c1dcfbf802ef04563fa71057a66e5c9354 Detailed log of new commits: Author: skl Date: Wed Nov 18 11:25:19 2020 +0300 0028414: Step entity not correctly read. Temporary check

(0096888) git (administrator) 2020-11-18 17:20	Branch CR28414 has been updated forcibly by skl. SHA-1: 004ecab95df2de6782e447fe3c11a6476e1aa640

(0096926) git (administrator) 2020-11-21 06:56	Branch CR28414 has been updated forcibly by skl. SHA-1: c896d7915a7b5778780886baea246d40d41b5a01

(0096991) git (administrator) 2020-11-22 08:49	Branch CR28414 has been updated by skl. SHA-1: 619d87b8f54e5c84a51977aab8cefdee64292934 Detailed log of new commits: Author: skl Date: Sun Nov 22 08:49:42 2020 +0300 0028414: Data Exchange - Step entity not correctly read Check temporary solution.

(0097012) git (administrator) 2020-11-23 17:46	Branch CR28414 has been updated forcibly by skl. SHA-1: 19a36cbd1a6a827b973504a2f70bc8cc1b016153

(0097019) git (administrator) 2020-11-24 07:52	Branch CR28414 has been updated by skl. SHA-1: ddcc1b69c480fa442357e07a5008b7f550445c1a Detailed log of new commits: Author: skl Date: Tue Nov 24 07:52:37 2020 +0300 0028414: Data Exchange - Step entity not correctly read Temporary check

(0097031) git (administrator) 2020-11-24 15:14	Branch CR28414 has been updated by skl. SHA-1: fb9dc489fa78bf7b76a0d9b8d94ca5141f068d5a Detailed log of new commits: Author: skl Date: Tue Nov 24 15:13:57 2020 +0300 0028414: Data Exchange - Step entity not correctly read Next version of fix.

(0097105) skl (developer) 2020-11-27 11:25	Please add attached file bug28414.stp to repository.

(0097106) git (administrator) 2020-11-27 11:32	Branch CR28414 has been updated forcibly by skl. SHA-1: 1269f76c49956bd40f960e68df86c7cad3d5c44b

(0097147) git (administrator) 2020-11-30 09:41	Branch CR28414 has been updated forcibly by skl. SHA-1: 6284b2343419ec0f0e6ce085f654cfa68ffe34d1

(0097148) git (administrator) 2020-11-30 09:51	Branch CR28414 has been updated forcibly by skl. SHA-1: c7f54f5a958998dc3e8bdd82bd832e42c5c671a7

(0097152) git (administrator) 2020-11-30 11:28	Branch CR28414 has been updated forcibly by skl. SHA-1: 05acd7b3ff27b5f086fdf150204e04e8a72f7b59

(0097157) git (administrator) 2020-11-30 11:49	Branch CR28414 has been updated forcibly by skl. SHA-1: 2f271272bc9a0b891641f40e065b5033f6809609

(0097188) git (administrator) 2020-12-01 11:21	Branch CR28414 has been updated forcibly by skl. SHA-1: 1845b616e017458971d19fba0a48b344231bacd2

(0097189) skl (developer) 2020-12-01 11:24	For entity FACE_BOUND if surface is torus and orientation is True temporary natural bound is created. Later in the ShapeFix_Face this bound is removed but special flag myTorusReverseFlag is activated. Value of this flag is used for decision what part of torus must be used. Result of tests: http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR28414-master-skl/view/COMPARE/ [^]

(0097252) gka (developer) 2020-12-02 18:26	Dear Sergey. Could you please return previous formatting and add detail comments for new flag added for healing of toroidal faces and modified behavior.

(0097257) git (administrator) 2020-12-03 10:05	Branch CR28414 has been updated forcibly by skl. SHA-1: 88f4030f0529b339d964d492b4fc69e14f6486c7

(0097263) skl (developer) 2020-12-03 12:10	Result of tests: http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR28414-master-skl/view/COMPARE/ [^]

(0097316) gka (developer) 2020-12-04 12:47	Dear Andrey. Could you please review this fix.