MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0028372Open CASCADE[OCCT] OCCT:Foundation Classespublic2017-01-18 17:302017-07-27 10:38
Reporterabv 
Assigned Todbp 
PrioritynormalSeverityminor 
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.4.0*Fixed in Version 
Summary0028372: BVH_Tree class refactoring
DescriptionAs discovered during review of fix for 0028368, current implementation of class BVH_Tree is confusing:

1. Structures BVH_BinaryTree (and BVH_QuadTree) and class BVH_TreeBase are defined not in the same-named headers but in BVH_Tree.hxx. This looks illogical. Note that in OCCT we have convention that a class should notmally be defined within the same-name header.

2. The names like BVH_Tree and BVH_BinaryTree are suggesting that the latter is successor of the former. This is not the case. Instead, BVH_Tree is dummy that has two specializations, while BVH_BinaryTree and BVH_QuadTree are just tags used to trigger specializations. It seems to be more straightforward just to define class BVH_Tree (or BVH_TreeBase) and two descendants, BVH_BinaryTree and BVH_QuadTree, providing relevant specializations.
TagsNo tags attached.
Test case number
Attached Files

- Relationships
related to 0028368closedapn TKMath, BVH - Fix invalid tree height in QBVH 

-  Notes
There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
2017-01-18 17:30 abv New Issue
2017-01-18 17:30 abv Assigned To => abv
2017-01-18 17:30 abv Relationship added related to 0028368
2017-01-18 17:32 abv Assigned To abv => dbp
2017-01-18 17:32 abv Status new => assigned
2017-07-27 10:38 abv Target Version 7.2.0 => 7.4.0*


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker