View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0028369 | Open CASCADE | OCCT:Visualization | public | 2017-01-18 13:44 | 2017-09-29 16:24 |
| Reporter | Assigned To | apn | |||
| Priority | normal | Severity | feature | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.2.0 | Fixed in Version | 7.2.0 | ||
| Summary | 0028369: Visualization, Path Tracing - Expose radiance clamping setting in path tracing mode | ||||
| Description | In some cases, it is very desirable to control radiance clamping value used by path tracing engine. Smaller value allows to decrease visible noise and get final result (sometimes much) faster, but it introduces extra bias. The main drawback is that caustics may become more dark or even dissapear. The higher value allows to keep path tracing unbiased, but may require more time for image convergence. The default value provides reasonable compromise between these properties, but it is not suitable for all the cases. So, the parameter to control this value is needed. | ||||
| Steps To Reproduce | vrenderparams -maxrad <value> | ||||
| Tags | No tags attached. | ||||
| Test case number | v3d raytrace sample_cube_clamp | ||||
|
|
Branch CR28369 has been created by dbp. SHA-1: db3ba90015e7e796612b3b0a9b55a8a83cea322a Detailed log of new commits: Author: dbp Date: Wed Jan 18 14:24:13 2017 +0300 0028369: Visualization, Path Tracing - Expose radiance clamping setting in path tracing mode New parameter was added in the vrenderparams command: vrenderparams -maxrad <value> |
|
2017-01-18 14:35 developer |
sample_cube_clamp_1.png (314,275 bytes) |
|
2017-01-18 14:35 developer |
sample_cube_clamp_2.png (338,138 bytes) |
|
2017-01-18 14:35 developer |
sample_cube_clamp_10.png (363,139 bytes) |
|
2017-01-18 14:35 developer |
sample_cube_clamp_100.png (369,983 bytes) |
|
|
Dear kgv, Could you please the patch in branch CR28369? |
|
|
New test case was added: test v3d raytrace sample_cube_clamp Reference images are attached to this issue. |
|
|
Shader resource files are not re-generated. |
|
|
Branch CR28369 has been updated forcibly by dbp. SHA-1: f12626f4ad83e8ee49cf79f797ef447096423705 |
|
|
Shader resources were regenerated. |
|
|
Please test the patch. |
|
|
Dear BugMaster, Branch CR28369 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested. SHA-1: f12626f4ad83e8ee49cf79f797ef447096423705 Number of compiler warnings: occt component: Linux: 0 (0 on master) Windows: 0 (0 on master) MasOS: 0 (0 on master) products component: Linux: 63 Windows: 0 MacOS: 1144 Regressions/Differences: Not detected Testing cases: v3d raytrace sample_cube_clamp - OK http://occt-tests/CR28369-master-OCCT/Debian70-64/v3d/raytrace/sample_cube_clamp.html http://occt-tests/CR28369-master-OCCT/Windows-64-VC10/v3d/raytrace/sample_cube_clamp.html Testing on Linux: Total MEMORY difference: 93510686 / 92923112 [+0.63%] Total CPU difference: 21396.580000000173 / 21506.1200000003 [-0.51%] Testing on Windows: Total MEMORY difference: 58632152 / 58649007 [-0.03%] Total CPU difference: 19512.745480898564 / 19749.742200098677 [-1.20%] |
|
|
Branch CR28369 has been deleted by kgv. SHA-1: f12626f4ad83e8ee49cf79f797ef447096423705 |
|
occt: master b09447ed 2017-01-18 11:24:13
Committer: apn Details Diff |
0028369: Visualization, Path Tracing - Expose radiance clamping setting in path tracing mode New parameter was added in the vrenderparams command: vrenderparams -maxrad <value> |
Affected Issues 0028369 |
|
| mod - src/Graphic3d/Graphic3d_RenderingParams.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_View.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_View_Raytrace.cxx | Diff File | ||
| mod - src/Shaders/PathtraceBase.fs | Diff File | ||
| mod - src/Shaders/RaytraceRender.fs | Diff File | ||
| mod - src/Shaders/Shaders_PathtraceBase_fs.pxx | Diff File | ||
| mod - src/Shaders/Shaders_RaytraceRender_fs.pxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
| add - tests/v3d/raytrace/sample_cube_clamp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-01-18 13:44 |
|
New Issue | |
| 2017-01-18 13:44 |
|
Assigned To | => dbp |
| 2017-01-18 14:35 | git | Note Added: 0062750 | |
| 2017-01-18 14:35 |
|
File Added: sample_cube_clamp_1.png | |
| 2017-01-18 14:35 |
|
File Added: sample_cube_clamp_2.png | |
| 2017-01-18 14:35 |
|
File Added: sample_cube_clamp_10.png | |
| 2017-01-18 14:35 |
|
File Added: sample_cube_clamp_100.png | |
| 2017-01-18 14:36 |
|
Note Added: 0062751 | |
| 2017-01-18 14:36 |
|
Assigned To | dbp => kgv |
| 2017-01-18 14:36 |
|
Status | new => resolved |
| 2017-01-18 14:36 |
|
Steps to Reproduce Updated | |
| 2017-01-18 14:37 |
|
Note Added: 0062753 | |
| 2017-01-18 16:10 | kgv | Note Added: 0062761 | |
| 2017-01-18 16:10 | kgv | Assigned To | kgv => dbp |
| 2017-01-18 16:10 | kgv | Status | resolved => feedback |
| 2017-01-18 16:56 | git | Note Added: 0062763 | |
| 2017-01-18 16:56 |
|
Note Added: 0062765 | |
| 2017-01-18 16:56 |
|
Assigned To | dbp => kgv |
| 2017-01-18 16:56 |
|
Status | feedback => resolved |
| 2017-01-18 16:58 | kgv | Note Added: 0062766 | |
| 2017-01-18 16:58 | kgv | Assigned To | kgv => bugmaster |
| 2017-01-18 16:58 | kgv | Severity | minor => feature |
| 2017-01-18 16:58 | kgv | Status | resolved => reviewed |
| 2017-01-18 17:34 |
|
Test case number | => v3d raytrace sample_cube_clamp |
| 2017-01-18 17:34 |
|
Assigned To | bugmaster => apv |
| 2017-01-19 15:07 |
|
Note Added: 0062802 | |
| 2017-01-19 15:07 |
|
Assigned To | apv => bugmaster |
| 2017-01-19 15:07 |
|
Status | reviewed => tested |
| 2017-01-20 16:12 | apn | Changeset attached | => occt master b09447ed |
| 2017-01-20 16:12 | apn | Assigned To | bugmaster => apn |
| 2017-01-20 16:12 | apn | Status | tested => verified |
| 2017-01-20 16:12 | apn | Resolution | open => fixed |
| 2017-02-08 11:36 | git | Note Added: 0063618 | |
| 2017-09-29 16:21 |
|
Fixed in Version | => 7.2.0 |
| 2017-09-29 16:24 |
|
Status | verified => closed |
