View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0028313 | Open CASCADE | OCCT:DRAW | public | 2016-12-28 17:56 | 2017-09-29 16:25 |
Reporter | Assigned To | apn | |||
Priority | normal | Severity | integration request | ||
Status | closed | Resolution | fixed | ||
Target Version | 7.2.0 | Fixed in Version | 7.2.0 | ||
Summary | 0028313: Extend Draw functionality with some new useful commands and features | ||||
Description | I propose to integrate in OCCT some useful Draw commands and features that I use permanently in my work. They include extension of main TK window with buttons that allow manipulation of view by mouse, and a set of new TCL procedures. | ||||
Steps To Reproduce | None | ||||
Tags | No tags attached. | ||||
Test case number | Not needed | ||||
|
Branch CR28313 has been created by msv. SHA-1: 48ed979904df96d6bc77a436cc5b6f48b315cb3e Detailed log of new commits: Author: msv Date: Wed Dec 28 18:12:17 2016 +0300 0028313: Extend Draw functionality with some new useful commands and features 1) In Views menu the check button item "Extended view commands" has been added. Pressing on it shows/hides the set of buttons in the main window that allow manipulating of view zoom/pan/rotate by mouse. 2) New category of commands "Vector and measurement Commands" has been added. The commands in this category allow simple calculations using 2D and 3D vectors, such as cross and dot products, computation of distances of points to other objects, and other functions. 3) The new command "pickf" has been added in "DRAW Variables management" category. It allows extracting a picked with mouse face included in some shape as a new variable. 4) New commands "del" and "era" have been added in "DRAW Variables management" category. They allow deleting (destructing) or erasing (from view) variables matched by glob pattern. 5) Help for commands "don", "donl", "disp" has been added. |
|
Dear Andrey, please review the branch CR28313. |
|
It is necessary to mention these modifications in the documentation. The most suitable places are (IMHO): 1) Draw Test Harness 2) Debugging tools and hints. |
|
As we discussed, please consider removing duplicate DRAW commands, such as don and donl |
|
Branch CR28313 has been updated forcibly by msv. SHA-1: 98d46a86e1b96750b93febae08431c27f6a8937f |
|
Branch CR28313_1 has been created by msv. SHA-1: 41b95d7518cdda04d51237570e598d0551280951 Detailed log of new commits: Author: msv Date: Wed Dec 28 18:12:17 2016 +0300 0028313: Extend Draw functionality with some new useful commands and features 1) In Views menu the check button item "Extended view commands" has been added. Pressing on it shows/hides the set of buttons in the main window that allow manipulating of view zoom/pan/rotate by mouse. 2) New category of commands "Vector and measurement Commands" has been added. The commands in this category allow simple calculations using 2D and 3D vectors, such as cross and dot products, computation of distances of points to other objects, and other functions. 3) The new command "pickf" has been added in "DRAW Variables management" category. It allows extracting a picked with mouse face included in some shape as a new variable. 4) New commands "del" and "era" have been added in "DRAW Variables management" category. They allow deleting (destructing) or erasing (from view) variables matched by glob pattern. 5) Missing help for some commands like "don", "disp" and others has been added. |
|
Please review again. |
|
Can you please rearrange commands "help" and definition of DRAW Tcl procedures so that help is before the procedure, not after it? This is common practice to put comment before the method, not at the end. Currently the order is reversed and it is quite confusing. |
|
I agree. I did so as continuation of old code. |
|
Branch CR28313_1 has been updated by msv. SHA-1: b11ef89c1e4e9091dbe9aba645625e44d30013b9 Detailed log of new commits: Author: msv Date: Thu Jan 26 13:11:18 2017 +0300 //Put help for the commands before their definition. |
|
Done. Please review. |
|
No more remarks, please test |
|
Branch CR28313_1 has been updated forcibly by apv. SHA-1: c1b62227de86dd3441e27140505d4f18aa5570d4 |
|
Branch CR28313_1 has been rebased on IR-2017-01-26 |
|
Dear BugMaster, Branch CR27313_1 from occt git-repository (and IR-2017-01-26 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested. SHA-1: c1b62227de86dd3441e27140505d4f18aa5570d4 Number of compiler warnings: occt component: Linux: 0 (0 on master) Windows: 0 (0 on master) MasOS: 0 (0 on master) products component: Linux: 63 Windows: 0 MacOS: 1122 Regressions/Differences: Not detected Testing cases: Not needed Testing on Linux: Total MEMORY difference: 91728285 / 92310306 [-0.63%] Total CPU difference: 19775.180000000182 / 19914.260000000217 [-0.70%] Testing on Windows: Total MEMORY difference: 57618713 / 57618048 [+0.00%] Total CPU difference: 18450.394270998622 / 18683.178963198647 [-1.25%] |
|
Branch CR28313 has been deleted by kgv. SHA-1: 98d46a86e1b96750b93febae08431c27f6a8937f |
|
Branch CR28313_1 has been deleted by kgv. SHA-1: c1b62227de86dd3441e27140505d4f18aa5570d4 |
occt: master 472634fa 2017-02-02 12:57:58
Committer: apn Details Diff |
0028313: Extend Draw functionality with some new useful commands and features 1) In Views menu the check button item "Extended view commands" has been added. Pressing on it shows/hides the set of buttons in the main window that allow manipulating of view zoom/pan/rotate by mouse. 2) New category of commands "Vector and measurement Commands" has been added. The commands in this category allow simple calculations using 2D and 3D vectors, such as cross and dot products, computation of distances of points to other objects, and other functions. 3) The new command "pickf" has been added in "DRAW Variables management" category. It allows extracting a picked with mouse face included in some shape as a new variable. 4) New commands "del" and "era" have been added in "DRAW Variables management" category. They allow deleting (destructing) or erasing (from view) variables matched by glob pattern. 5) Missing help for some commands like "don", "disp" and others has been added. |
Affected Issues 0028313 |
|
mod - dox/user_guides/draw_test_harness/draw_test_harness.md | Diff File | ||
mod - src/DrawResources/DrawDefault | Diff File | ||
mod - src/DrawResources/DrawTK.tcl | Diff File | ||
mod - src/DrawResources/Geometry.tcl | Diff File | ||
mod - src/DrawResources/Move.tcl | Diff File | ||
mod - src/DrawResources/StandardCommands.tcl | Diff File | ||
add - src/DrawResources/Vector.tcl | Diff File | ||
mod - tests/bugs/moddata_2/bug354_2 | Diff File | ||
mod - tests/bugs/moddata_2/bug592 | Diff File | ||
mod - tests/bugs/moddata_2/bug6862_8 | Diff File | ||
mod - tests/bugs/moddata_2/bug6862_9 | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-12-28 17:56 |
|
New Issue | |
2016-12-28 17:56 |
|
Assigned To | => msv |
2016-12-28 18:12 | git | Note Added: 0062268 | |
2016-12-28 18:13 |
|
Status | new => assigned |
2016-12-28 18:14 |
|
Note Added: 0062269 | |
2016-12-28 18:14 |
|
Assigned To | msv => abv |
2016-12-28 18:14 |
|
Status | assigned => resolved |
2016-12-29 10:40 |
|
Note Added: 0062293 | |
2017-01-03 17:25 |
|
Note Added: 0062397 | |
2017-01-03 17:25 |
|
Assigned To | abv => msv |
2017-01-03 17:25 |
|
Status | resolved => assigned |
2017-01-23 15:59 | git | Note Added: 0062910 | |
2017-01-23 16:01 | git | Note Added: 0062911 | |
2017-01-23 16:03 |
|
Note Added: 0062912 | |
2017-01-23 16:03 |
|
Assigned To | msv => abv |
2017-01-23 16:03 |
|
Status | assigned => resolved |
2017-01-26 12:48 |
|
Note Added: 0063078 | |
2017-01-26 12:48 |
|
Assigned To | abv => msv |
2017-01-26 12:48 |
|
Status | resolved => assigned |
2017-01-26 12:55 |
|
Note Added: 0063081 | |
2017-01-26 13:11 | git | Note Added: 0063083 | |
2017-01-26 13:12 |
|
Note Added: 0063085 | |
2017-01-26 13:12 |
|
Assigned To | msv => abv |
2017-01-26 13:12 |
|
Status | assigned => resolved |
2017-01-26 15:34 |
|
Note Added: 0063090 | |
2017-01-26 15:34 |
|
Assigned To | abv => bugmaster |
2017-01-26 15:34 |
|
Status | resolved => reviewed |
2017-01-26 17:25 |
|
Assigned To | bugmaster => apv |
2017-01-26 17:50 | git | Note Added: 0063103 | |
2017-01-26 17:51 |
|
Note Added: 0063104 | |
2017-01-27 14:27 |
|
Test case number | => Not needed |
2017-01-27 14:56 |
|
Note Added: 0063119 | |
2017-01-27 14:56 |
|
Assigned To | apv => bugmaster |
2017-01-27 14:56 |
|
Status | reviewed => tested |
2017-02-03 16:52 | apn | Changeset attached | => occt master 472634fa |
2017-02-03 16:52 | apn | Assigned To | bugmaster => apn |
2017-02-03 16:52 | apn | Status | tested => verified |
2017-02-03 16:52 | apn | Resolution | open => fixed |
2017-02-08 11:36 | git | Note Added: 0063605 | |
2017-02-08 11:36 | git | Note Added: 0063606 | |
2017-03-03 17:41 | bugmaster | Target Version | 7.3.0 => 7.2.0 |
2017-03-06 11:52 | bugmaster | Target Version | 7.2.0 => 7.3.0 |
2017-05-19 15:36 |
|
Target Version | 7.3.0 => 7.2.0 |
2017-09-29 16:18 |
|
Fixed in Version | => 7.2.0 |
2017-09-29 16:25 |
|
Status | verified => closed |