View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0028263Open CASCADEOCCT:Codingpublic2016-12-22 12:472017-09-29 16:31
Reporterkgv Assigned Toapv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version7.1.0 
Target Version7.2.0Fixed in Version7.2.0 
Summary0028263: Coding Rules - clean up definition of the class Graphic3d_MaterialAspect
DescriptionGraphic3d_MaterialAspect has interface issues, the following methods operate with raw string Standard_CString, while class is holding TCollection_AsciiString:
  //! Returns the name of this material
  Standard_EXPORT Standard_CString MaterialName() const;


Other issues:
- Class properties are sorted in sub-optimal order (from memory layout point of view).
- It will be more optimal if most trivial methods (getters) will provide inline implementation in class header.
- myRequestedMaterialName property is not-accessible outside.
- Method ::IsEqual() is currently broken (should be fixed by patch for NCollection_Vec3 in #28180).
TagsNo tags attached.
Test case numberNot needed

Activities

git

2016-12-29 20:39

administrator   ~0062335

Branch CR28263 has been created by kgv.

SHA-1: 643a707a77f0365a165c52ea5a5d8ee014e72ef5


Detailed log of new commits:

Author: kgv
Date: Thu Dec 29 20:39:28 2016 +0300

    0028263: Coding Rules - clean up definition of the class Graphic3d_MaterialAspect
    
    Fixed uninitialized fields in several classes.
    Body of trivial methods have been moved to class definition (header file).
    Ensure that non-primitive types are returned by reference, when possible.

git

2016-12-29 23:02

administrator   ~0062341

Branch CR28263 has been updated forcibly by kgv.

SHA-1: 67b67a587aab2e22de41dd17291f8c6cc694fb91

kgv

2016-12-29 23:03

developer   ~0062342

Patch is ready for review.

git

2016-12-29 23:36

administrator   ~0062346

Branch CR28263 has been updated forcibly by kgv.

SHA-1: 36a8bfa1a507dfcf2ee322289240070963111337

san

2017-01-16 20:55

developer   ~0062660

Branch CR28263 reviewed without remarks, ready for testing.

git

2017-01-17 16:15

administrator   ~0062705

Branch CR28263 has been updated forcibly by apv.

SHA-1: 49ad90f4c8ccf36de03a7cbbd03f804a78ea5394

apv

2017-01-17 16:15

tester   ~0062706

Branch CR28263 has been rebased on the current master

apv

2017-01-18 10:43

tester   ~0062730

Dear BugMaster,

During building of branch CR28263 (SHA-1: 49ad90f4c8ccf36de03a7cbbd03f804a78ea5394) from occt git-repository (and master from products git-repository) compilation errors have been detected.
On Linux:
http://jenkins-test-05.nnov.opencascade.com/view/CR28263-master/job/CR28263-master-OCCT-Debian70-64-opt-compile/1/parsed_console/
On Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28263-master/job/CR28263-master-OCCT-Windows-64-VC10-opt-compile/1/parsed_console/
On MacOS:
http://jenkins-test-05.nnov.opencascade.com/view/CR28263-master/job/CR28263-master-OCCT-MacOS-opt-compile/1/parsed_console/

apv

2017-01-18 10:45

tester   ~0062731

Dear Kirill,

Branch CR28263 has been rejected due to:
- compilation errors

git

2017-01-18 11:15

administrator   ~0062737

Branch CR28263 has been updated forcibly by kgv.

SHA-1: 1fd2617fb6d5eaa0e02596b086972c5374a28702

kgv

2017-01-18 11:16

developer   ~0062738

Please check updated patch with fixed misprint.

git

2017-01-20 17:44

administrator   ~0062853

Branch CR28263 has been updated forcibly by apv.

SHA-1: 4e1bc39a81fc965d86aae06555a7c4a50bbf4eea

apv

2017-01-20 17:45

tester   ~0062854

Branch CR28263 has been rebased on the current master

apv

2017-01-24 12:09

tester   ~0062933

Dear BugMaster,

Branch CR28263 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 4e1bc39a81fc965d86aae06555a7c4a50bbf4eea

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1151

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 93105166 / 92063498 [+1.13%]
Total CPU difference: 21056.440000000253 / 21062.120000000155 [-0.03%]

Testing on Windows:
Total MEMORY difference: 58325545 / 58324216 [+0.00%]
Total CPU difference: 19347.24401999861 / 19152.585972198493 [+1.02%]

git

2017-02-08 11:36

administrator   ~0063600

Branch CR28263 has been deleted by kgv.

SHA-1: 4e1bc39a81fc965d86aae06555a7c4a50bbf4eea

Related Changesets

occt: master 4e1bc39a

2016-12-29 17:39:28

kgv


Committer: apv Details Diff		 0028263: Coding Rules - clean up definition of the class Graphic3d_MaterialAspect

Fixed uninitialized fields in several classes.
Body of trivial methods have been moved to class definition (header file).
Ensure that non-primitive types are returned by reference, when possible.
Removed unused class Prs3d_PlaneSet.		 Affected Issues
0028263
mod - src/AIS/AIS_InteractiveObject.cxx Diff File
mod - src/AIS/AIS_Plane.cxx Diff File
mod - src/AIS/AIS_PointCloud.cxx Diff File
mod - src/AIS/AIS_Shape.cxx Diff File
mod - src/Graphic3d/Graphic3d_AspectFillArea3d.hxx Diff File
mod - src/Graphic3d/Graphic3d_MaterialAspect.cxx Diff File
mod - src/Graphic3d/Graphic3d_MaterialAspect.hxx Diff File
mod - src/Graphic3d/Graphic3d_TypeOfReflection.hxx Diff File
mod - src/OpenGl/OpenGl_AspectFace.cxx Diff File
mod - src/OpenGl/OpenGl_Context.cxx Diff File
mod - src/OpenGl/OpenGl_Workspace.cxx Diff File
mod - src/Prs3d/FILES Diff File
mod - src/Prs3d/Prs3d_ArrowAspect.cxx Diff File
mod - src/Prs3d/Prs3d_ArrowAspect.hxx Diff File
mod - src/Prs3d/Prs3d_BasicAspect.cxx Diff File
mod - src/Prs3d/Prs3d_BasicAspect.hxx Diff File
mod - src/Prs3d/Prs3d_DatumAspect.cxx Diff File
mod - src/Prs3d/Prs3d_DatumAspect.hxx Diff File
mod - src/Prs3d/Prs3d_DimensionAspect.cxx Diff File
mod - src/Prs3d/Prs3d_DimensionAspect.hxx Diff File
rm - src/Prs3d/Prs3d_DimensionUnits.cxx Diff File
mod - src/Prs3d/Prs3d_DimensionUnits.hxx Diff File
mod - src/Prs3d/Prs3d_IsoAspect.cxx Diff File
mod - src/Prs3d/Prs3d_IsoAspect.hxx Diff File
mod - src/Prs3d/Prs3d_LineAspect.cxx Diff File
mod - src/Prs3d/Prs3d_LineAspect.hxx Diff File
mod - src/Prs3d/Prs3d_PlaneAspect.cxx Diff File
mod - src/Prs3d/Prs3d_PlaneAspect.hxx Diff File
rm - src/Prs3d/Prs3d_PlaneSet.cxx Diff File
rm - src/Prs3d/Prs3d_PlaneSet.hxx Diff File
mod - src/Prs3d/Prs3d_PointAspect.cxx Diff File
mod - src/Prs3d/Prs3d_PointAspect.hxx Diff File
mod - src/Prs3d/Prs3d_ShadingAspect.cxx Diff File
mod - src/Prs3d/Prs3d_ShadingAspect.hxx Diff File
mod - src/Prs3d/Prs3d_TextAspect.cxx Diff File
mod - src/Prs3d/Prs3d_TextAspect.hxx Diff File
mod - src/QABugs/QABugs_17.cxx Diff File
mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx Diff File
mod - src/XSDRAWSTLVRML/XSDRAWSTLVRML.cxx Diff File

Issue History

Date Modified Username Field Change
2016-12-22 12:47 kgv New Issue
2016-12-22 12:47 kgv Assigned To => kgv
2016-12-29 20:39 git Note Added: 0062335
2016-12-29 23:02 git Note Added: 0062341
2016-12-29 23:03 kgv Note Added: 0062342
2016-12-29 23:03 kgv Assigned To kgv => san
2016-12-29 23:03 kgv Status new => resolved
2016-12-29 23:36 git Note Added: 0062346
2017-01-16 20:55 san Note Added: 0062660
2017-01-16 20:55 san Assigned To san => bugmaster
2017-01-16 20:55 san Status resolved => reviewed
2017-01-17 16:07 apv Assigned To bugmaster => apv
2017-01-17 16:15 git Note Added: 0062705
2017-01-17 16:15 apv Note Added: 0062706
2017-01-17 16:16 apv Test case number => Not needed
2017-01-18 10:43 apv Note Added: 0062730
2017-01-18 10:43 apv Assigned To apv => kgv
2017-01-18 10:43 apv Status reviewed => assigned
2017-01-18 10:45 apv Note Added: 0062731
2017-01-18 11:15 git Note Added: 0062737
2017-01-18 11:16 kgv Note Added: 0062738
2017-01-18 11:16 kgv Assigned To kgv => bugmaster
2017-01-18 11:16 kgv Status assigned => resolved
2017-01-18 11:16 kgv Status resolved => reviewed
2017-01-18 16:57 apv Assigned To bugmaster => apv
2017-01-20 17:44 git Note Added: 0062853
2017-01-20 17:45 apv Note Added: 0062854
2017-01-24 12:09 apv Note Added: 0062933
2017-01-24 12:09 apv Assigned To apv => bugmaster
2017-01-24 12:09 apv Status reviewed => tested
2017-01-27 16:15 apv Changeset attached => occt master 4e1bc39a
2017-01-27 16:15 apv Assigned To bugmaster => apv
2017-01-27 16:15 apv Status tested => verified
2017-01-27 16:15 apv Resolution open => fixed
2017-02-08 11:36 git Note Added: 0063600
2017-09-29 16:21 aiv Fixed in Version => 7.2.0
2017-09-29 16:31 aiv Status verified => closed