View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0028126 | Open CASCADE | OCCT:Visualization | public | 2016-11-18 11:06 | 2017-09-29 16:31 |
| Reporter | Assigned To | apn | |||
| Priority | normal | Severity | feature | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.2.0 | Fixed in Version | 7.2.0 | ||
| Summary | 0028126: Visualization, Path tracing - Provide ability to use two-sided scattering models | ||||
| Description | By default, all non-transmissive scattering models (BSDF) in OCCT are one-sided (they absorb all light that is received on the interior-facing side of any associated surfaces). Holes and visible back-facing parts are thus exposed as black regions. While usually it is a preferred mode (since it will reveal modeling issues early on), sometimes it is necessary to deal with improperly closed geometry (e.g. shell or imported 3D meshes), where the one-sided behavior is bothersome. It is proposed to to provide ability to switch from one-sided scattering models into their two-sided versions. | ||||
| Steps To Reproduce | vrenderparams -twoside [on|off] Also, please see test case: v3d raytrace sample_cube_twosided | ||||
| Additional information and documentation updates | New rendering parameter was added into Graphic3d_RenderingParams structure: Standard_Boolean TwoSidedBsdfModels; //!< forces path tracing to use two-sided versions of original one-sided scattering models By default, it is disabled (Standard_False). This parameter can be also controled via vrenderparams DRAW command: vrenderparams -twoside [on|off] | ||||
| Tags | No tags attached. | ||||
| Test case number | v3d raytrace sample_cube_twosided | ||||
|
|
New test case was added: v3d raytrace sample_cube_twosided See images attached for the reference result. |
|
2016-11-18 11:07 developer |
sample_cube_twosided_onesided.png (97,712 bytes) |
|
2016-11-18 11:07 developer |
sample_cube_twosided_twosided.png (140,916 bytes) |
|
|
Branch CR28126 has been created by dbp. SHA-1: 3277cf927db0fc5b055e571facfc80414d0e1a92 Detailed log of new commits: Author: dbp Date: Fri Nov 18 11:13:29 2016 +0300 0028126: Visualization, Path tracing - Provide ability to use two-sided scattering models |
|
|
Dear kgv, Could you please review the patch in branch CR28126? |
|
|
Please add test case for new option. |
|
|
Dear kgv, The test case is already presented. Please check v3d raytrace sample_cube_twosided |
|
|
Branch CR28126_1 has been created by dbp. SHA-1: 1da0a01dc4398c387856ce9d1ff4195b7ba67878 Detailed log of new commits: Author: dbp Date: Fri Nov 18 11:13:29 2016 +0300 0028126: Visualization, Path tracing - Provide ability to use two-sided scattering models |
|
|
Dear kgv, Please review the patch in branch CR28126_1. |
|
|
Please test the patch and check that generated resource files (src/Shaders/Shaders_PathtraceBase_fs.pxx) are up-to-date before integration. |
|
|
Dear BugMaster, Branch CR28126_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: 1da0a01dc4398c387856ce9d1ff4195b7ba67878 Number of compiler warnings: occt component : Linux: 0 (0 on master) Windows: 0 (0 on master) MacOS : 0 (0 on master) products component : Linux: 63 (63 on master) Windows: 0 (0 on master) MacOS : 1135 Regressions/Differences/Improvements: No regressions/differences Testing cases: http://occt-tests/CR28126_1-master-OCCT/Debian70-64/v3d/raytrace/sample_cube_twosided.html http://occt-tests/CR28126_1-master-OCCT/Windows-64-VC10/v3d/raytrace/sample_cube_twosided.html v3d raytrace sample_cube_twosided: OK Testing on Linux: occt component : Total MEMORY difference: 91682492 / 91448949 [+0.26%] Total CPU difference: 21926.34000000026 / 21816.830000000187 [+0.50%] products component : Total MEMORY difference: 29967870 / 29990998 [-0.08%] Total CPU difference: 5309.239999999975 / 5317.709999999961 [-0.16%] Testing on Windows: occt component : Total MEMORY difference: 56941296 / 56948258 [-0.01%] Total CPU difference: 20342.920402498537 / 20501.8074209986 [-0.77%] products component : Total MEMORY difference: 20842013 / 20808844 [+0.16%] Total CPU difference: 5271.398590799977 / 5254.222880699978 [+0.33%] There are no differences in images found by testdiff. |
|
|
Dear BugMaster, Branch CR28126_1 is TESTED. |
|
|
Branch CR28126 has been deleted by kgv. SHA-1: 3277cf927db0fc5b055e571facfc80414d0e1a92 |
|
|
Branch CR28126_1 has been deleted by kgv. SHA-1: 1da0a01dc4398c387856ce9d1ff4195b7ba67878 |
|
occt: master b4327ba8 2016-11-18 08:13:29
Committer: apn Details Diff |
0028126: Visualization, Path tracing - Provide ability to use two-sided scattering models |
Affected Issues 0028126 |
|
| mod - src/Graphic3d/Graphic3d_RenderingParams.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_View.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_View_Raytrace.cxx | Diff File | ||
| mod - src/Shaders/PathtraceBase.fs | Diff File | ||
| mod - src/Shaders/Shaders_PathtraceBase_fs.pxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
| add - tests/v3d/raytrace/sample_cube_twosided | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-11-18 11:06 |
|
New Issue | |
| 2016-11-18 11:06 |
|
Assigned To | => dbp |
| 2016-11-18 11:07 |
|
Note Added: 0060513 | |
| 2016-11-18 11:07 |
|
File Added: sample_cube_twosided_onesided.png | |
| 2016-11-18 11:07 |
|
File Added: sample_cube_twosided_twosided.png | |
| 2016-11-18 11:09 |
|
Additional Information Updated | |
| 2016-11-18 11:13 | git | Note Added: 0060514 | |
| 2016-11-18 11:14 |
|
Note Added: 0060516 | |
| 2016-11-18 11:14 |
|
Assigned To | dbp => kgv |
| 2016-11-18 11:14 |
|
Status | new => resolved |
| 2016-11-18 11:14 |
|
Steps to Reproduce Updated | |
| 2016-11-27 12:23 | kgv | Note Added: 0060787 | |
| 2016-11-27 12:23 | kgv | Assigned To | kgv => dbp |
| 2016-11-27 12:23 | kgv | Severity | minor => feature |
| 2016-11-27 12:23 | kgv | Status | resolved => assigned |
| 2016-11-28 10:06 |
|
Note Added: 0060792 | |
| 2016-11-28 10:06 |
|
Assigned To | dbp => kgv |
| 2016-11-28 10:06 |
|
Status | assigned => resolved |
| 2016-11-28 15:24 | kgv | Assigned To | kgv => dbp |
| 2016-11-28 15:24 | kgv | Status | resolved => assigned |
| 2016-11-30 11:12 | git | Note Added: 0060889 | |
| 2016-11-30 11:12 |
|
Note Added: 0060890 | |
| 2016-11-30 11:13 |
|
Assigned To | dbp => kgv |
| 2016-11-30 11:13 |
|
Status | assigned => resolved |
| 2016-11-30 11:25 | kgv | Note Added: 0060891 | |
| 2016-11-30 11:25 | kgv | Assigned To | kgv => bugmaster |
| 2016-11-30 11:25 | kgv | Status | resolved => reviewed |
| 2016-11-30 12:11 |
|
Assigned To | bugmaster => mkv |
| 2016-12-01 19:13 |
|
Note Added: 0060995 | |
| 2016-12-01 19:14 |
|
Note Added: 0060996 | |
| 2016-12-01 19:14 |
|
Assigned To | mkv => bugmaster |
| 2016-12-01 19:14 |
|
Status | reviewed => tested |
| 2016-12-01 19:14 |
|
Test case number | => v3d raytrace sample_cube_twosided |
| 2016-12-09 16:46 | apn | Changeset attached | => occt master b4327ba8 |
| 2016-12-09 16:46 | apn | Assigned To | bugmaster => apn |
| 2016-12-09 16:46 | apn | Status | tested => verified |
| 2016-12-09 16:46 | apn | Resolution | open => fixed |
| 2016-12-18 10:53 | git | Note Added: 0061793 | |
| 2016-12-18 10:53 | git | Note Added: 0061794 | |
| 2016-12-18 21:59 | kgv | Relationship added | parent of 0028241 |
| 2017-09-29 16:21 |
|
Fixed in Version | => 7.2.0 |
| 2017-09-29 16:31 |
|
Status | verified => closed |
