MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0028104Open CASCADE[OCCT] OCCT:Data Exchangepublic2016-11-14 18:452021-10-18 14:03
Reporterakz 
Assigned Todpasukhi 
PrioritynormalSeverityfeature 
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.7.0Fixed in Version 
Summary0028104: Data Exchange - Extract sub-assembly (XDE)
DescriptionExtraction of specified parts from XDE assembly with attached colors, layers and materials to a new document (or possibly into the specified place of another existing document).

A proposed place for a new functionality is XCAFDoc_Editor.
Steps To Reproducetest bugs xde bug28104
TagsNo tags attached.
Test case number
Attached Files

- Relationships

-  Notes
(0060321)
ssv (developer)
2016-11-14 18:49

One addendum: this does not include PMI (to be treated in a separate issue).
(0060606)
git (administrator)
2016-11-21 12:18

Branch CR28104 has been created by akz.

SHA-1: bd34f77a0ad2f6ce4486c2734d82756f3df8f477


Detailed log of new commits:

Author: akz
Date: Mon Nov 21 12:18:08 2016 +0300

    0028104: Extract sub-assembly (XDE). Added new functionality to XCAFDoc_Editor that extracts labels and put them as components of the specified label
(0104383)
dpasukhi (developer)
2021-09-26 23:50

Analyzing & Solution elaboration
(0104411)
git (administrator)
2021-09-28 03:43

Branch CR28104_1 has been created by dpasukhi.

SHA-1: 2590309104e6bf2b49b8c980029d5982e0b6da99


Detailed log of new commits:

Author: dpasukhu
Date: Mon Nov 21 12:18:08 2016 +0300

    0028104: Data Exchange - Extract sub-assembly (XDE)
    
    - Added getting and setting Material to XCAFDoc_Editor::Expand.
    - Added XCAFDoc_Editor::Extract to transfer part to a new location.
    XCAFDoc_Extract allows to extract a part as a component or simply extract to an empty label with attached colors, layers and materials
(0104460)
git (administrator)
2021-10-01 05:11

Branch CR28104_2 has been created by dpasukhi.

SHA-1: 8fa59e84c6729c71dab652f7f2caf6468b341bb5


Detailed log of new commits:

Author: dpasukhu
Date: Mon Nov 21 12:18:08 2016 +0300

    0028104: Data Exchange - Extract sub-assembly (XDE)
    
    - Added getting and setting Material to XCAFDoc_Editor::Expand.
    - Added XCAFDoc_Editor::Extract to transfer part to a new location.
    XCAFDoc_Extract allows to extract a part as a component or simply extract to an empty label with attached colors, layers and materials
(0104491)
git (administrator)
2021-10-02 18:11

Branch CR28104_3 has been created by dpasukhi.

SHA-1: 5f3d6793d860cb08879fd9eaf20a52698a4002b4


Detailed log of new commits:

Author: dpasukhu
Date: Mon Nov 21 12:18:08 2016 +0300

    0028104: Data Exchange - Extract sub-assembly (XDE)
    
    - Added getting and setting Material, VisMaterial and Props to XCAFDoc_Editor::Expand.
    - Added XCAFDoc_Editor::Extract to transfer part to a new location.
    XCAFDoc_Extract allows to extract a part as a component or simply extract to an empty label with attached colors, layers, materials, vismaterials and props
(0104492)
git (administrator)
2021-10-02 18:19

Branch CR28104_3 has been updated forcibly by dpasukhi.

SHA-1: bbc87381abea2b502c3f54bc663eae668926c12d
(0104579)
git (administrator)
2021-10-10 16:00

Branch CR28104_4 has been created by dpasukhi.

SHA-1: 527d8c97a87bce4047e8b7ac0837c372759f8150


Detailed log of new commits:

Author: dpasukhu
Date: Mon Nov 21 12:18:08 2016 +0300

    0028104: Data Exchange - Extract sub-assembly (XDE)
    
    - Added getting and setting Material, VisMaterial and Props to XCAFDoc_Editor::Expand.
    - Added XCAFDoc_Editor::Extract to transfer part to a new location.
    XCAFDoc_Extract allows to extract a part as a component or simply extract to an empty label with attached colors, layers, materials, vismaterials and props
(0104583)
git (administrator)
2021-10-11 11:48

Branch CR28104_4 has been updated forcibly by dpasukhi.

SHA-1: 901df8c9dd1048f2644c8f55d32ae202ca3af13b
(0104584)
dpasukhi (developer)
2021-10-11 11:52

Dear IKA,
Please review:
OCCT: CR28104_4
PROD: NO

Added a new draw command "XExtract dstDoc [dstAssmblSh] srcDoc srcLabel1 srcLabel2 ...". You can test it with any XDE document.

All tests are OK, see:
http://jenkins-test-occt.nnov.opencascade.com/view/CR28104-master-dpasukhi/view/COMPARE/ [^]
(0104588)
ika (developer)
2021-10-11 14:13

Dear dpasukhi,

I have several remarks:

XCAFDoc_Editor.hxx

1) + //! or creates new shape label if theDstLabel is Doc
I can guess what you meant, but it is not very clear from the description how label can be a document? Also you do not check isn't a label a color label, for example, it will work at the same way as the main document label.

2) Standard_EXPORT static TDF_Label CloneShapeLebel - a misprint

3) getParams/setParams
As for me, it will be more readable and useful to make a simple method like copyMetaData(theFromLabel, theNewLabel, TheSomeFlags) and update its body after adding a new metadata type, not the parameters list. Such method also can be used as a public for some reasons.

XCAFDoc_Editor.cxx

4) aDstShapeTool->SetAutoNaming(Standard_False);
Why do you switch off autonaming? If I am not mistaken, all the named shapes will get necessary names during parameters coping, but additional processing of unnamed can be removed from setParams() with the swithed on autonaming.

5) If you do not agree with (3) some remarks about getParams:

aColorTool->GetColor(theLabel, aTypes[anInd], aColor);
And what if there is no such type of color? You will add a default one? Because False result is not processed.

for (TDF_AttributeIterator anAttIter(theLabel); anAttIter.More(); anAttIter.Next())
According to my experience, also Location and ShapeMap shouldn't be copied.

- Issue History
Date Modified Username Field Change
2016-11-14 18:45 akz New Issue
2016-11-14 18:45 akz Assigned To => akz
2016-11-14 18:49 ssv Note Added: 0060321
2016-11-14 18:53 akz Status new => assigned
2016-11-21 12:18 git Note Added: 0060606
2017-07-27 10:38 abv Target Version 7.2.0 => 7.4.0
2019-09-04 12:58 abv Target Version 7.4.0 => 7.5.0
2020-09-17 20:26 gka Assigned To akz =>
2020-09-17 20:26 gka Target Version 7.5.0 => 7.6.0*
2021-02-09 15:20 asuraven Assigned To => asuraven
2021-02-09 15:26 kgv Summary Extract sub-assembly (XDE) => Data Exchange - Extract sub-assembly (XDE)
2021-08-31 10:26 szy Assigned To asuraven => dpasukhi
2021-08-31 14:28 gka Target Version 7.6.0* => 7.7.0
2021-09-26 23:50 dpasukhi Note Added: 0104383
2021-09-28 03:43 git Note Added: 0104411
2021-10-01 05:11 git Note Added: 0104460
2021-10-02 18:11 git Note Added: 0104491
2021-10-02 18:19 git Note Added: 0104492
2021-10-10 16:00 git Note Added: 0104579
2021-10-11 11:48 git Note Added: 0104583
2021-10-11 11:52 dpasukhi Note Added: 0104584
2021-10-11 11:52 dpasukhi Assigned To dpasukhi => ika
2021-10-11 11:52 dpasukhi Status assigned => resolved
2021-10-11 11:52 dpasukhi Steps to Reproduce Updated View Revisions
2021-10-11 14:13 ika Note Added: 0104588
2021-10-11 14:14 ika Assigned To ika => dpasukhi
2021-10-11 14:14 ika Status resolved => assigned
2021-10-18 14:03 kgv Relationship added child of 0030271


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker