View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0027863 | Community | OCCT:Modeling Data | public | 2016-09-12 12:16 | 2016-12-09 16:38 |
| Reporter | drazmyslovich | Assigned To | bugmaster | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | Windows | OS | VC++ 2010 | ||
| Product Version | 7.0.0 | ||||
| Target Version | 7.1.0 | Fixed in Version | 7.1.0 | ||
| Summary | 0027863: Geom_BSplineSurface::SetVKnot(const Standard_Integer, const Standard_Real) has no effect | ||||
| Description | The function Geom_BSplineSurface::SetVKnot has no effect and has asymmetric implementation to the Geom_BSplineSurface::SetUKnot function. | ||||
| Steps To Reproduce | Not applicable | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Branch CR27863 has been created by drazmyslovich. SHA-1: d6ffbf7f916c19aafac75194da95c8fee34ccfc5 Detailed log of new commits: Author: razmyslovich Date: Mon Sep 12 11:17:48 2016 +0200 0027863: Fix Geom_BSplineSurface::SetVKnot function |
|
|
The changes are committed, please, review. |
|
|
Dear drazmyslovich, do you have a use case that allows to reproduce incorrect behavior? |
|
|
Branch CR27863_1 has been created by msv. SHA-1: baf0573339f7ba789397144f36dc500a5db3ba0b Detailed log of new commits: Author: razmyslovich Date: Mon Sep 12 11:17:48 2016 +0200 0027863: Geom_BSplineSurface::SetVKnot(const Standard_Integer, const Standard_Real) has no effect Fix Geom_BSplineSurface::SetVKnot function to have the same behavior as SetUKnot. |
|
|
The new branch CR27863_1 has been created taking into account requirements to the OCCT patch. |
|
|
Reviewed. |
|
|
Dear msv, I don't have any special use case for it. In our code base we are just trying to edit the bspline surfaces, particularly, changing v and u knots. Changing of U knots works fine, while changing of V knots has no effect with no matter what bspline surface, what index and what parameter do we use. As it can be seen in the source code, the parameter is actually unused. |
|
|
OK, the patch will go without a test case. |
|
|
Dear BugMaster, Branch CR27863_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: baf0573339f7ba789397144f36dc500a5db3ba0b Number of compiler warnings: occt component : Linux: 0 (0 on master) Windows: 0 (0 on master) MacOS : 0 (0 on master) products component : Linux: 64 (64 on master) Windows: 0 (0 on master) MacOS : 1141 Regressions/Differences/Improvements: No regressions/differences Testing cases: Not needed Testing on Linux: occt component : Total MEMORY difference: 90273515 / 90412639 [-0.15%] Total CPU difference: 19262.669999999875 / 19445.620000000134 [-0.94%] products component : Total MEMORY difference: 30051906 / 29998667 [+0.18%] Total CPU difference: 5050.219999999977 / 5044.539999999978 [+0.11%] Testing on Windows: occt component : Total MEMORY difference: 57168523 / 57172575 [-0.01%] Total CPU difference: 18405.37238239873 / 18100.047225198865 [+1.69%] products component : Total MEMORY difference: 21261724 / 21225414 [+0.17%] Total CPU difference: 4954.076956699952 / 4888.104133799955 [+1.35%] There are no differences in images found by testdiff. |
|
|
Dear BugMaster, Branch CR27863_1 is TESTED. |
|
|
Branch CR27863 has been deleted by kgv. SHA-1: d6ffbf7f916c19aafac75194da95c8fee34ccfc5 |
|
|
Branch CR27863_1 has been deleted by kgv. SHA-1: baf0573339f7ba789397144f36dc500a5db3ba0b |
|
occt: master a165f002 2016-09-12 09:17:48 razmyslovich Committer: bugmaster Details Diff |
0027863: Geom_BSplineSurface::SetVKnot(const Standard_Integer, const Standard_Real) has no effect Fix Geom_BSplineSurface::SetVKnot function to have the same behavior as SetUKnot. |
Affected Issues 0027863 |
|
| mod - src/Geom/Geom_BSplineSurface.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-09-12 12:16 | drazmyslovich | New Issue | |
| 2016-09-12 12:16 | drazmyslovich | Assigned To | => drazmyslovich |
| 2016-09-12 12:19 | git | Note Added: 0057673 | |
| 2016-09-12 12:20 | drazmyslovich | Note Added: 0057674 | |
| 2016-09-12 12:20 | drazmyslovich | Assigned To | drazmyslovich => msv |
| 2016-09-12 12:20 | drazmyslovich | Status | new => resolved |
| 2016-09-12 12:20 | drazmyslovich | Steps to Reproduce Updated | |
| 2016-09-12 13:00 |
|
Note Added: 0057675 | |
| 2016-09-12 13:12 | git | Note Added: 0057676 | |
| 2016-09-12 13:14 |
|
Note Added: 0057677 | |
| 2016-09-12 13:14 |
|
Note Added: 0057678 | |
| 2016-09-12 13:14 |
|
Assigned To | msv => bugmaster |
| 2016-09-12 13:14 |
|
Status | resolved => reviewed |
| 2016-09-12 13:16 |
|
Assigned To | bugmaster => mkv |
| 2016-09-12 13:17 | drazmyslovich | Note Added: 0057679 | |
| 2016-09-12 14:44 |
|
Note Added: 0057686 | |
| 2016-09-13 11:45 |
|
Note Added: 0057727 | |
| 2016-09-13 11:45 |
|
Note Added: 0057728 | |
| 2016-09-13 11:45 |
|
Assigned To | mkv => bugmaster |
| 2016-09-13 11:45 |
|
Status | reviewed => tested |
| 2016-09-13 11:45 |
|
Test case number | => Not needed |
| 2016-09-16 09:43 | bugmaster | Changeset attached | => occt master a165f002 |
| 2016-09-16 09:43 | bugmaster | Status | tested => verified |
| 2016-09-16 09:43 | bugmaster | Resolution | open => fixed |
| 2016-10-28 21:45 | git | Note Added: 0059516 | |
| 2016-10-28 21:45 | git | Note Added: 0059517 | |
| 2016-12-09 16:30 |
|
Status | verified => closed |
| 2016-12-09 16:38 |
|
Fixed in Version | => 7.1.0 |
