View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0027638 | Open CASCADE | OCCT:Tests | public | 2016-06-24 16:28 | 2016-12-09 16:38 |
| Reporter | bugmaster | Assigned To | bugmaster | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.1.0 | Fixed in Version | 7.1.0 | ||
| Summary | 0027638: Optimisation of testdiff command | ||||
| Description | Preamble: testdiff command executed during 25-30 minutes. Images, memory and cup is compared with reference data simultaneously. It is suggested to add additional option to this command -images - only images are compared -memory - only memory are compared -cpu - only cpu is compared. It will allow : 1. Launch process of comparison in parallel (decreasing time of execution) 2. Tests are launched in parallel , one per processor core (usually 4). It caused incorrect deviation of CPU time. It is suggested to distinguish cpu comparison in separate process with following restart test cases with critical increasing of cpu time in one stream with re-comparison new result. Thus we could report more objective results of cpu increasing. | ||||
| Steps To Reproduce | testdiff dir1 dir2 -image -cpu -memory | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Dear ABV What do you think about this idea? |
|
|
Branch CR27638 has been created by apn. SHA-1: 09bb5143bf7c0e15fccc44140ad35253caa45eb4 Detailed log of new commits: Author: apn Date: Wed Jul 13 18:18:50 2016 +0300 0027638: Optimisation of testdiff command Added functionality to compare image, memory and CPU differences separately. |
|
|
Additional options (-image, -cpu, -memory) to launch only image, memory or CPU comparison were added. Each option saves result in specified file which can be determined by user (or has default value). Example: testdiff dir1 dir2 -image D:/branch/imagediff.log -cpu D:/branch/cpudiff.log -memory D:/branch/memorydiff.log If there're no any options (testdiff dir1 dir2) log and html files will be saved as usual in one file. |
|
|
Dear abv, please review CR27638. |
|
|
OK, please proceed. One general remark: in Tcl, instead of comparing logical variable with value "true" or "false", you can simply use this variable as condition. For instance, instead of if { $memory == false } {...} you can put if { ! $memory } {...} This is easier to comprehend and also will handle other variants of defining logical variable: true: "true", "t", or any non-zero integer or real false: "false", "f", or zero |
|
|
Branch CR27638 has been deleted by inv. SHA-1: 09bb5143bf7c0e15fccc44140ad35253caa45eb4 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-06-24 16:28 | bugmaster | New Issue | |
| 2016-06-24 16:28 | bugmaster | Assigned To | => abv |
| 2016-06-24 16:29 | bugmaster | Note Added: 0055452 | |
| 2016-06-24 16:29 | bugmaster | Status | new => feedback |
| 2016-07-12 10:37 | bugmaster | Assigned To | abv => apn |
| 2016-07-13 18:18 | git | Note Added: 0055889 | |
| 2016-07-13 18:24 | apn | Note Added: 0055890 | |
| 2016-07-13 18:25 | apn | Note Added: 0055891 | |
| 2016-07-13 18:27 | apn | Test case number | => Not needed |
| 2016-07-13 18:27 | apn | Assigned To | apn => abv |
| 2016-07-13 18:27 | apn | Status | feedback => resolved |
| 2016-07-13 18:27 | apn | Steps to Reproduce Updated | |
| 2016-07-14 07:23 |
|
Note Added: 0055900 | |
| 2016-07-14 07:23 |
|
Assigned To | abv => bugmaster |
| 2016-07-14 07:23 |
|
Status | resolved => reviewed |
| 2016-07-14 11:24 | bugmaster | Status | reviewed => tested |
| 2016-07-15 10:44 | bugmaster | Changeset attached | => occt master 28cab376 |
| 2016-07-15 10:44 | bugmaster | Status | tested => verified |
| 2016-07-15 10:44 | bugmaster | Resolution | open => fixed |
| 2016-07-22 10:44 | git | Note Added: 0056107 | |
| 2016-12-09 16:31 |
|
Status | verified => closed |
| 2016-12-09 16:38 |
|
Fixed in Version | => 7.1.0 |
