View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0027066Open CASCADEOCCT:Modeling Algorithmspublic2016-01-08 19:462016-04-20 15:51
ReporterabvAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version7.0.0Fixed in Version7.0.0 
Summary0027066: BRepFeat_MakeCylindricalHole::Perform() hides overloaded virtual function
DescriptionCLang compiler reports two warnings in BRepFeat_MakeCylindricalHole (see 0025076):

/home/abv/occt/src/BRepFeat/BRepFeat_MakeCylindricalHole.hxx:58:24: warning:
      'BRepFeat_MakeCylindricalHole::Perform' hides overloaded virtual function
      [-Woverloaded-virtual]
  Standard_EXPORT void Perform (const Standard_Real Radius);
                       ^
/home/abv/occt/src/BOPAlgo/BOPAlgo_BOP.hxx:62:32: note: hidden overloaded
      virtual function 'BOPAlgo_BOP::Perform' declared here: different number of
      parameters (0 vs 1)
  Standard_EXPORT virtual void Perform() Standard_OVERRIDE;
                               ^
/home/abv/occt/src/BRepFeat/BRepFeat_MakeCylindricalHole.hxx:65:24: warning:
      'BRepFeat_MakeCylindricalHole::Perform' hides overloaded virtual function
      [-Woverloaded-virtual]
  Standard_EXPORT void Perform (const Standard_Real Radius, const Standa...
                       ^
/home/abv/occt/src/BOPAlgo/BOPAlgo_BOP.hxx:62:32: note: hidden overloaded
      virtual function 'BOPAlgo_BOP::Perform' declared here: different number of
      parameters (0 vs 4)
  Standard_EXPORT virtual void Perform() Standard_OVERRIDE;

It is not clear whether hidden method should be redefined on this level. If it does not (which means inherited implementation is OK), we can just import it by "using" directive to silence the warning.
Steps To ReproducePerform() from BOPAlgo_BOP class is now visible on the level of BRepFeat_MakeCylindricalHole
TagsNo tags attached.
Test case numberNot needed

Relationships

child of 0025076 closedabv Community Hidden overloaded virtual functions 

Activities

msv

2016-01-09 00:56

developer   ~0049746

Dear Ilya, please take care of this bug, as it concerns the same class as the bug you are processing #26724.

git

2016-01-11 19:04

administrator   ~0049778

Branch CR27066 has been created by isn.

SHA-1: cd29932d6940da118b9fc59c832e46a2e97e559d


Detailed log of new commits:

Author: isn
Date: Mon Jan 11 18:32:41 2016 +0300

    0027066: BRepFeat_MakeCylindricalHole::Perform() hides overloaded virtual function

git

2016-01-12 11:45

administrator   ~0049780

Branch CR27066 has been updated forcibly by isn.

SHA-1: a912e85cd45b5814fb7af96097c31e1a1e7516bc

msv

2016-01-13 00:52

developer   ~0049807

Why did you put 'using' in public section? I think if there is possibility we should hide this declaration in protected section in order to prevent unintended use of this method.

git

2016-01-13 12:01

administrator   ~0049813

Branch CR27066 has been updated by isn.

SHA-1: 4e48109ccee4b4810c9339f1fb2de7a8d46fa573


Detailed log of new commits:

Author: isn
Date: Wed Jan 13 11:57:10 2016 +0300

    move to protected section

msv

2016-01-13 12:12

developer   ~0049816

Reviewed.

mkv

2016-01-14 13:39

tester   ~0049852

Dear BugMaster,
Branch CR27066 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 4e48109ccee4b4810c9339f1fb2de7a8d46fa573

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 136 (136 on master)

products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 89993586 / 89884726 [+0.12%]
Total CPU difference: 19232.340000000073 / 19263.900000000092 [-0.16%]
products component :
Total MEMORY difference: 25285547 / 25273773 [+0.05%]
Total CPU difference: 8447.780000000017 / 7373.110000000011 [+14.58%]

Testing on Windows:
occt component :
Total MEMORY difference: 57211257 / 57466619 [-0.44%]
Total CPU difference: 18227.82764429891 / 18535.477216399115 [-1.66%]
products component :
Total MEMORY difference: 16923491 / 17032519 [-0.64%]
Total CPU difference: 5931.579222699998 / 5812.004456199969 [+2.06%]

There are no differences in images found by testdiff.

mkv

2016-01-14 13:40

tester   ~0049853

Dear BugMaster,
Branch CR27066 is TESTED.

git

2016-04-17 14:14

administrator   ~0053113

Branch CR27066 has been deleted by kgv.

SHA-1: 4e48109ccee4b4810c9339f1fb2de7a8d46fa573

Related Changesets

occt: master 99ac7b2e

2016-01-11 15:32:41

isn


Committer: bugmaster Details Diff		 0027066: BRepFeat_MakeCylindricalHole::Perform() hides overloaded virtual function

Moving to protected section		 Affected Issues
0027066
mod - src/BRepFeat/BRepFeat_MakeCylindricalHole.hxx Diff File

Issue History

Date Modified Username Field Change
2016-01-08 19:46 abv New Issue
2016-01-08 19:46 abv Assigned To => msv
2016-01-08 19:46 abv Relationship added child of 0025076
2016-01-09 00:56 msv Note Added: 0049746
2016-01-09 00:56 msv Assigned To msv => isn
2016-01-09 00:56 msv Status new => assigned
2016-01-11 19:04 git Note Added: 0049778
2016-01-12 11:45 git Note Added: 0049780
2016-01-12 16:36 isn Assigned To isn => msv
2016-01-12 16:36 isn Status assigned => resolved
2016-01-12 16:36 isn Steps to Reproduce Updated
2016-01-13 00:52 msv Note Added: 0049807
2016-01-13 00:52 msv Assigned To msv => isn
2016-01-13 00:52 msv Status resolved => assigned
2016-01-13 12:01 git Note Added: 0049813
2016-01-13 12:05 isn Assigned To isn => msv
2016-01-13 12:05 isn Status assigned => resolved
2016-01-13 12:05 isn Steps to Reproduce Updated
2016-01-13 12:12 msv Note Added: 0049816
2016-01-13 12:12 msv Assigned To msv => bugmaster
2016-01-13 12:12 msv Status resolved => reviewed
2016-01-13 13:24 mkv Assigned To bugmaster => mkv
2016-01-14 13:39 mkv Note Added: 0049852
2016-01-14 13:40 mkv Note Added: 0049853
2016-01-14 13:40 mkv Assigned To mkv => bugmaster
2016-01-14 13:40 mkv Status reviewed => tested
2016-01-14 13:40 mkv Test case number => Not needed
2016-01-15 16:57 bugmaster Changeset attached => occt master 99ac7b2e
2016-01-15 16:57 bugmaster Status tested => verified
2016-01-15 16:57 bugmaster Resolution open => fixed
2016-01-22 12:28 bugmaster Target Version 7.1.0 => 7.0.0
2016-04-17 14:14 git Note Added: 0053113
2016-04-20 15:42 aiv Fixed in Version => 7.0.0
2016-04-20 15:51 aiv Status verified => closed