View Issue Details

IDProjectCategoryView StatusLast Update
0026990Open CASCADEOCCT:Codingpublic2016-04-20 15:50
Reporterabv Assigned Toabv  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version7.0.0Fixed in Version7.0.0 
Summary0026990: Compiler warnings in LDOM_OSStream.hxx
DescriptionICC generates two warnings in LDOM_OSStream.hxx:

LDOM_OSStream.hxx:88: function "std::basic_streambuf<_Elem, _Traits>::xsputn(const _Elem *, std::streamsize={_Longlong={__int64}}) [with _Elem=char, _Traits=std::char_traits]" is hidden by "LDOM_SBuffer::xsputn" -- virtual function override intended?

LDOM_OSStream.hxx:92: exception specification for virtual function "LDOM_SBuffer::~LDOM_SBuffer" is incompatible with that of overridden function "std::basic_streambuf<_Elem, _Traits>::~basic_streambuf [with _Elem=char, _Traits=std::char_traits]"

It seems that xputn does not really override inherited virtual function as it was obviously intended. Furthermore, the whole class LDOM_OSStream looks incomplete and it is not clear if its use makes sense at all.
Steps To ReproduceBuild with CLang or ICC
TagsNo tags attached.
Test case number

Relationships

related to 0025076 closedabv Community Hidden overloaded virtual functions 

Activities

git

2016-01-09 18:57

administrator   ~0049757

Branch CR26990 has been created by abv.

SHA-1: 2e02ea313ef1a1dcd93dbb8228f0d8373dde7f4a


Detailed log of new commits:

Author: abv
Date: Sat Jan 9 14:41:41 2016 +0300

    0026990: Compiler warnings in LDOM_OSStream.hxx
    
    Signature of methods xsputn() and overflow() of the class LDOM_SBuffer is corrected to correspond to signature of overriden virtual methods of std::streambuf.

abv

2016-01-09 19:04

manager   ~0049758

Fix pushed to branch CR26990, please review. Note that only the first ICC warning (the same as reported by CLang, see 0025076) is fixed; the second one is ICC-specific and I do not see how to address it correctly in platform-independent way.

git

2016-01-09 20:12

administrator   ~0049759

Branch CR26990 has been updated forcibly by abv.

SHA-1: 25d308cbf5cf577d237e2a5c27e0bd2de41774dd

kgv

2016-01-09 20:16

developer   ~0049761

Please test the patch.

git

2016-04-17 13:54

administrator   ~0053002

Branch CR26990 has been deleted by kgv.

SHA-1: 25d308cbf5cf577d237e2a5c27e0bd2de41774dd

Related Changesets

occt: master e071e038

2016-01-09 11:41:41

abv


Committer: abv Details Diff
0026990: Compiler warnings in LDOM_OSStream.hxx

Signature of methods xsputn() and overflow() of the class LDOM_SBuffer is corrected to correspond to signature of overriden virtual methods of std::streambuf.
Affected Issues
0026990
mod - src/LDOM/LDOM_OSStream.cxx Diff File
mod - src/LDOM/LDOM_OSStream.hxx Diff File

Issue History

Date Modified Username Field Change
2015-12-14 09:28 abv New Issue
2015-12-14 09:28 abv Assigned To => kgv
2016-01-08 10:18 abv Assigned To kgv => abv
2016-01-08 10:18 abv Status new => assigned
2016-01-09 14:41 abv Relationship added related to 0025076
2016-01-09 18:57 git Note Added: 0049757
2016-01-09 19:04 abv Note Added: 0049758
2016-01-09 19:05 abv Assigned To abv => kgv
2016-01-09 19:05 abv Status assigned => resolved
2016-01-09 19:05 abv Steps to Reproduce Updated
2016-01-09 20:12 git Note Added: 0049759
2016-01-09 20:16 kgv Note Added: 0049761
2016-01-09 20:16 kgv Assigned To kgv => bugmaster
2016-01-09 20:16 kgv Status resolved => reviewed
2016-01-15 16:57 abv Changeset attached => occt master e071e038
2016-01-15 16:57 abv Assigned To bugmaster => abv
2016-01-15 16:57 abv Status reviewed => verified
2016-01-15 16:57 abv Resolution open => fixed
2016-04-17 13:54 git Note Added: 0053002
2016-04-20 15:42 aiv Fixed in Version => 7.0.0
2016-04-20 15:50 aiv Status verified => closed