View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0026892Open CASCADEOCCT:Visualizationpublic2015-11-18 10:212016-04-20 15:50
ReporteriskAssigned Tobugmaster  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Target Version7.0.0Fixed in Version7.0.0 
Summary0026892: Visualization, TKOpenGl - support 3D textures within OpenGl_Texture
DescriptionCurrent implementation of OpenGl_Texture doesn't support 3-dimensional textures.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot needed

Activities

git

2015-11-20 14:00

administrator   ~0048413

Branch CR26892 has been created by isk.

SHA-1: 2765eac9ef1d1b89cb7f3ee6eeeb94acc7f5160f


Detailed log of new commits:

Author: isk
Date: Fri Nov 20 13:56:11 2015 +0300

    0026892: Visualization, TKOpenGl - support 3D textures within OpenGl_Texture

isk

2015-11-20 14:01

developer   ~0048414

Dear Kirill,
please review the branch CR26892.

kgv

2015-11-20 14:39

developer   ~0048422 

+  bool HasFloatingPointTexture()
+  {
+    return (IsGlGreaterEqual (3, 0) || CheckExtension ("GL_ARB_texture_float"));
+  }

this check is expected to be done once in ::init(), e.g. cached in class field as other similar checks.

+#if defined(GL_ES_3_0)
+  inline void glTexImage3D (GLenum target, GLint level, GLint internalFormat, GLsizei width, GLsizei height, GLsizei depth, GLint border, GLenum format, GLenum type, const GLvoid* data)
+  {
+    ::glTexImage3D (target, level, internalFormat, width, height, depth, border, format, type, data);
+  }
+#endif

this is wrong way for extending functionality - please define a prototype, function pointer and retrieve it dynamically within ::init().

+#if !defined(GL_ES_VERSION_2_0) || defined(GL_ES_VERSION_3_0)

these checks should be removed.

+  theCtx->core15fwd->glTexImage3D (GL_PROXY_TEXTURE_3D,
...
+  glGetTexLevelParameteriv (GL_PROXY_TEXTURE_3D, 0, GL_TEXTURE_WIDTH, &aTestSizeX);

it doesn't look like this code has been checked for compilation within OpenGL ES - there no proxy textures available even within OpenGL ES 3.2.
And glTexImage3D() will not be within core15fwd as well.

+  GLsizei          mySizeZ;      //!< texture depth

new field is not initialized within constructor.

git

2015-11-24 13:09

administrator   ~0048510

Branch CR26892 has been updated by isk.

SHA-1: 4846a1076d0232fbb273f76995ccb79aff1ec549


Detailed log of new commits:

Author: isk
Date: Tue Nov 24 11:13:28 2015 +0300

    Fix remarks by kgv.

git

2015-11-24 13:11

administrator   ~0048511

Branch CR26892 has been updated forcibly by isk.

SHA-1: 8b87aec771548d81fc92ed5028b2d948e7b7b54f

git

2015-11-24 13:13

administrator   ~0048512

Branch CR26892_1 has been created by isk.

SHA-1: 455b6fb9da683c8aeac326ab890c16e012ebf711


Detailed log of new commits:

Author: isk
Date: Tue Nov 24 13:13:29 2015 +0300

    0026892: Visualization, TKOpenGl - support 3D textures within OpenGl_Texture
    Add a new arbTexFloat extension in OpenGl_Context.
    Add a new prototype glTexImage in OpenGl_GlFunctions.

git

2015-11-25 08:47

administrator   ~0048543

Branch CR26892 has been updated by isk.

SHA-1: 657279dc2543d7ab3feec8135d8745d7f0108d3d


Detailed log of new commits:

Author: isk
Date: Tue Nov 24 15:47:08 2015 +0300

    Cosmetics.

git

2015-11-25 08:47

administrator   ~0048544

Branch CR26892_1 has been updated forcibly by isk.

SHA-1: da0a0a3169a30a9a83e9fdb19c7112621de931b3

git

2015-11-25 09:01

administrator   ~0048545

Branch CR26892_1 has been updated forcibly by isk.

SHA-1: 90160585efbaa86e985b8dbd9c208d346f1c1d69

isk

2015-11-25 09:04

developer   ~0048546

Dear Kirill,
please review the branch CR26892_1.

git

2015-11-25 14:33

administrator   ~0048566

Branch CR26892 has been updated by isk.

SHA-1: 93cf4e0c25f3436fa34df73b9d71ad0410fef6d4


Detailed log of new commits:

Author: isk
Date: Wed Nov 25 11:32:33 2015 +0300

    Add missing initialization arbTexFloat for OpenGL ES 3.0+.
    Push error message if glTexImage3D is unavailable.

git

2015-11-25 14:33

administrator   ~0048567

Branch CR26892_1 has been updated forcibly by isk.

SHA-1: 599c131d48570cefba2997a12f385fecd2fc9f57

isk

2015-12-04 11:51

developer   ~0048747

Dear Kirill,
please review the branch CR26892_1.

git

2015-12-08 12:17

administrator   ~0048830

Branch CR26892_1 has been updated forcibly by isk.

SHA-1: 46e66cc61a5f7107a4d50e02c8c2b7a9d67fe96e

isk

2015-12-08 12:18

developer   ~0048831

Rebase branch CR26892_1 on the current master.

kgv

2015-12-10 15:24

developer   ~0048954

Please check compilation, testing is not needed.

git

2015-12-11 13:23

administrator   ~0049026

Branch CR26892_1 has been updated forcibly by mkv.

SHA-1: 71a1451fa821cb664d0bf1f6423734c5677ca211

mkv

2015-12-14 17:33

tester   ~0049113

Dear BugMaster,
Branch CR26892_1 was rebased on current master of occt git-repository.
SHA-1: 71a1451fa821cb664d0bf1f6423734c5677ca211

mkv

2015-12-14 17:33

tester   ~0049114

Dear BugMaster,
Branch CR26892_1 from occt git-repository (and master from products git-repository) was compiled on Linux and Windows platforms on Release mode.
SHA-1: 71a1451fa821cb664d0bf1f6423734c5677ca211

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)

products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)

mkv

2015-12-14 17:34

tester   ~0049115

Dear BugMaster,
Branch CR26892_1 is TESTED.

git

2016-04-17 14:01

administrator   ~0053027

Branch CR26892 has been deleted by kgv.

SHA-1: 93cf4e0c25f3436fa34df73b9d71ad0410fef6d4

git

2016-04-17 14:07

administrator   ~0053062

Branch CR26892_1 has been deleted by kgv.

SHA-1: 71a1451fa821cb664d0bf1f6423734c5677ca211

Related Changesets

occt: master 74fb257d

2015-11-25 08:35:38

isk


Committer: bugmaster Details Diff		 0026892: Visualization, TKOpenGl - support 3D textures within OpenGl_Texture
Add a new arbTexFloat extension in OpenGl_Context.
Add a new prototype glTexImage in OpenGl_GlFunctions.
Push error message if glTexImage3D is unavailable.		 Affected Issues
0026892
mod - src/OpenGl/OpenGl_Context.cxx Diff File
mod - src/OpenGl/OpenGl_Context.hxx Diff File
mod - src/OpenGl/OpenGl_GlFunctions.hxx Diff File
mod - src/OpenGl/OpenGl_Texture.cxx Diff File
mod - src/OpenGl/OpenGl_Texture.hxx Diff File

Issue History

Date Modified Username Field Change
2015-11-18 10:21 isk New Issue
2015-11-18 10:21 isk Assigned To => kgv
2015-11-18 11:32 kgv Assigned To kgv => isk
2015-11-18 11:32 kgv Severity minor => feature
2015-11-18 11:32 kgv Status new => assigned
2015-11-18 11:32 kgv Summary Visualization, TKOpenGl - OpenGl_Texture doesn't support 3-dimensional textures => Visualization, TKOpenGl - support 3D textures within OpenGl_Texture
2015-11-20 14:00 git Note Added: 0048413
2015-11-20 14:01 isk Note Added: 0048414
2015-11-20 14:01 isk Assigned To isk => kgv
2015-11-20 14:01 isk Status assigned => resolved
2015-11-20 14:01 isk Steps to Reproduce Updated
2015-11-20 14:39 kgv Note Added: 0048422
2015-11-20 14:39 kgv Assigned To kgv => isk
2015-11-20 14:39 kgv Status resolved => assigned
2015-11-24 13:09 git Note Added: 0048510
2015-11-24 13:11 git Note Added: 0048511
2015-11-24 13:13 git Note Added: 0048512
2015-11-25 08:47 git Note Added: 0048543
2015-11-25 08:47 git Note Added: 0048544
2015-11-25 09:01 git Note Added: 0048545
2015-11-25 09:04 isk Note Added: 0048546
2015-11-25 09:04 isk Assigned To isk => kgv
2015-11-25 09:04 isk Status assigned => resolved
2015-11-25 10:34 kgv Assigned To kgv => isk
2015-11-25 10:34 kgv Status resolved => assigned
2015-11-25 14:33 git Note Added: 0048566
2015-11-25 14:33 git Note Added: 0048567
2015-12-04 11:51 isk Note Added: 0048747
2015-12-04 11:51 isk Assigned To isk => kgv
2015-12-04 11:51 isk Status assigned => resolved
2015-12-08 12:17 git Note Added: 0048830
2015-12-08 12:18 isk Note Added: 0048831
2015-12-10 15:24 kgv Note Added: 0048954
2015-12-10 15:24 kgv Assigned To kgv => bugmaster
2015-12-10 15:24 kgv Status resolved => reviewed
2015-12-11 10:57 mkv Assigned To bugmaster => mkv
2015-12-11 13:23 git Note Added: 0049026
2015-12-14 17:33 mkv Note Added: 0049113
2015-12-14 17:33 mkv Note Added: 0049114
2015-12-14 17:34 mkv Note Added: 0049115
2015-12-14 17:34 mkv Assigned To mkv => bugmaster
2015-12-14 17:34 mkv Status reviewed => tested
2015-12-14 17:34 mkv Test case number => Not needed
2015-12-18 15:25 bugmaster Changeset attached => occt master 74fb257d
2015-12-18 15:25 bugmaster Status tested => verified
2015-12-18 15:25 bugmaster Resolution open => fixed
2016-04-17 14:01 git Note Added: 0053027
2016-04-17 14:07 git Note Added: 0053062
2016-04-20 15:42 aiv Fixed in Version => 7.0.0
2016-04-20 15:50 aiv Status verified => closed