View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0026885 | Open CASCADE | OCCT:Visualization | public | 2015-11-17 16:00 | 2016-12-09 16:38 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | integration request | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.5.3 | ||||
| Target Version | 7.1.0 | Fixed in Version | 7.1.0 | ||
| Summary | 0026885: Visualization - drop redundant aspects from structure level | ||||
| Description | Original quotation from 0023117: 2. Aspects at the level of Graphic3d_Structure and OpenGl_Structure. Currently, if e.g. a face aspect is defined at structure level, and a group inside this structure also defines a face aspect, then the structure's one is simply ignored. Since it is a common practice to define the necessary aspects at the level of the current group (not at the level of the structure), holding structure aspects is of no use. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
| related to | 0026612 | closed | bugmaster | Community | High memory footprint displaying model with big amount of solids |
| related to | 0027617 | closed | bugmaster | Open CASCADE | Visualization, TKOpenGl - apply highlighting color without disabling lighting |
| parent of | 0027717 | closed | bugmaster | Open CASCADE | Visualization - drop broken Prs3d_Drawer::ShadingAspectGlobal() flag |
| child of | 0023117 | closed | bugmaster | Open CASCADE | TKV3d and TKOpenGl code clean-up |
|
|
Branch CR26885 has been created by kgv. SHA-1: e17ea5d2fc29dc2ad399b457d92a7c53e8eb23f5 Detailed log of new commits: Author: kgv Date: Thu Jun 16 23:26:19 2016 +0300 0026885: Visualization - drop redundant aspects from structure level Graphic3d_CStructure and OpenGl_Structure do not store structure aspects anymore. Graphic3d_Structure, Prs3d_Presentation - structure aspect methods have been removed. AIS_InteractiveObject::SetAspect() - globalChange argument has been removed. Undocumented test methods V3d::DrawSphere(), ::SetPlane(), ::PickGrid() have been removed. |
|
|
Patch is ready for review. |
|
|
Branch CR26885 has been updated forcibly by kgv. SHA-1: 02204e375a077585e82dd494090b6ae77d0aa984 |
|
|
Branch CR26885 has been updated forcibly by kgv. SHA-1: da779162cbbbc2cd216e89882f9b064198e3aa9c |
|
|
Branch CR26885 reviewed without remarks, ready for testing. |
|
|
Dear BugMaster, Branch CR26885 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested. SHA-1: da779162cbbbc2cd216e89882f9b064198e3aa9c Number of compiler warnings: occt component: Linux: 0 (0 on master) Windows: 0 (0 on master) MasOS: 0 (0 on master) products component: Linux: 68 Windows: 0 MacOS: 1119 Regressions/Differences: http://occt-tests/CR26885-master-OCCT/Debian70-64/summary.html http://occt-tests/CR26885-master-OCCT/Windows-64-VC10/summary.html bugs vis bug23067, bug26754, bug26975 Testing on Linux: Total MEMORY difference: 89671289 / 89135419 [+0.60%] Total CPU difference: 19427.789999999997 / 19457.88999999997 [-0.15%] Testing on Windows: Total MEMORY difference: 55860575 / 55898813 [-0.07%] Total CPU difference: 18441.205812098793 / 18535.524016698953 [-0.51%] There are differences in images found by testdiff: http://occt-tests/CR26885-master-OCCT/Debian70-64/diff-Debian70-64.html http://occt-tests/CR26885-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10.html v3d point_cloud sphere |
|
|
Dear Kirill, Branch CR26885 has been rejected due to: - regressions/differences/improvements - differences in images |
|
|
Branch CR26885 has been updated by kgv. SHA-1: 3d23d8a36a27fbcbbf3954eaf88cdb34b15cd8da Detailed log of new commits: Author: kgv Date: Mon Jun 20 18:56:30 2016 +0300 AIS_PointCloud now sets up ShadingAspect within Compute() and does not override PointAspect of global drawer. ViewerTest now sets group aspect within vuserdraw and vdrawparray. |
|
|
Branch CR26885_1 has been created by kgv. SHA-1: 0da88b20899dcd481230237bda9c6bbcd53d6f29 Detailed log of new commits: Author: kgv Date: Mon Jun 20 19:10:51 2016 +0300 0026885: Visualization - drop redundant aspects from structure level Graphic3d_CStructure and OpenGl_Structure do not store structure aspects anymore. Graphic3d_Structure, Prs3d_Presentation - structure aspect methods have been removed. AIS_InteractiveObject::SetAspect() - globalChange argument has been removed. Undocumented test methods V3d::DrawSphere(), ::SetPlane(), ::PickGrid() have been removed. |
|
|
Regressions should be fixed within updated patch CR26885_. |
|
|
Dear BugMaster, Branch CR26885_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested. SHA-1: 0da88b20899dcd481230237bda9c6bbcd53d6f29 Number of compiler warnings: occt component: Linux: 0 (0 on master) Windows: 0 (0 on master) MacOS: 0 (0 on master) products component: Linux: 68 Windows: 0 MacOS: 1140 Regressions/Differences: Not detected Testing cases: Not needed Testing on Linux: Total MEMORY difference: 88723219 / 89129632 [-0.46%] Total CPU difference: 19421.43000000002 / 19458.48999999997 [-0.19%] Testing on Windows: Total MEMORY difference: 55859943 / 55904007 [-0.08%] Total CPU difference: 18101.73203599882 / 18535.836018698956 [-2.34%] |
|
|
Branch CR26885_1 has been deleted by inv. SHA-1: 0da88b20899dcd481230237bda9c6bbcd53d6f29 |
|
|
Branch CR26885 has been deleted by inv. SHA-1: 3d23d8a36a27fbcbbf3954eaf88cdb34b15cd8da |
|
occt: master 2831708b 2016-06-20 16:10:51 Committer: bugmaster Details Diff |
0026885: Visualization - drop redundant aspects from structure level Graphic3d_CStructure and OpenGl_Structure do not store structure aspects anymore. Graphic3d_Structure, Prs3d_Presentation - structure aspect methods have been removed. AIS_InteractiveObject::SetAspect() - globalChange argument has been removed. Undocumented test methods V3d::DrawSphere(), ::SetPlane(), ::PickGrid() have been removed. |
Affected Issues 0026885 |
|
| mod - dox/dev_guides/upgrade/upgrade.md | Diff File | ||
| mod - src/AIS/AIS_InteractiveContext.cxx | Diff File | ||
| mod - src/AIS/AIS_InteractiveContext.hxx | Diff File | ||
| mod - src/AIS/AIS_InteractiveObject.cxx | Diff File | ||
| mod - src/AIS/AIS_InteractiveObject.hxx | Diff File | ||
| mod - src/AIS/AIS_Manipulator.cxx | Diff File | ||
| mod - src/AIS/AIS_PointCloud.cxx | Diff File | ||
| mod - src/AIS/AIS_Shape.cxx | Diff File | ||
| mod - src/AIS/AIS_TexturedShape.cxx | Diff File | ||
| mod - src/Graphic3d/Graphic3d_CStructure.cxx | Diff File | ||
| mod - src/Graphic3d/Graphic3d_CStructure.hxx | Diff File | ||
| mod - src/Graphic3d/Graphic3d_Group.cxx | Diff File | ||
| mod - src/Graphic3d/Graphic3d_Structure.cxx | Diff File | ||
| mod - src/Graphic3d/Graphic3d_Structure.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_Structure.cxx | Diff File | ||
| mod - src/OpenGl/OpenGl_Structure.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_View_Raytrace.cxx | Diff File | ||
| mod - src/OpenGl/OpenGl_Workspace.cxx | Diff File | ||
| mod - src/Prs3d/Prs3d_Presentation.cxx | Diff File | ||
| mod - src/Prs3d/Prs3d_Presentation.hxx | Diff File | ||
| mod - src/PrsMgr/PrsMgr_Presentation.cxx | Diff File | ||
| mod - src/PrsMgr/PrsMgr_Presentation.hxx | Diff File | ||
| mod - src/PrsMgr/PrsMgr_PresentationManager.cxx | Diff File | ||
| mod - src/PrsMgr/PrsMgr_PresentationManager.hxx | Diff File | ||
| mod - src/V3d/V3d.cxx | Diff File | ||
| mod - src/V3d/V3d.hxx | Diff File | ||
| mod - src/V3d/V3d_Plane.cxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_OpenGlCommands.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-11-17 16:00 | kgv | New Issue | |
| 2015-11-17 16:00 | kgv | Assigned To | => kgv |
| 2015-11-17 16:00 | kgv | Relationship added | child of 0023117 |
| 2016-06-16 23:26 | git | Note Added: 0055115 | |
| 2016-06-16 23:27 | kgv | Note Added: 0055116 | |
| 2016-06-16 23:27 | kgv | Assigned To | kgv => san |
| 2016-06-16 23:27 | kgv | Severity | minor => integration request |
| 2016-06-16 23:27 | kgv | Status | new => resolved |
| 2016-06-17 10:30 | git | Note Added: 0055123 | |
| 2016-06-17 11:16 | git | Note Added: 0055125 | |
| 2016-06-17 14:46 |
|
Note Added: 0055175 | |
| 2016-06-17 14:46 |
|
Assigned To | san => bugmaster |
| 2016-06-17 14:46 |
|
Status | resolved => reviewed |
| 2016-06-17 15:05 | kgv | Relationship added | related to 0026612 |
| 2016-06-17 15:25 |
|
Assigned To | bugmaster => apv |
| 2016-06-20 16:26 |
|
Note Added: 0055240 | |
| 2016-06-20 16:26 |
|
Assigned To | apv => kgv |
| 2016-06-20 16:26 |
|
Status | reviewed => assigned |
| 2016-06-20 16:26 |
|
Note Edited: 0055240 | |
| 2016-06-20 16:28 |
|
Note Added: 0055241 | |
| 2016-06-20 19:05 | git | Note Added: 0055259 | |
| 2016-06-20 19:10 | git | Note Added: 0055260 | |
| 2016-06-20 19:14 | kgv | Relationship added | related to 0027617 |
| 2016-06-20 19:40 | kgv | Note Added: 0055267 | |
| 2016-06-20 19:40 | kgv | Assigned To | kgv => bugmaster |
| 2016-06-20 19:40 | kgv | Status | assigned => resolved |
| 2016-06-20 19:40 | kgv | Status | resolved => reviewed |
| 2016-06-21 11:12 |
|
Assigned To | bugmaster => apv |
| 2016-06-22 11:00 |
|
Test case number | => Not needed |
| 2016-06-22 11:02 |
|
Note Added: 0055326 | |
| 2016-06-22 11:02 |
|
Assigned To | apv => bugmaster |
| 2016-06-22 11:02 |
|
Status | reviewed => tested |
| 2016-06-24 12:41 | bugmaster | Changeset attached | => occt master 2831708b |
| 2016-06-24 12:41 | bugmaster | Status | tested => verified |
| 2016-06-24 12:41 | bugmaster | Resolution | open => fixed |
| 2016-06-24 12:57 | git | Note Added: 0055419 | |
| 2016-06-24 12:57 | git | Note Added: 0055420 | |
| 2016-07-27 16:44 | kgv | Relationship added | parent of 0027717 |
| 2016-12-09 16:31 |
|
Status | verified => closed |
| 2016-12-09 16:38 |
|
Fixed in Version | => 7.1.0 |
