View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0026720 | Open CASCADE | OCCT:Data Exchange | public | 2015-09-25 10:51 | 2016-04-20 15:49 |
| Reporter | Assigned To | bugmaster | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.0.0 | Fixed in Version | 7.0.0 | ||
| Summary | 0026720: Coding, STEP - non-conformant names of class fields | ||||
| Description | Some classes in StepDimTol package declare fields with names starting with prefix 'the' which is reserved (according to OCCT coding rules) for arguments of functions. This leads to hiding of class members by function arguments in some methods that follow 'the' convention, reported as warning by Visual Studio 2015, e.g.: StepDimTol_GeoTolAndGeoTolWthMod.cxx:42: declaration of 'theMagnitude' hides class member To avoid this, class members should be renamed to start with 'my'. The relevant classes and fields are: StepDimTol_CommonDatum.hxx: Handle(StepDimTol_Datum) theDatum; StepDimTol_Datum.hxx: Handle(TCollection_HAsciiString) theIdentification; StepDimTol_DatumReference.hxx: Standard_Integer thePrecedence; StepDimTol_DatumReference.hxx: Handle(StepDimTol_Datum) theReferencedDatum; StepDimTol_DatumTarget.hxx: Handle(TCollection_HAsciiString) theTargetId; StepDimTol_GeometricTolerance.hxx: Handle(TCollection_HAsciiString) theName; StepDimTol_GeometricTolerance.hxx: Handle(TCollection_HAsciiString) theDescription; StepDimTol_GeometricTolerance.hxx: Handle(StepBasic_MeasureWithUnit) theMagnitude; StepDimTol_GeometricTolerance.hxx: StepDimTol_GeometricToleranceTarget theTolerancedShapeAspect; StepDimTol_GeometricToleranceRelationship.hxx: Handle(TCollection_HAsciiString) theName; StepDimTol_GeometricToleranceRelationship.hxx: Handle(TCollection_HAsciiString) theDescription; StepDimTol_GeometricToleranceRelationship.hxx: Handle(StepDimTol_GeometricTolerance) theRelatingGeometricTolerance; StepDimTol_GeometricToleranceRelationship.hxx: Handle(StepDimTol_GeometricTolerance) theRelatedGeometricTolerance; StepDimTol_GeometricToleranceWithDatumReference.hxx: Handle(StepDimTol_HArray1OfDatumSystemOrReference) theDatumSystem; StepDimTol_ModifiedGeometricTolerance.hxx: StepDimTol_LimitCondition theModifier; | ||||
| Steps To Reproduce | Build with VS 2015 | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Branch CR26720 has been created by rkv. SHA-1: c41bc8145ec206adaa7936668c6619c225bb8aed Detailed log of new commits: Author: rkv Date: Thu Oct 8 10:06:55 2015 +0300 0026720: Coding, STEP - non-conformant names of class fields Names of class fields and method parameters are fixed according to coding standard. |
|
|
No remarks, please test |
|
|
Branch CR26720 has been updated forcibly by mkv. SHA-1: b767854151abd75f197c08ee6a1c112723f6b128 |
|
|
Dear BugMaster, Branch CR26720 was rebased on branch IR-2015-10-08 of occt git-repository. SHA-1: b767854151abd75f197c08ee6a1c112723f6b128 |
|
|
Dear BugMaster, Branch CR26720 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: b767854151abd75f197c08ee6a1c112723f6b128 Number of compiler warnings: occt component : Linux: 13 (13 on master) Windows: 0 (0 on master) products component : Linux: 39 (39 on master) Windows: 0 (0 on master) Regressions/Differences/Improvements: No regressions/differences Testing cases: Not needed Testing on Linux: occt component : Total MEMORY difference: 92614750 / 92505313 [+0.12%] Total CPU difference: 19521.739999999772 / 19399.04000000005 [+0.63%] products component : Total MEMORY difference: 26357034 / 26340904 [+0.06%] Total CPU difference: 7413.829999999995 / 7326.710000000003 [+1.19%] Testing on Windows: occt component : Total MEMORY difference: 58085079 / 58097941 [-0.02%] Total CPU difference: 18990.09533059883 / 18013.419869898902 [+5.42%] products component : Total MEMORY difference: 17182220 / 17187400 [-0.03%] Total CPU difference: 6074.803740800005 / 5633.211710099969 [+7.84%] There are no differences in images found by testdiff. |
|
|
Dear BugMaster, Branch CR26720 is TESTED. |
|
|
Branch CR26720 has been deleted by kgv. SHA-1: b767854151abd75f197c08ee6a1c112723f6b128 |
|
occt: master 2f220b97 2015-10-08 07:06:55
Committer: bugmaster Details Diff |
0026720: Coding, STEP - non-conformant names of class fields Names of class fields and method parameters are fixed according to coding standard. |
Affected Issues 0026720 |
|
| mod - src/RWStepDimTol/RWStepDimTol_RWDatumReferenceCompartment.cxx | Diff File | ||
| mod - src/RWStepDimTol/RWStepDimTol_RWDatumReferenceElement.cxx | Diff File | ||
| mod - src/RWStepDimTol/RWStepDimTol_RWGeneralDatumReference.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_CommonDatum.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_CommonDatum.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_Datum.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_Datum.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_DatumReference.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_DatumReference.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_DatumReferenceModifierWithValue.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_DatumReferenceModifierWithValue.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_DatumSystem.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_DatumSystem.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_DatumTarget.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_DatumTarget.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeneralDatumReference.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeneralDatumReference.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricTolerance.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricTolerance.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceRelationship.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceRelationship.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithDatumReference.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithDatumReference.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithDefinedAreaUnit.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithDefinedAreaUnit.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithDefinedUnit.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithDefinedUnit.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithMaximumTolerance.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithMaximumTolerance.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithModifiers.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_GeometricToleranceWithModifiers.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ModifiedGeometricTolerance.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ModifiedGeometricTolerance.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ProjectedZoneDefinition.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ProjectedZoneDefinition.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_RunoutZoneDefinition.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_RunoutZoneDefinition.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_RunoutZoneOrientation.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_RunoutZoneOrientation.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ToleranceZone.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ToleranceZone.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ToleranceZoneDefinition.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ToleranceZoneDefinition.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ToleranceZoneForm.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_ToleranceZoneForm.hxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_UnequallyDisposedGeometricTolerance.cxx | Diff File | ||
| mod - src/StepDimTol/StepDimTol_UnequallyDisposedGeometricTolerance.hxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-09-25 10:51 |
|
New Issue | |
| 2015-09-25 10:51 |
|
Assigned To | => gka |
| 2015-09-25 10:53 |
|
Assigned To | gka => ika |
| 2015-09-25 10:53 |
|
Status | new => assigned |
| 2015-10-07 12:17 |
|
Assigned To | ika => rkv |
| 2015-10-08 10:08 | git | Note Added: 0046580 | |
| 2015-10-08 10:09 |
|
Assigned To | rkv => gka |
| 2015-10-08 10:09 |
|
Status | assigned => resolved |
| 2015-10-08 10:09 |
|
Assigned To | gka => abv |
| 2015-10-08 10:54 |
|
Note Added: 0046584 | |
| 2015-10-08 10:54 |
|
Assigned To | abv => bugmaster |
| 2015-10-08 10:54 |
|
Status | resolved => reviewed |
| 2015-10-08 14:01 |
|
Assigned To | bugmaster => apv |
| 2015-10-08 17:32 | git | Note Added: 0046605 | |
| 2015-10-08 18:58 |
|
Assigned To | apv => mkv |
| 2015-10-09 20:19 |
|
Note Added: 0046647 | |
| 2015-10-09 20:19 |
|
Note Added: 0046648 | |
| 2015-10-09 20:19 |
|
Note Added: 0046649 | |
| 2015-10-09 20:19 |
|
Assigned To | mkv => bugmaster |
| 2015-10-09 20:19 |
|
Status | reviewed => tested |
| 2015-10-09 20:20 |
|
Test case number | => Not needed |
| 2015-10-16 13:18 | bugmaster | Changeset attached | => occt master 2f220b97 |
| 2015-10-16 13:18 | bugmaster | Status | tested => verified |
| 2015-10-16 13:18 | bugmaster | Resolution | open => fixed |
| 2015-10-16 16:58 | git | Note Added: 0047099 | |
| 2016-04-20 15:44 |
|
Fixed in Version | => 7.0.0 |
| 2016-04-20 15:49 |
|
Status | verified => closed |
