MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0026166Community[OCCT] OCCT:Shape Healingpublic2015-04-29 17:192017-07-27 09:43
ReporterDamir Bogrov 
Assigned Toabv 
PrioritynormalSeverityminor 
StatusassignedResolutionopen 
PlatformWindowsOSVC++ 2013OS Version64 bit
Product Version[OCCT] 6.7.1 
Target Version[OCCT] 7.4.0*Fixed in Version 
Summary0026166: Improve ShapeHealing execution time on shape without PCurves
DescriptionUsing a new Extrema_ExtAlgo_Tree algorithm in Extrema_GenExtPS leads to more than 5X speed up on shapes, that contained edges without pcurves.

See http://dev.opencascade.org/index.php?q=node/1078 [^]


P.S. Also, we're testing with 6.9.0.beta1 version of OCCT. Extrema_ExtAlgo_Grad's time was improved by 25%, but it's not enough to achieve Extrema_ExtAlgo_Tree's time.
Steps To ReproduceSee c++ reproducer (in slideset) and testmodels in the attachment.
TagsNo tags attached.
Test case number
Attached Fileszip file icon Using_Extrema_ExtAlgo_Tree_in_ShapeHealing.zip (1,402,213 bytes) 2015-04-29 17:19

- Relationships

-  Notes
(0040446)
git (administrator)
2015-04-29 23:01

Branch CR26166 has been created by abv.

SHA-1: 5c210a49ddf14c32b68c1423298fef54126105e8


Detailed log of new commits:

Author: abv
Date: Wed Apr 29 23:00:28 2015 +0300

    0026166: Improve ShapeHealing execution time on shape without PCurves
    
    Default projection algorithm changed to Tree in Extrema_GenExtPS
    
    Test grid perf heal added
(0040447)
abv (manager)
2015-04-29 23:14
edited on: 2015-04-29 23:15

I have pushed the change to CR26166 and tested. The result is slight overall improvement of performance (~ 1%), with some cases improved tremendously:

CPU bugs heal bug24549: 1.6536106 / 3.8376246 [-56.91%]
CPU bugs modalg_2 bug5157_1: 27.4873762 / 55.8795582 [-50.81%]
CPU bugs modalg_2 bug5157_2: 27.6745774 / 55.8171578 [-50.42%]
CPU de step_2 U4: 0.7956051 / 40.2326579 [-98.02%]
CPU de step_4 H5: 8.9700575 / 27.6277771 [-67.53%]
CPU de step_5 A3: 8.7828563 / 27.0661735 [-67.55%]
CPU perf heal pcurves1: 3.5568228 / 18.8449208 [-81.13%]
CPU perf heal pcurves2: 2.2152142 / 11.076071 [-80.00%]

(the last ones are new tests created using shapes attached to this issue)

Also memory has decreased in many cases (but not much overall).

However, there are some performance falls, e.g.:

CPU bugs step bug16351: 43.1966769 / 38.5946474 [+11.92%]
CPU de step_3 A4: 9.1260585 / 7.5192482 [+21.37%]
CPU feat featlf: 2.6676170999999984 / 2.0124128999999993 [+32.56%]
CPU perf bspline: 27.2065744 / 25.8649658 [+5.19%]

and more than 50 regressions:

Failed

bugs fclasses bug181_1
bugs modalg_1 bug10160_1 bug10160_2 bug10160_4
bugs modalg_2 bug22631
bugs modalg_5 bug23948_2
de iges_1 N9 P5 P9 R8
de iges_2 G8
de step_1 N3 ZI7
de step_2 D9 E9 J7 Q1 Q9 S1 S9 T5 T9 U5 U8 V1 X9
de step_3 B4 B5 B9 C4 C5 D7 E2 E3 E9 F2 F4
de step_4 B3 F6 F9 H1 H8 I1 I2
de step_5 A4 A7

Improvements

de iges_2 A7
de step_4 G7

This is to be investigated

(0040531)
git (administrator)
2015-05-04 22:36

Branch CR26166_1 has been created by Damir Bogrov.

SHA-1: 5c210a49ddf14c32b68c1423298fef54126105e8


No new revisions were added by this update.
(0040532)
Damir Bogrov (reporter)
2015-05-04 23:07

Previous fix for default projection algorithm caused a many regressions therefore locate this fix by shape-healing process only
(0040556)
git (administrator)
2015-05-05 13:56

Branch CR26166_1 has been updated by Damir Bogrov.

SHA-1: 9b972a94c1445602819302fbdbf6440162b80c4e


Detailed log of new commits:

Author: Damir Bogrov
Date: Tue May 5 13:13:36 2015 +0300

    Projection algorithm changed to Tree in ShapeAnalysis_Surface


- Issue History
Date Modified Username Field Change
2015-04-29 17:19 Damir Bogrov New Issue
2015-04-29 17:19 Damir Bogrov Assigned To => gka
2015-04-29 17:19 Damir Bogrov File Added: Using_Extrema_ExtAlgo_Tree_in_ShapeHealing.zip
2015-04-29 23:01 abv Assigned To gka => Damir Bogrov
2015-04-29 23:01 abv Status new => assigned
2015-04-29 23:01 git Note Added: 0040446
2015-04-29 23:14 abv Note Added: 0040447
2015-04-29 23:14 abv Target Version => 7.1.0
2015-04-29 23:15 abv Note Edited: 0040447 View Revisions
2015-05-04 22:36 git Note Added: 0040531
2015-05-04 23:07 Damir Bogrov Note Added: 0040532
2015-05-05 13:56 git Note Added: 0040556
2015-05-18 14:06 Damir Bogrov Assigned To Damir Bogrov => abv
2016-11-01 06:41 abv Target Version 7.1.0 => 7.2.0
2017-07-27 09:43 abv Target Version 7.2.0 => 7.4.0*


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker