View Issue Details

IDProjectCategoryView StatusLast Update
0026069Open CASCADEOCCT:Codingpublic2015-05-14 16:36
Reporterkgv Assigned Tobugmaster  
PriorityhighSeverityintegration request 
Status closedResolutionfixed 
PlatformMacOSOS 
Target Version6.9.0Fixed in Version6.9.0 
Summary0026069: Coding Rules - eliminate new warnings about redundant const qualifier in SelectMgr
DescriptionThere are a lot of warnings on selection classes about redundant const qualifier like this:
class SelectMgr_BaseFrustum
{
...
  virtual const Standard_Boolean Overlaps (const BVH_Box<Standard_Real, 3>& theBndBox,
                                           Standard_Real& theDepth);
...
warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]

New warnings should be eliminated.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot needed

Relationships

child of 0024623 closedbugmaster Visualization - improve selection mechanism 

Activities

abv

2015-04-15 14:47

manager   ~0039782

Please correct class SelectMgr_SensitiveEntity to inherit Standard_Transient and to use standard definition of Handle, rather than NCollection_Handle<> workaround

git

2015-04-23 01:10

administrator   ~0040139

Branch CR26069 has been created by vpa.

SHA-1: a81f2f751d539dba0265bca2885dbf34361e93f2


Detailed log of new commits:

Author: vpa
Date: Thu Apr 23 01:10:41 2015 +0300

    Redundant const type qualifiers were removed

Author: vpa
Date: Thu Apr 23 00:30:19 2015 +0300

    SelectMgr_SensitiveEntity now is inherited from Standard_Transient

git

2015-04-23 01:13

administrator   ~0040140

Branch CR26069_1 has been created by vpa.

SHA-1: 42f0ea39c31ee67c3e0b881a497bc17da7e8bbee


Detailed log of new commits:

Author: vpa
Date: Thu Apr 23 01:12:55 2015 +0300

    0026069: Coding Rules - eliminate new warnings about redundant const qualifier in SelectMgr
    
    SelectMgr_SensitiveEntity is now inherited from Standard_Transient;
    Redundant const type qualifiers were removed from selection classes.

vpa

2015-04-23 11:02

developer   ~0040154

Dear Kirill,

the patch in branch CR26069_1 is ready to be reviewed.

kgv

2015-04-23 19:41

developer   ~0040183

Please test the patch.

git

2015-04-24 17:31

administrator   ~0040226

Branch CR26069_1 has been updated forcibly by mkv.

SHA-1: 68b0b718d62216727036a12be638bdb5968df181

mkv

2015-04-27 18:42

tester   ~0040302

Dear BugMaster,
Branch CR26069_1 was rebased on current master of occt git-repository.
SHA-1: 68b0b718d62216727036a12be638bdb5968df181

mkv

2015-04-27 18:43

tester   ~0040303

Dear BugMaster,
Branch CR26069_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 68b0b718d62216727036a12be638bdb5968df181

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 4 (4 on master)
Windows: 0 (0 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 95354354 / 94623635 [+0.77%]
Total CPU difference: 57316.41999999992 / 51017.17999999946 [+12.35%]
products component :
Total MEMORY difference: 23837719 / 23790395 [+0.20%]
Total CPU difference: 17537.529999999984 / 17221.91999999996 [+1.83%]

Testing on Windows:
occt component :
Total MEMORY difference: 57254250 / 57268183 [-0.02%]
Total CPU difference: 15706.492681999054 / 15811.13815279897 [-0.66%]
products component :
Total MEMORY difference: 15600735 / 15605919 [-0.03%]
Total CPU difference: 6177.2495974999665 / 6275.40542669997 [-1.56%]

There are no differences in images found by testdiff.

git

2015-05-14 16:36

administrator   ~0041086

Branch CR26069 has been deleted by inv.

SHA-1: a81f2f751d539dba0265bca2885dbf34361e93f2

git

2015-05-14 16:36

administrator   ~0041087

Branch CR26069_1 has been deleted by inv.

SHA-1: 68b0b718d62216727036a12be638bdb5968df181

Related Changesets

occt: master 7ab15952

2015-04-22 22:12:55

vpa


Committer: bugmaster Details Diff
0026069: Coding Rules - eliminate new warnings about redundant const qualifier in SelectMgr

SelectMgr_SensitiveEntity is now inherited from Standard_Transient;
Redundant const type qualifiers were removed from selection classes.
Affected Issues
0026069
mod - src/SelectBasics/SelectBasics_PickResult.hxx Diff File
mod - src/SelectBasics/SelectBasics_SelectingVolumeManager.hxx Diff File
mod - src/SelectMgr/SelectMgr_BaseFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_BaseFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_Frustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_Frustum.lxx Diff File
mod - src/SelectMgr/SelectMgr_RectangularFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_RectangularFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_SelectableObjectSet.cxx Diff File
mod - src/SelectMgr/SelectMgr_SelectableObjectSet.hxx Diff File
mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.cxx Diff File
mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.hxx Diff File
mod - src/SelectMgr/SelectMgr_Selection.cxx Diff File
mod - src/SelectMgr/SelectMgr_Selection.hxx Diff File
mod - src/SelectMgr/SelectMgr_Selection.lxx Diff File
mod - src/SelectMgr/SelectMgr_SensitiveEntity.cxx Diff File
mod - src/SelectMgr/SelectMgr_SensitiveEntity.hxx Diff File
mod - src/SelectMgr/SelectMgr_SensitiveEntitySet.cxx Diff File
mod - src/SelectMgr/SelectMgr_SensitiveEntitySet.hxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.cxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.hxx Diff File
mod - src/SelectMgr/SelectMgr_ViewerSelector.cxx Diff File
mod - src/SelectMgr/SelectMgr_ViewerSelector.hxx Diff File

Issue History

Date Modified Username Field Change
2015-04-13 14:58 kgv New Issue
2015-04-13 14:58 kgv Assigned To => kgv
2015-04-13 14:58 kgv Assigned To kgv => vpa
2015-04-13 14:58 kgv Status new => assigned
2015-04-13 14:58 kgv Relationship added child of 0024623
2015-04-15 14:47 abv Note Added: 0039782
2015-04-15 14:47 abv Priority normal => high
2015-04-23 01:10 git Note Added: 0040139
2015-04-23 01:13 git Note Added: 0040140
2015-04-23 11:02 vpa Note Added: 0040154
2015-04-23 11:02 vpa Assigned To vpa => kgv
2015-04-23 11:02 vpa Status assigned => resolved
2015-04-23 19:41 kgv Note Added: 0040183
2015-04-23 19:41 kgv Assigned To kgv => bugmaster
2015-04-23 19:41 kgv Status resolved => reviewed
2015-04-24 16:13 mkv Assigned To bugmaster => mkv
2015-04-24 17:31 git Note Added: 0040226
2015-04-27 18:42 mkv Note Added: 0040302
2015-04-27 18:43 mkv Note Added: 0040303
2015-04-27 18:43 mkv Assigned To mkv => bugmaster
2015-04-27 18:43 mkv Status reviewed => tested
2015-04-27 18:43 mkv Test case number => Not needed
2015-05-07 11:18 bugmaster Changeset attached => occt master 7ab15952
2015-05-07 11:18 bugmaster Status tested => verified
2015-05-07 11:18 bugmaster Resolution open => fixed
2015-05-14 15:28 aiv Status verified => closed
2015-05-14 15:30 aiv Fixed in Version => 6.9.0
2015-05-14 16:36 git Note Added: 0041086
2015-05-14 16:36 git Note Added: 0041087