View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0026009Open CASCADEOCCT:Modeling Algorithmspublic2015-04-02 11:122015-05-14 16:33
ReporternbvAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version6.9.0Fixed in Version6.9.0 
Summary0026009: Wrong result of the test blend bfuseblend B7
DescriptionAfter fixing the bug #25742 result of the test "blend bfuseblend B7" has been incorrect (good result is shown in the picture).

P.S.

1. This BAD result is NOT consequence of incorrect fixing. Intersection line between two given cylinders (which is the spine for blend-algorithm) has become better then before fix (tolreached has been decreased by approximately ten times). However, the result of blend algorithm has become FAIL. Most likely, the reason is labile blend algorithm.

2. On OCCT 6.7.1 test "blend bfuseblend B7" is fail. This problem was fixed (spontaneously) in the issue #25465 (see message http://tracker.dev.opencascade.org/view.php?id=25465#c34790).
Steps To Reproducetest blend bfuseblend B7
TagsNo tags attached.
Test case numberblend bfuseblend(003) B7

Attached Files

  • good blend.PNG (152,743 bytes)

Activities

nbv

2015-04-02 11:12

developer  

good blend.PNG (152,743 bytes)

git

2015-04-02 11:48

administrator   ~0039132

Branch CR26009 has been created by nbv.

SHA-1: 894075c5d9c572d83d07f5f17a0de62bd8e75dee


Detailed log of new commits:

Author: nbv
Date: Thu Apr 2 11:40:42 2015 +0300

    0025742: A partition of 2 shapes stresses a performance issue
    
    1. Method Dump for Blend_Point class has been added.

git

2015-04-27 13:10

administrator   ~0040269

Branch CR26009_1 has been created by jgv.

SHA-1: 452cd3a8488059bdbf622ed0299894f709b4dd8b


Detailed log of new commits:

Author: jgv
Date: Mon Apr 27 13:10:12 2015 +0300

    0026009: Wrong result of the test blend bfuseblend B7

jgv

2015-04-27 13:12

developer   ~0040270

Please review the branch CR26009_1.

msv

2015-04-27 15:32

developer   ~0040281

Remark:

It is possible algo hanging. Please provide checking for too small step value.

git

2015-04-27 16:28

administrator   ~0040286

Branch CR26009_1 has been updated by jgv.

SHA-1: c58fb7e3d85fee30b9d3bc9607b1dc4cab990396


Detailed log of new commits:

Author: jgv
Date: Mon Apr 27 16:28:36 2015 +0300

    Correction to avoid infinite loop

jgv

2015-04-27 16:30

developer   ~0040288

Dear Mikhail,

please review corrected branch CR26009_1.

msv

2015-04-28 09:38

developer   ~0040309

Reviewed

abv

2015-04-28 09:54

manager   ~0040310

Look at this code:

+ hguide->D1(param, PtOnGuide, TgOnGuide);
+ //Check deflection on guide
+ Cosi = PrevTgOnGuide * TgOnGuide;
+ if (Cosi < 0.)
+ Cosi2 = 0.;
+ else
+ Cosi2 = Cosi * Cosi / PrevTgOnGuide.SquareMagnitude() / TgOnGuide.SquareMagnitude();


It may cause division by zero error if derivative is zero.

msv

2015-04-28 10:11

developer   ~0040312

I also noted this fact, but did not pay attention to it, because thought that hguide is always well defined curve having no special points.
However, if you have a doubt I do not mind to insert a protection here, especially because it is so simple:

+ Cosi = PrevTgOnGuide * TgOnGuide;
+ if (Cosi < gp::Resolution())
+ Cosi2 = 0.;
+ else
+ Cosi2 = Cosi * Cosi / PrevTgOnGuide.SquareMagnitude() / TgOnGuide.SquareMagnitude();

msv

2015-04-28 10:12

developer   ~0040314

Dear jgv, please make this small correction.

git

2015-04-28 14:31

administrator   ~0040345

Branch CR26009_1 has been updated by jgv.

SHA-1: 57bb0ed572871029fcdffbfbd34b2799a856a2a7


Detailed log of new commits:

Author: jgv
Date: Tue Apr 28 14:31:10 2015 +0300

    Minor correction

jgv

2015-04-28 14:32

developer   ~0040346

Thank you, Mikhail!

jgv

2015-04-28 16:12

developer   ~0040363

Please test the branch CR26009_1.

git

2015-04-29 15:08

administrator   ~0040415

Branch CR26009_1 has been updated by apv.

SHA-1: 456805aeb807e6be3b6c5b3cee56d5c07230c594


Detailed log of new commits:

Author: apv
Date: Wed Apr 29 15:07:53 2015 +0300

    Update of test-case for issue 0026009

apv

2015-04-29 15:26

tester   ~0040417

Dear BugMaster,

Branch CR26009_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 57bb0ed572871029fcdffbfbd34b2799a856a2a7

Number of compiler warnings:
occt component:
   Linux: 19 (18 on master)
   Windows: 2 (0 on master)
products component:
   Linux: 4 (4 on master)
   Windows: 0 (0 on master)
There are new additional warnings.
On Linux:
Blend_Walking_4.gxx:97, GNU C Compiler 4 (gcc), Priority: Normal
unused variable ‘Norme’
On Windows:
Blend_Walking_4.gxx:97, MSBuild, Priority: Normal
'Norme' : local variable is initialized but not referenced

Regressions/Differences:
Not detected

Testing cases:
blend bfuseblend(003) B7 - OK
http://occt-tests/CR26009-1-master-occt-64/Debian60-64/blend/bfuseblend/B7.html
http://occt-tests/CR26009-1-master-occt-64/Windows-64-VC10/blend/bfuseblend/B7.html

Testing on Linux:
Total MEMORY difference: 94823582 / 94606999 [+0.23%]
Total CPU difference: 51825.449999999575 / 51015.63999999946 [+1.59%]

Testing on Windows:
Total MEMORY difference: 57257797 / 57266783 [-0.02%]
Total CPU difference: 15809.000939098985 / 15810.26454719897 [-0.01%]

git

2015-04-29 15:48

administrator   ~0040425

Branch CR26009_1 has been updated by jgv.

SHA-1: ba2f11d712b6fb237af053c04d0acbdec61081fa


Detailed log of new commits:

Author: jgv
Date: Wed Apr 29 15:48:01 2015 +0300

    Fix of compiler's warning

jgv

2015-04-29 15:50

developer   ~0040426

Unused variable is deleted, compiler's warning disappeared.

apv

2015-04-30 11:48

tester   ~0040462

Dear BugMaster,

Branch CR26009_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: ba2f11d712b6fb237af053c04d0acbdec61081fa

Number of compiler warnings:
occt component:
   Linux: 18 (18 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 4 (4 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing cases:
blend bfuseblend(003) B7 - OK
http://occt-tests/CR26009-1-master-occt-64/Debian60-64/blend/bfuseblend/B7.html
http://occt-tests/CR26009-1-master-occt-64/Windows-64-VC10/blend/bfuseblend/B7.html

Testing on Linux:
Total MEMORY difference: 94735830 / 94605273 [+0.14%]
Total CPU difference: 51686.60999999931 / 51015.509999999456 [+1.32%]

Testing on Windows:
Total MEMORY difference: 57258907 / 57267962 [-0.02%]
Total CPU difference: 15903.943147699067 / 15810.29574739897 [+0.59%]

git

2015-05-14 16:33

administrator   ~0041056

Branch CR26009 has been deleted by inv.

SHA-1: 894075c5d9c572d83d07f5f17a0de62bd8e75dee

git

2015-05-14 16:33

administrator   ~0041057

Branch CR26009_1 has been deleted by inv.

SHA-1: ba2f11d712b6fb237af053c04d0acbdec61081fa

Related Changesets

occt: master d66bd706

2015-04-30 11:46:18

jgv


Committer: bugmaster Details Diff		 0026009: Wrong result of the test blend bfuseblend B7

Correction to avoid infinite loop

Minor correction

Update of test-case for issue 0026009

Fix of compiler's warning		 Affected Issues
0026009
mod - src/Blend/Blend_Walking_4.gxx Diff File
mod - tests/blend/bfuseblend/B7 Diff File

Issue History

Date Modified Username Field Change
2015-04-02 11:12 nbv New Issue
2015-04-02 11:12 nbv Assigned To => msv
2015-04-02 11:12 nbv File Added: good blend.PNG
2015-04-02 11:48 git Note Added: 0039132
2015-04-02 16:26 msv Assigned To msv => jgv
2015-04-02 16:26 msv Status new => assigned
2015-04-02 16:28 msv Summary Wrong result of bfuseblend DRAW-command => Wrong result of the test blend bfuseblend B7
2015-04-27 13:10 git Note Added: 0040269
2015-04-27 13:12 jgv Note Added: 0040270
2015-04-27 13:12 jgv Assigned To jgv => msv
2015-04-27 13:12 jgv Status assigned => resolved
2015-04-27 15:32 msv Note Added: 0040281
2015-04-27 15:32 msv Assigned To msv => jgv
2015-04-27 15:32 msv Status resolved => assigned
2015-04-27 16:28 git Note Added: 0040286
2015-04-27 16:30 jgv Note Added: 0040288
2015-04-27 16:30 jgv Assigned To jgv => msv
2015-04-27 16:30 jgv Status assigned => resolved
2015-04-28 09:38 msv Note Added: 0040309
2015-04-28 09:38 msv Assigned To msv => bugmaster
2015-04-28 09:38 msv Status resolved => reviewed
2015-04-28 09:54 abv Note Added: 0040310
2015-04-28 10:11 msv Note Added: 0040312
2015-04-28 10:12 msv Note Added: 0040314
2015-04-28 10:12 msv Assigned To bugmaster => jgv
2015-04-28 10:12 msv Status reviewed => assigned
2015-04-28 14:31 git Note Added: 0040345
2015-04-28 14:32 jgv Note Added: 0040346
2015-04-28 14:32 jgv Assigned To jgv => msv
2015-04-28 14:32 jgv Status assigned => resolved
2015-04-28 16:12 jgv Note Added: 0040363
2015-04-28 16:12 jgv Assigned To msv => bugmaster
2015-04-28 16:12 jgv Status resolved => reviewed
2015-04-28 16:24 apv Assigned To bugmaster => apv
2015-04-29 14:48 apv Test case number => blend bfuseblend(003) B7
2015-04-29 15:08 git Note Added: 0040415
2015-04-29 15:26 apv Note Added: 0040417
2015-04-29 15:26 apv Assigned To apv => jgv
2015-04-29 15:26 apv Status reviewed => assigned
2015-04-29 15:48 git Note Added: 0040425
2015-04-29 15:50 jgv Note Added: 0040426
2015-04-29 15:50 jgv Assigned To jgv => msv
2015-04-29 15:50 jgv Status assigned => resolved
2015-04-29 15:50 jgv Assigned To msv => bugmaster
2015-04-29 15:50 jgv Status resolved => reviewed
2015-04-29 15:51 jgv Assigned To bugmaster => jgv
2015-04-29 15:51 jgv Assigned To jgv => apv
2015-04-30 11:48 apv Note Added: 0040462
2015-04-30 11:48 apv Assigned To apv => bugmaster
2015-04-30 11:48 apv Status reviewed => tested
2015-05-07 11:18 bugmaster Changeset attached => occt master d66bd706
2015-05-07 11:18 bugmaster Status tested => verified
2015-05-07 11:18 bugmaster Resolution open => fixed
2015-05-14 15:28 aiv Status verified => closed
2015-05-14 15:30 aiv Fixed in Version => 6.9.0
2015-05-14 16:33 git Note Added: 0041056
2015-05-14 16:33 git Note Added: 0041057