View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0025933 | Open CASCADE | OCCT:Visualization | public | 2015-03-13 16:56 | 2015-05-14 15:31 |
| Reporter | Assigned To | bugmaster | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.8.0 | ||||
| Target Version | 6.9.0 | Fixed in Version | 6.9.0 | ||
| Summary | 0025933: Visualization - Forward AIS_InteractiveObject::Redisplay() execution to AIS_InteractiveContext | ||||
| Description | To avoid incorrect update of dependent structures after direct calls to AIS_InteractiveObject::Redisplay(), it is needed to change behavior of the method mentioned and forward its execution to AIS_InteractiveObject::Redisplay() one. | ||||
| Steps To Reproduce | Not required | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Branch CR25933 has been created by vpa. SHA-1: bd3554136c519be36b88d6effd762d488ea7c7b9 Detailed log of new commits: Author: vpa Date: Fri Mar 13 18:49:30 2015 +0300 0025933: Visualization - Remove method Redisplay() from AIS_InteractiveObject All calls of AIS_InteractiveObject::Redisplay were replaced by AIS_InteractiveContext::Redisplay ones or correspondent updates of object |
|
|
Branch CR25933 has been updated forcibly by vpa. SHA-1: 399b4d5670b6f4d177c5b8422be8af898ca79ae7 |
|
|
Dear Sergey, the patch in branch CR25933 is ready to be reviewed. |
|
|
Would not it be convenient to keep Redisplay() in object, redirecting it to context? I imagine that I might need to do this if I have object only. |
|
|
Branch CR25933 has been updated forcibly by vpa. SHA-1: 393091c3bdd06edff4194530a10f4e7ed384e81e |
|
|
Dear Andrey, the patch in branch CR25933 was updated according to your remark. |
|
|
> Would not it be convenient to keep Redisplay() in object, redirecting it to context? > I imagine that I might need to do this if I have object only. This will be incorrect by design, because object might be displayed in several contexts. Although this is rarely happens. |
|
|
Branch CR25933 reviewed without remarks, ready for testing. |
|
|
Branch CR25933 has been updated by mkv. SHA-1: e5e39a762ca0f9ac40867dcb2d8ecd9c0e2198b4 Detailed log of new commits: Author: mkv Date: Wed Mar 18 14:45:18 2015 +0300 Small correction of test case |
|
|
Dear BugMaster, Branch CR25933 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: 393091c3bdd06edff4194530a10f4e7ed384e81e Number of compiler warnings: occt component : Linux: 18 (18 on master) Windows: 0 (0 on master) products component : Linux: 11 (11 on master) Windows: 4 (4 on master) Regressions/Differences: No regressions/differences Testing cases: Not needed Testing on Linux: occt component : Total MEMORY difference: 90159687 / 90114426 Total CPU difference: 58319.9200000002 / 58911.169999999984 products component : Total MEMORY difference: 22959688 / 23045996 Total CPU difference: 15444.819999999982 / 16097.579999999978 Testing on Windows: occt component : Total MEMORY difference: 57858634 / 57860583 Total CPU difference: 50578.3125 / 54907.96875 products component : Total MEMORY difference: 15053862 / 15056278 Total CPU difference: 16752.71875 / 16748.84375 There are no differences in images found by testdiff. |
|
|
Branch CR25933 has been deleted by kgv. SHA-1: e5e39a762ca0f9ac40867dcb2d8ecd9c0e2198b4 |
|
occt: master 36132a2e 2015-03-19 13:02:42
Committer: bugmaster Details Diff |
0025933: Visualization - Forward AIS_InteractiveObject::Redisplay() execution to AIS_InteractiveContext AIS_InteractiveObject::Redisplay now redirects the execution to interactive context; All calls to AIS_InteractiveObject::Redisplay were replaced by AIS_InteractiveContext::Redisplay Small correction of test case |
Affected Issues 0025933 |
|
| mod - src/AIS/AIS_InteractiveContext.cxx | Diff File | ||
| mod - src/AIS/AIS_InteractiveObject.cdl | Diff File | ||
| mod - src/AIS/AIS_InteractiveObject.cxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest.cxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
| mod - tests/bugs/fclasses/bug63 | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-03-13 16:56 |
|
New Issue | |
| 2015-03-13 16:56 |
|
Assigned To | => vpa |
| 2015-03-13 16:57 |
|
Status | new => assigned |
| 2015-03-13 16:58 |
|
Relationship added | related to 0024623 |
| 2015-03-13 18:49 | git | Note Added: 0038356 | |
| 2015-03-13 18:53 | git | Note Added: 0038357 | |
| 2015-03-13 18:55 |
|
Note Added: 0038358 | |
| 2015-03-13 18:55 |
|
Assigned To | vpa => san |
| 2015-03-13 18:55 |
|
Status | assigned => resolved |
| 2015-03-13 18:56 |
|
Note Added: 0038359 | |
| 2015-03-13 19:34 |
|
Summary | Visualization - Remove method Redisplay() from AIS_InteractiveObject => Visualization - Forward AIS_InteractiveObject::Redisplay() execution to AIS_InteractiveContext |
| 2015-03-13 19:34 |
|
Description Updated | |
| 2015-03-13 19:40 | git | Note Added: 0038362 | |
| 2015-03-13 19:42 |
|
Note Added: 0038363 | |
| 2015-03-13 21:51 | kgv | Note Added: 0038364 | |
| 2015-03-17 13:08 |
|
Note Added: 0038424 | |
| 2015-03-17 13:08 |
|
Assigned To | san => bugmaster |
| 2015-03-17 13:08 |
|
Status | resolved => reviewed |
| 2015-03-17 14:35 |
|
Assigned To | bugmaster => mkv |
| 2015-03-18 14:45 | git | Note Added: 0038640 | |
| 2015-03-18 14:46 |
|
Note Added: 0038641 | |
| 2015-03-18 14:46 |
|
Assigned To | mkv => bugmaster |
| 2015-03-18 14:46 |
|
Status | reviewed => tested |
| 2015-03-18 14:46 |
|
Test case number | => Not needed |
| 2015-03-20 13:34 | bugmaster | Changeset attached | => occt master 36132a2e |
| 2015-03-20 13:34 | bugmaster | Status | tested => verified |
| 2015-03-20 13:34 | bugmaster | Resolution | open => fixed |
| 2015-04-09 09:49 | git | Note Added: 0039447 | |
| 2015-05-14 15:28 |
|
Status | verified => closed |
| 2015-05-14 15:31 |
|
Fixed in Version | => 6.9.0 |
