View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0025698CommunityOCCT:Modeling Algorithmspublic2015-01-12 18:432021-12-13 14:59
ReporterIstvan Csanady Assigned Tobugmaster  
PrioritynormalSeverityfeature 
Status closedResolutionduplicate 
Target Version7.6.0 
Summary0025698: Modeling Algorithms - Implementation of progress feedback in pave filler
DescriptionProgress indication is not implemented in BOPAlgo_PaveFiller. I created an implementation. See the attached patch.
Steps To ReproduceNot needed.
TagsNo tags attached.
Test case number

Attached Files

  • patch.diff (3,522 bytes)
  • patch2.diff (843 bytes)

Relationships

related to 0025748 closedabv Open CASCADE Foundation Classes - Parallel version of progress indicator 

Activities

Istvan Csanady

2015-01-12 18:43

developer  

patch.diff (3,522 bytes)

Istvan Csanady

2015-01-12 18:57

developer  

patch2.diff (843 bytes)

Istvan Csanady

2015-01-12 18:57

developer   ~0035978

Both patches needed.

git

2015-04-09 15:32

administrator   ~0039501

Branch CR25698 has been created by msv.

SHA-1: b0e6fe32e260d7115f60f70cf7d95e7df6102989


Detailed log of new commits:

Author: Istvan Csanady
Date: Mon Jan 12 16:40:00 2015 +0100

    0025698: Implementation of progress feedback in pave filler

msv

2015-04-09 15:34

developer   ~0039502

Dear pkv, please review the branch CR25698.

pkv

2015-04-14 09:02

developer   ~0039665

Last edited: 2015-04-17 10:02

 1. Replace the pieces of code
...
 if (!myProgressIndicator.IsNull()) {
    myProgressIndicator->NewScope(100.0);
    myProgressIndicator->SetStep(100.0 / 16.0);
  }
,,,
if (!myProgressIndicator.IsNull()) {
    myProgressIndicator->Increment();
  }
...
 if (!myProgressIndicator.IsNull()) {
    myProgressIndicator->Increment();
    myProgressIndicator->EndScope();
  }
 ...
by methods that control the indicator. Say,

BOPAlgo_PaveFiller::IndicatorStart ()
BOPAlgo_PaveFiller::IndicatorIncrement ()
BOPAlgo_PaveFiller::IndicatorStop ().

Place the methods in a separate file [say BOPAlgo_PaveFiller_11.cxx]
The reasons:
- keep the one functionality in one place is easy to maintain and modify
- keep the control program out of details

2. Why the steps
 myDS->UpdatePaveBlocks(); RefineFaceInfoOn();
are out of IndicatorIncrement ()

3. Why the all steps have equal complexity?
The complexity of a step depends on data.
It would be nice to have the analysis of data inside the code.
The analysis will allow to distribute the complexity of steps more correctly

4. It will be good to have a test command and several test cases
to see how it works. These tools are absolutely necessary to identify
the problems associated with Progress Indicator in context of
BOPAlgo_PaveFiller:
- The Draw command is needed.
- Steps To Reproduce is needed.
- Test cases are needed.

msv

2015-04-15 12:09

developer   ~0039762

Dear pkv, I see that this task is not so simple as seemed. So, please, put it in your list of tasks.

abv

2020-09-18 21:52

manager   ~0095056

The issue shall be reconsidered following integration of 0025748

msv

2021-08-29 19:14

developer   ~0103516

This issue will be fixed with "21264 - Progress indicator for Boolean operations".

msv

2021-08-29 19:15

developer   ~0103517

Please close this bug as duplicate of #21264.

git

2021-12-13 14:59

administrator   ~0105893

Branch CR25698 has been deleted by kgv.

SHA-1: b0e6fe32e260d7115f60f70cf7d95e7df6102989

Issue History

Date Modified Username Field Change
2015-01-12 18:43 Istvan Csanady New Issue
2015-01-12 18:43 Istvan Csanady Assigned To => msv
2015-01-12 18:43 Istvan Csanady File Added: patch.diff
2015-01-12 18:57 Istvan Csanady File Added: patch2.diff
2015-01-12 18:57 Istvan Csanady Note Added: 0035978
2015-04-09 15:32 git Note Added: 0039501
2015-04-09 15:32 msv Status new => assigned
2015-04-09 15:34 msv Note Added: 0039502
2015-04-09 15:34 msv Assigned To msv => pkv
2015-04-09 15:34 msv Status assigned => resolved
2015-04-09 15:34 msv Steps to Reproduce Updated
2015-04-14 09:02 pkv Note Added: 0039665
2015-04-14 09:03 pkv Assigned To pkv => msv
2015-04-14 09:03 pkv Status resolved => assigned
2015-04-15 12:07 msv Assigned To msv => pkv
2015-04-15 12:09 msv Note Added: 0039762
2015-04-15 12:09 msv Target Version 6.9.0 => 7.1.0
2015-04-17 10:02 pkv Note Edited: 0039665
2016-10-28 18:56 msv Assigned To pkv => msv
2016-10-28 18:56 msv Target Version 7.1.0 => 7.2.0
2017-07-21 11:22 msv Target Version 7.2.0 => 7.3.0
2017-12-05 17:09 msv Target Version 7.3.0 => 7.4.0
2019-08-12 16:44 msv Target Version 7.4.0 => 7.5.0
2020-09-14 22:55 msv Target Version 7.5.0 => 7.6.0
2020-09-18 21:48 abv Relationship added related to 0025748
2020-09-18 21:52 abv Note Added: 0095056
2020-09-18 21:54 abv Assigned To msv => emv
2020-11-18 11:44 kgv Summary Implementation of progress feedback in pave filler => Modeling Algorithms - Implementation of progress feedback in pave filler
2020-11-18 11:44 kgv Severity minor => feature
2021-03-05 11:23 szy Assigned To emv => akaftasev
2021-08-29 19:14 msv Note Added: 0103516
2021-08-29 19:15 msv Note Added: 0103517
2021-08-29 19:15 msv Assigned To akaftasev => bugmaster
2021-08-29 19:15 msv Status assigned => feedback
2021-08-29 19:15 msv Resolution open => duplicate
2021-09-03 14:09 bugmaster Status feedback => closed
2021-12-13 14:59 git Note Added: 0105893