View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0025649Open CASCADEOCCT:Modeling Datapublic2014-12-23 09:452016-12-09 16:39
ReporteramlAssigned Tobugmaster  
PriorityhighSeverityblock 
Status closedResolutionfixed 
Product Version6.8.0 
Target Version7.1.0Fixed in Version7.1.0 
Summary0025649: crvtpoints command return wrong deflection in output.
DescriptionThis bug was founded in scope of CR25489.

Wrong deflection computation caused by two facts:

1) Usage of ExtremaCC, which compute only minimum, but we need to get maximum.
2) Solving two-dimensional task, on which term "maximum", not well-defined.

It is necessary to change deflection computation as follows:
Solve one-dimensional optimization task, with the same parameter on first and second curves. Search maximum 3d distance.

This approach is not good.

See note 50478 by IFV
Steps To ReproduceSame for CR25489.
TagsNo tags attached.
Test case numberNot needed

Activities

git

2014-12-23 10:23

administrator   ~0035585

Branch CR25649 has been created by aml.

SHA-1: 20131be9f099a9f448de09af4b8cf88080dbcfe3


Detailed log of new commits:

Author: aml
Date: Tue Dec 23 10:21:23 2014 +0300

    0025649: crvtpoints command return wrong deflection in output.
    
    Deflection computation algorithm changed to PSO+NewtonMinimum.

aml

2014-12-23 10:25

developer   ~0035586

Dear abv,
Please check current state of branch CR25649.

git

2014-12-23 16:21

administrator   ~0035608

Branch CR25649 has been updated forcibly by aml.

SHA-1: d7b2608a9bdaa07bed6f942746693d66ed87e3c4

msv

2014-12-23 16:31

developer   ~0035611

In function ComputeDeviation, please, move sqrt out of the cycle. Call it one time just before return.

git

2014-12-24 07:36

administrator   ~0035639

Branch CR25649 has been updated forcibly by aml.

SHA-1: 91ac92b59bee685e1960adb207edd2adef73bb17

aml

2014-12-24 07:40

developer   ~0035640

Dear msv,
Square root moved to improve performance, please check updated branch CR25649.

msv

2014-12-24 09:40

developer   ~0035646

OK.

mkv

2014-12-25 14:48

tester   ~0035716

Dear BugMaster,
Branch CR25649 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 91ac92b59bee685e1960adb207edd2adef73bb17

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
http://occt-tests.nnov.opencascade.com/CR25649-master-occt/Debian60-64/bugs/moddata_3/bug25207.html
http://occt-tests.nnov.opencascade.com/CR25649-master-occt/Windows-32-VC10/bugs/moddata_3/bug25207.html
bugs moddata_3(013) bug25207: FAILED

Testing cases:


Testing on Linux:
occt component :
Total MEMORY difference: 367677188 / 367852280
Total CPU difference: 51144.39000000015 / 51427.550000000156
products component :
Total MEMORY difference: 112592316 / 112513828
Total CPU difference: 16439.88999999997 / 16879.77999999998

Testing on Windows:
occt component :
Total MEMORY difference: 277633612 / 277262960
Total CPU difference: 38371.75 / 37455.2498257
products component :
Total MEMORY difference: 72380008 / 71382268
Total CPU difference: 12073.90625 / 10342.656534399997

There are no differences in images found by testdiff.

aml

2014-12-26 07:39

developer   ~0035741

Dear mkv,
"moddata_3(013) bug25207" is correct, please update this testcase to new behavior.

git

2015-01-15 14:38

administrator   ~0036105

Branch CR25649 has been updated by mkv.

SHA-1: 974f71031e2dd675637c57d9c6dc2cae6b1c33c2


Detailed log of new commits:

Author: mkv
Date: Thu Jan 15 14:38:01 2015 +0300

    Correction of test case

mkv

2015-01-15 14:39

tester   ~0036106

Branch CR25649 is TESTED.

git

2015-01-26 12:32

administrator   ~0036521

Branch CR25649 has been deleted by inv.

SHA-1: 974f71031e2dd675637c57d9c6dc2cae6b1c33c2

ifv

2016-02-08 14:56

developer   ~0050478

crvtpoints command still returns wrong deflection in output.

One of basic assumptions used for algorithm :
" ...with the same parameter on first and second curves" causes to wrong calculation of maximal deflection between curve and its chord between two consecutive points, because vector (POnCurve-POnChord) calculated for the same parameter is not perpendicular to chord.
Since maximal deflection is used in test, algorithm of deflection calculation:
F = -myCurve->Value(X(1)).SquareDistance(myPnts->Value(X(1)));
must be corrected

ifv

2016-11-23 11:41

developer   ~0060716

This issue must be closed, because problem has been fixed in issue #27108

msv

2016-11-23 15:47

developer   ~0060732

I agree.
Dear bugmaster, please close this bug.
No test case is needed.

Related Changesets

occt: master edbf88ba

2015-01-15 12:37:10

aml


Committer: bugmaster Details Diff		 0025649: crvtpoints command return wrong deflection in output.

Deflection computation algorithm changed to PSO+NewtonMinimum.

Correction of test case		 Affected Issues
0025649
mod - src/GeometryTest/GeometryTest_CurveCommands.cxx Diff File
mod - tests/bugs/moddata_3/bug25207 Diff File

Issue History

Date Modified Username Field Change
2014-12-23 09:45 aml New Issue
2014-12-23 09:45 aml Assigned To => aml
2014-12-23 10:23 git Note Added: 0035585
2014-12-23 10:25 aml Note Added: 0035586
2014-12-23 10:25 aml Assigned To aml => abv
2014-12-23 10:25 aml Status new => resolved
2014-12-23 11:52 abv Assigned To abv => msv
2014-12-23 16:21 git Note Added: 0035608
2014-12-23 16:31 msv Note Added: 0035611
2014-12-23 16:31 msv Assigned To msv => aml
2014-12-23 16:31 msv Status resolved => assigned
2014-12-24 07:36 git Note Added: 0035639
2014-12-24 07:40 aml Note Added: 0035640
2014-12-24 07:40 aml Assigned To aml => msv
2014-12-24 07:40 aml Status assigned => resolved
2014-12-24 09:40 msv Note Added: 0035646
2014-12-24 09:40 msv Assigned To msv => bugmaster
2014-12-24 09:40 msv Status resolved => reviewed
2014-12-24 11:19 mkv Assigned To bugmaster => mkv
2014-12-25 14:48 mkv Note Added: 0035716
2014-12-25 14:48 mkv Assigned To mkv => aml
2014-12-25 14:48 mkv Status reviewed => assigned
2014-12-26 07:39 aml Note Added: 0035741
2014-12-26 07:39 aml Assigned To aml => mkv
2014-12-26 07:39 aml Status assigned => feedback
2015-01-15 14:38 git Note Added: 0036105
2015-01-15 14:39 mkv Note Added: 0036106
2015-01-15 14:39 mkv Assigned To mkv => bugmaster
2015-01-15 14:39 mkv Status feedback => tested
2015-01-15 14:40 mkv Test case number => Not needed
2015-01-16 13:37 bugmaster Changeset attached => occt master edbf88ba
2015-01-16 13:37 bugmaster Status tested => verified
2015-01-16 13:37 bugmaster Resolution open => fixed
2015-01-26 12:32 git Note Added: 0036521
2015-05-14 15:29 aiv Status verified => closed
2015-05-14 15:33 aiv Fixed in Version => 6.9.0
2016-02-08 14:56 ifv Assigned To bugmaster => aml
2016-02-08 14:56 ifv Note Added: 0050478
2016-02-08 14:56 ifv Status closed => feedback
2016-02-08 14:56 ifv Resolution fixed => reopened
2016-02-18 12:05 ifv Assigned To aml => msv
2016-02-18 12:05 ifv Status feedback => assigned
2016-02-18 12:08 ifv Priority normal => high
2016-02-18 12:08 ifv Severity minor => block
2016-02-18 12:11 ifv Description Updated
2016-02-18 12:51 msv Assigned To msv => ifv
2016-02-18 12:51 msv Target Version 6.9.0 => 7.1.0
2016-10-25 15:51 msv Target Version 7.1.0 => 7.2.0
2016-11-23 11:41 ifv Note Added: 0060716
2016-11-23 11:41 ifv Assigned To ifv => msv
2016-11-23 11:41 ifv Status assigned => resolved
2016-11-23 15:47 msv Note Added: 0060732
2016-11-23 15:47 msv Assigned To msv => bugmaster
2016-11-23 15:47 msv Status resolved => feedback
2016-11-23 18:45 abv Fixed in Version 6.9.0 =>
2016-11-23 18:45 abv Target Version 7.2.0 => 7.1.0
2016-11-23 18:49 apn Status feedback => tested
2016-11-23 18:49 apn Resolution reopened => fixed
2016-11-23 18:49 apn Status tested => verified
2016-12-09 16:30 aiv Status verified => closed
2016-12-09 16:39 aiv Fixed in Version => 7.1.0