0025511: Visualization - drop redundant viewer option V3d_View::Transparency()

ID	Project	Category	View Status	Date Submitted	Last Update

0025511	Open CASCADE	OCCT:Visualization	public	2014-11-22 16:33	2015-05-14 15:32

Reporter	kgv	Assigned To	bugmaster
Priority	normal	Severity	integration request
Status	closed	Resolution	fixed
Target Version	6.9.0	Fixed in Version	6.9.0

Summary	0025511: Visualization - drop redundant viewer option V3d_View::Transparency()
Description	These flags disable specific viewer features (texturing, alpha blending) to improve performance. But globally disabling such features leads just to confusion - it does not make much sense to display object without explicitly assigned aspects.
Tags	No tags attached.

Test case number	Not needed

git 2014-11-22 16:59 administrator ~0034618	Branch CR25511 has been created by kgv. SHA-1: 66129a0ebf476fe1ba57264590e2c0bd9f8b09b8 Detailed log of new commits: Author: kgv Date: Sat Nov 22 16:57:40 2014 +0300 Drop V3d_View::SurfaceDetail() flag. Author: kgv Date: Sat Nov 22 16:33:37 2014 +0300 0025511: Visualization - drop confusing viewer options V3d_View::SurfaceDetail() and V3d_View::Transparency() Drop V3d_View::Transparency() flag.

kgv 2014-11-22 17:00 developer ~0034619	Patch is ready for review in branch CR25511.

~~san~~ 2014-11-27 19:30 developer ~0034774	Branch CR25511 reviewed in occt and products repositories, ready for testing.

git 2014-11-27 20:04 administrator ~0034776	Branch CR25511 has been updated forcibly by mkv. SHA-1: 68a6d16de54af3a4b3bb4909019b861de0dc8651

~~mkv~~ 2014-11-28 11:10 tester ~0034787	Dear BugMaster, Branch CR25511 from occt git-repository and branch CR25511from products git-repository were compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: 68a6d16de54af3a4b3bb4909019b861de0dc8651 SHA-1: 35180d956745bae09e9e39315e7948e00e19aa90 Number of compiler warnings: occt component : Linux: 18 (18 on master) Windows: 0 (0 on master) products component : Linux: 11 (11 on master) Windows: 1 (1 on master) Also, there are compilation errors on Samples: http://jenkins-test-03.nnov.opencascade.com:8080/user/mnt/my-views/view/CR25511/job/mnt-CR25511-CR25511_build_occt_qt_samples_window/1/parsed_console/ 1>..\Common\src\DocumentCommon.cxx(51): error C2065: 'V3d_TEX_NONE' : undeclared identifier ... 1>src\Viewer.cpp(37): error C2065: 'V3d_TEX_NONE' : undeclared identifier http://jenkins-test-03.nnov.opencascade.com:8080/user/mnt/my-views/view/CR25511/job/mnt-CR25511-CR25511_build_products_qt_samples_windows/1/parsed_console/ 1>..\..\..\..\CR25511-CR25511-occt\samples\qt\Common\src\DocumentCommon.cxx(51): error C2065: 'V3d_TEX_NONE' : undeclared identifier ... Regressions/Differences: No regressions/differences Testing cases: Not needed Testing on Linux: occt component : Total MEMORY difference: 359652920 / 359401644 Total CPU difference: 47574.99000000019 / 47866.179999999826 products component : Total MEMORY difference: 112623036 / 112959220 Total CPU difference: 16900.699999999983 / 16211.999999999969 Testing on Windows: occt component : Total MEMORY difference: 273142740 / 273727588 Total CPU difference: 43580.703125 / 40219.09375 products component : Total MEMORY difference: 72275712 / 71122820 Total CPU difference: 10973.0625 / 11101.078125 There are following differences in images found by testdiff. http://occt-tests.nnov.opencascade.com/CR25511-CR25511-occt/Debian60-64/diff-Debian60-64.html http://occt-tests.nnov.opencascade.com/CR25511-CR25511-occt/Windows-32-VC10/diff-Windows-32-VC10.html IMAGE v3d materials bug24872_1: bug24872_1.png differs IMAGE v3d materials bug24855: bug24855.png differs IMAGE demo samples materials: materials.png differs IMAGE bugs vis bug23747_1: bug23747_1_with_envmap.png differs IMAGE bugs vis bug23747_2: bug23747_2_std_texture_1.png differs IMAGE bugs vis bug23747_2: bug23747_2_modulate.png differs IMAGE bugs vis bug23747_2: bug23747_2_rotated.png differs IMAGE bugs vis bug23747_2: bug23747_2_std_texture_5.png differs IMAGE bugs vis bug23747_2: bug23747_2_translated.png differs IMAGE bugs vis bug23747_2: bug23747_2_std_texture_7.png differs IMAGE bugs vis bug23747_2: bug23747_2_std_texture_4.png differs IMAGE bugs vis bug23747_2: bug23747_2_std_texture_3.png differs IMAGE bugs vis bug23747_2: bug23747_2_std_texture_2.png differs IMAGE bugs vis bug23747_2: bug23747_2_std_texture_0.png differs IMAGE bugs vis bug23747_2: bug23747_2_scaled.png differs IMAGE bugs vis bug23747_2: bug23747_2_std_texture_6.png differs IMAGE bugs vis bug23747_2: bug23747_2_nearest.png differs

git 2014-11-28 15:54 administrator ~0034838	Branch CR25511_1 has been created by kgv. SHA-1: 89502336d34195f3a3b4f4b4822b06f74bbc5861 Detailed log of new commits: Author: kgv Date: Fri Nov 28 15:54:12 2014 +0300 0025511: Visualization - drop redundant viewer option V3d_View::Transparency() Visual3d_ViewManager, activate texturing by default.

kgv 2014-11-28 15:56 developer ~0034840	Updated patch in branch removes only V3d_View::Transparency() flag and activates texturing by default. Patch for products is not needed.

~~mkv~~ 2014-12-01 14:50 tester ~0034883	Dear BugMaster, Branch CR25511_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: 89502336d34195f3a3b4f4b4822b06f74bbc5861 Number of compiler warnings: occt component : Linux: 18 (18 on master) Windows: 0 (0 on master) products component : Linux: 11 (11 on master) Windows: 1 (1 on master) Regressions/Differences: No regressions/differences Testing cases: Not needed Testing on Linux: occt component : Total MEMORY difference: 359813976 / 359261588 Total CPU difference: 45416.150000000045 / 47823.01999999983 products component : Total MEMORY difference: 113178408 / 113157556 Total CPU difference: 15400.019999999995 / 16331.719999999976 Testing on Windows: occt component : Total MEMORY difference: 273520492 / 273727588 Total CPU difference: 46058.96875 / 40219.09375 products component : Total MEMORY difference: 72099788 / 71101716 Total CPU difference: 12769.921875 / 11100.453125 There are no differences in images found by testdiff.

~~mkv~~ 2014-12-02 15:21 tester ~0034925	Dear BugMaster, there is compilation error in Qt Samples Window: http://jenkins-test-03.nnov.opencascade.com:8080/user/mnt/my-views/view/CR25511_1/job/mnt-CR25511_1-master_build_occt_qt_samples_window/2/parsed_console/ 1>src\Viewer.cpp(54): error C2039: 'SetTransparency' : is not a member of 'V3d_View' 1> d:\builds\vc10\CR25511-1-master-occt\inc\V3d_View.hxx(121) : see declaration of 'V3d_View'

git 2014-12-02 15:31 administrator ~0034926	Branch CR25511_1 has been updated by kgv. SHA-1: 27892afaea856542283df81c314ff81e28b88f8b Detailed log of new commits: Author: kgv Date: Tue Dec 2 15:31:12 2014 +0300 Update Qt sample

kgv 2014-12-02 15:32 developer ~0034927	The Qt sample has been corrected - please check updated branch.

~~mkv~~ 2014-12-02 19:00 tester ~0034939	Dear BugMaster, there is not compilation error in Qt Samples Window now. CR25511_1 is TESTED.

git 2015-01-26 12:36 administrator ~0036604	Branch CR25511_1 has been deleted by inv. SHA-1: 27892afaea856542283df81c314ff81e28b88f8b

git 2015-01-26 12:37 administrator ~0036611	Branch CR25511 has been deleted by inv. SHA-1: 68a6d16de54af3a4b3bb4909019b861de0dc8651

occt: master a6964ce6 2014-12-04 11:52:49 kgv Committer: bugmaster Details Diff	0025511: Visualization - drop redundant viewer option V3d_View::Transparency() Visual3d_ViewManager, activate texturing by default. Update Qt sample	Affected Issues 0025511
	mod - samples/qt/VoxelDemo/src/Viewer.cpp	Diff File
	mod - src/AIS/AIS_InteractiveContext.cxx	Diff File
	mod - src/Graphic3d/Graphic3d_GraphicDriver.cdl	Diff File
	mod - src/OpenGl/OpenGl_GraphicDriver.hxx	Diff File
	mod - src/OpenGl/OpenGl_GraphicDriver_7.cxx	Diff File
	mod - src/OpenGl/OpenGl_View.cxx	Diff File
	mod - src/OpenGl/OpenGl_Workspace.cxx	Diff File
	mod - src/OpenGl/OpenGl_Workspace.hxx	Diff File
	mod - src/OpenGl/OpenGl_Workspace_5.cxx	Diff File
	mod - src/V3d/V3d_Plane.cxx	Diff File
	mod - src/V3d/V3d_View.cdl	Diff File
	mod - src/V3d/V3d_View.cxx	Diff File
	mod - src/V3d/V3d_View_2.cxx	Diff File
	mod - src/Visual3d/Visual3d_ContextView.cxx	Diff File
	mod - src/Visual3d/Visual3d_View.cdl	Diff File
	mod - src/Visual3d/Visual3d_View.cxx	Diff File
	mod - src/Visual3d/Visual3d_ViewManager.cdl	Diff File
	mod - src/Visual3d/Visual3d_ViewManager.cxx	Diff File

Date Modified	Username	Field	Change
2014-11-22 16:33	kgv	New Issue
2014-11-22 16:33	kgv	Assigned To	=> kgv
2014-11-22 16:59	git	Note Added: 0034618
2014-11-22 17:00	kgv	Note Added: 0034619
2014-11-22 17:00	kgv	Assigned To	kgv => san
2014-11-22 17:00	kgv	Status	new => resolved
2014-11-27 15:47	kgv	Relationship added	related to 0025459
2014-11-27 15:48	kgv	Relationship added	related to 0023387
2014-11-27 19:30	~~san~~	Note Added: 0034774
2014-11-27 19:30	~~san~~	Assigned To	san => bugmaster
2014-11-27 19:30	~~san~~	Status	resolved => reviewed
2014-11-27 19:37	~~mkv~~	Assigned To	bugmaster => mkv
2014-11-27 20:04	git	Note Added: 0034776
2014-11-28 11:10	~~mkv~~	Note Added: 0034787
2014-11-28 11:10	~~mkv~~	Assigned To	mkv => kgv
2014-11-28 11:10	~~mkv~~	Status	reviewed => assigned
2014-11-28 15:49	kgv	Summary	Visualization - drop confusing viewer options V3d_View::SurfaceDetail() and V3d_View::Transparency() => Visualization - drop redundant viewer option V3d_View::Transparency()
2014-11-28 15:54	git	Note Added: 0034838
2014-11-28 15:56	kgv	Note Added: 0034840
2014-11-28 15:56	kgv	Assigned To	kgv => bugmaster
2014-11-28 15:56	kgv	Status	assigned => resolved
2014-11-28 15:56	kgv	Status	resolved => reviewed
2014-11-28 16:15	~~mkv~~	Assigned To	bugmaster => mkv
2014-12-01 14:50	~~mkv~~	Note Added: 0034883
2014-12-01 14:50	~~mkv~~	Test case number	=> Not needed
2014-12-01 14:50	~~mkv~~	Assigned To	mkv => bugmaster
2014-12-01 14:50	~~mkv~~	Status	reviewed => tested
2014-12-02 15:21	~~mkv~~	Note Added: 0034925
2014-12-02 15:21	~~mkv~~	Assigned To	bugmaster => kgv
2014-12-02 15:21	~~mkv~~	Status	tested => assigned
2014-12-02 15:31	git	Note Added: 0034926
2014-12-02 15:32	kgv	Note Added: 0034927
2014-12-02 15:32	kgv	Assigned To	kgv => bugmaster
2014-12-02 15:32	kgv	Status	assigned => resolved
2014-12-02 15:32	kgv	Status	resolved => reviewed
2014-12-02 15:37	~~mkv~~	Assigned To	bugmaster => mkv
2014-12-02 19:00	~~mkv~~	Note Added: 0034939
2014-12-02 19:00	~~mkv~~	Assigned To	mkv => bugmaster
2014-12-02 19:00	~~mkv~~	Status	reviewed => tested
2014-12-05 14:42	bugmaster	Changeset attached	=> occt master a6964ce6
2014-12-05 14:42	bugmaster	Status	tested => verified
2014-12-05 14:42	bugmaster	Resolution	open => fixed
2015-01-19 16:23	bugmaster	Target Version	7.1.0 => 6.9.0
2015-01-26 12:36	git	Note Added: 0036604
2015-01-26 12:37	git	Note Added: 0036611
2015-05-14 15:29	~~aiv~~	Status	verified => closed
2015-05-14 15:32	~~aiv~~	Fixed in Version	=> 6.9.0

View Issue Details

Relationships

Activities

Related Changesets

Issue History

related to	0025459	closed	bugmaster	Open CASCADE	Visualization - AIS_ColoredShape::SetMaterial() should not reset custom colors
related to	0023387	closed	bugmaster	Community	Visualization - transparency of specified material is ignored within AIS_Shape::SetMaterial()