View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0025439||Community||OCCT:Modeling Data||public||2014-10-31 16:37||2014-11-12 09:55|
|Reporter||Roman Lygin||Assigned To||bugmaster|
|Target Version||6.8.0||Fixed in Version||6.8.0|
|Summary||0025439: Enabling shape binary persistence without OCAF|
|Description||The fix moves BinTools to TKBRep from TKBin.|
In itself, BinTools provides binary persistence of topology and geometry, and is similar to BRepTools which provides textual persistence.
Although currently it is only used in OCAF binary persistence, binary shape persistence can be useful for OCAF-less user applications.
The increased file size of TKBRep should be negligible, approximately ~100KB in release mode.
From architectural standpoint BRepTools and BinTools would deserve a refactoring and having a common writer and two different formatters (text and binary), thus following the Builder pattern. Same for reader & parsers. This could reduce code duplication and size. But this is beyond this simple integration request just to put BinTools to TKBRep.
and documentation updates
|As no documentation or DRAW commands have been explicitly used for binary persistence of shapes, they are not affected within the scope of this change request. This can be done later if needed.|
|Tags||No tags attached.|
|Test case number||Not needed|
Branch CR25439 has been created by Roman Lygin.
Detailed log of new commits:
Author: Roman Lygin
Date: Fri Oct 31 16:40:03 2014 +0400
0025439: Enabling shape binary persistence without OCAF
||The fix has been pushed to the git repository.|
||No remarks, please check build and integrate|
Branch CR25439 has been updated forcibly by apv.
Branch CR25439 (and products from GIT master) was compiled on Linux, MacOS and Windows platforms and tested.
Number of compiler warnings:
Linux: 18 (18 on master)
Windows: 0 (0 on master)
Linux: 11 (11 on master)
Windows: 1 (1 on master)
Branch CR25439 has been deleted by inv.
|2014-10-31 16:37||Roman Lygin||New Issue|
|2014-10-31 16:37||Roman Lygin||Assigned To||=> abv|
|2014-10-31 16:42||git||Note Added: 0033963|
|2014-10-31 16:42||Roman Lygin||Note Added: 0033964|
|2014-10-31 16:42||Roman Lygin||Status||new => resolved|
|2014-10-31 16:45||abv||Note Added: 0033965|
|2014-10-31 16:45||abv||Assigned To||abv => bugmaster|
|2014-10-31 16:45||abv||Status||resolved => reviewed|
||Assigned To||bugmaster => apv|
||Test case number||=> Not needed|
|2014-10-31 19:35||git||Note Added: 0033991|
||Note Added: 0034026|
||Assigned To||apv => bugmaster|
||Status||reviewed => tested|
|2014-11-06 16:15||bugmaster||Changeset attached||=> occt master 2dc8b7cc|
|2014-11-06 16:15||bugmaster||Status||tested => verified|
|2014-11-06 16:15||bugmaster||Resolution||open => fixed|
||Fixed in Version||=> 6.8.0|
||Status||verified => closed|
|2014-11-12 09:55||git||Note Added: 0034348|