View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0025310 | Open CASCADE | OCCT:Mesh | public | 2014-10-01 14:03 | 2014-11-11 13:01 |
| Reporter | Assigned To | bugmaster | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.8.0 | ||||
| Target Version | 6.8.0 | Fixed in Version | 6.8.0 | ||
| Summary | 0025310: Keeping temporary data structures in BRepMesh_FaceAttribute leads to out-of-memory exception | ||||
| Description | After refactoring of BRepMesh package in context of 0023106 issue, BRepMesh_FaceAttribute is supposed to keep all calculated mesh data for further storing it into the target shape in a single place. However, in case of shapes with huge number of faces, especially based on BSpline surfaces, attributes map consumes a lot of memory and leads to out-of-memory exception. It is necessary to divide storing of mesh data into a particular face on two steps: - store surface tesselation directly after processing of a face and clean temporary data structures; - store shared boundary tesselation when all faces are processed to avoid data races. Problem can be reproduced using the following test cases (see steps to reproduce): - test bugs modalg_5 bug25232_9 ("vdisplay result" kills Draw in release mode as well as "vsetdispmode 1" in debug); - test perf bop buildfaces (shapes are not displayed in 3d viewer). | ||||
| Steps To Reproduce | # debug mode test perf bop buildfaces vinit View1 chrono t reset; chrono t start; vdisplay rp chrono t stop; chrono t show # Elapsed time: 0 Hours 10 Minutes 20.0895829143 Seconds # CPU user time: 614.6283399 seconds # CPU system time: 2.5740165 seconds vsetdispmode 1 # it does not changes the view mode for the shape rp test bugs modalg_5 bug25232_9 vinit View1 vdisplay result vsetdispmode 1 | ||||
| Tags | No tags attached. | ||||
| Test case number | bugs modalg_5(010) bug25232_9; perf bop(018) buildfaces | ||||
|
|
Brunch CR23106M is a ready to be reviewed. |
|
|
Please review new modification of brunch CR23106M. |
|
|
Branch CR25310 has been created by azn. SHA-1: 4cbb23d3e166bcb2b83e29ee6bd2e5e9e8f3e697 No new revisions were added by this update. |
|
|
Branch CR25310 has been updated forcibly by azn. SHA-1: de5b3a84fdff4e7e18a95b17606247f80fe954fa |
|
|
Branch CR25310 has been updated forcibly by azn. SHA-1: 972772b1e9d544d1ace446ab9da3677f84872f53 |
|
|
Reviewed, please test. |
|
|
Dear BugMaster, Branch CR25310 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: 972772b1e9d544d1ace446ab9da3677f84872f53 Number of compiler warnings: occt component : Linux: 15 (15 on master) Windows: 0 (0 on master) MacOS: 199 (199 on master) products component : Linux: 11 (11 on master) Windows: 1 (1 on master) Regressions/Differences: No regressions/differences Testing cases: http://occt-tests/CR25310-master-occt/Debian60-64/bugs/modalg_5/bug25232_9.html bugs modalg_5(010) bug25232_9: OK http://occt-tests/CR25310-master-occt/Windows-32-VC10/bugs/modalg_5/bug25232_9.html bugs modalg_5(010) bug25232_9: FAILED http://occt-tests/CR25310-master-occt/Windows-32-VC10/perf/bop/buildfaces.html http://occt-tests/CR25310-master-occt/Debian60-64/perf/bop/buildfaces.html perf bop(018) buildfaces: OK Testing on Linux: occt component : Total MEMORY difference: 368450708 / 397911416 Total CPU difference: 48266.01000000008 / 47179.31000000023 products component : Total MEMORY difference: 119289776 / 128595660 Total CPU difference: 17971.799999999967 / 17743.32999999997 Testing on Windows: occt component : Total MEMORY difference: 273487600 / 278279728 Total CPU difference: 35626.421875 / 32988.78125 products component : Total MEMORY difference: 70587272 / 69892128 Total CPU difference: 10709.125 / 10861.0625 There are no differences in images found by testdiff. |
|
|
Dear BugMaster, Branch CR25310 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Debug mode. Regressions/Differences: http://occt-tests/CR25310-master-occt-deb/Debian60-64/summary.html http://occt-tests/CR25310-master-occt-deb/Windows-32-VC10/summary.html bugs modalg_5(010) bug24981 - only on Linux platform Debug messages: http://occt-tests/CR25310-master-products-deb/Debian60-64/summary.html http://occt-tests/CR25310-master-products-deb/Windows-32-VC10/summary.html Testing cases: http://occt-tests/CR25310-master-occt-deb/Debian60-64/bugs/modalg_5/bug25232_9.html bugs modalg_5(010) bug25232_9: OK http://occt-tests/CR25310-master-occt-deb/Windows-32-VC10/bugs/modalg_5/bug25232_9.html bugs modalg_5(010) bug25232_9: FAILED http://occt-tests/CR25310-master-occt-deb/Debian60-64/perf/bop/buildfaces.html http://occt-tests/CR25310-master-occt-deb/Windows-32-VC10/perf/bop/buildfaces.html perf bop(018) buildfaces: OK Testing on Linux: occt component : Total MEMORY difference: 440476032 / 469603788 Total CPU difference: 163420.8499999999 / 160493.2000000001 products component : Total MEMORY difference: 138066936 / 145585436 Total CPU difference: 36432.84999999999 / 36147.12000000002 Testing on Windows: occt component : Total MEMORY difference: 363717808 / 374276228 Total CPU difference: 93024.59375 / 97005.453125 products component : Total MEMORY difference: 91943988 / 92932980 Total CPU difference: 25430.234375 / 26448.96875 There are no differences in images found by testdiff. |
|
|
Please re-check the above mentioned regressions in Debug mode on current master, which already contains fix for 0025310. At least test bugs modalg_5 bug25232_9 seems to be Ok on Windows now. |
|
|
Branch CR25310 has been deleted by inv. SHA-1: 972772b1e9d544d1ace446ab9da3677f84872f53 |
|
occt: master fcf15f5c 2014-10-08 10:57:22
Committer: bugmaster Details Diff |
0025310: Regressions in visualization - Memory management in the BRepMesh_FastDiscret class is changed. Now the unused face attributes is immediately removed. |
Affected Issues 0025310 |
|
| mod - src/BRepMesh/BRepMesh_FaceAttribute.cxx | Diff File | ||
| mod - src/BRepMesh/BRepMesh_FaceAttribute.hxx | Diff File | ||
| mod - src/BRepMesh/BRepMesh_FastDiscret.cxx | Diff File | ||
| mod - src/BRepMesh/BRepMesh_FastDiscret.hxx | Diff File | ||
| mod - src/BRepMesh/BRepMesh_FastDiscretFace.cxx | Diff File | ||
| mod - src/BRepMesh/BRepMesh_FastDiscretFace.hxx | Diff File | ||
| mod - src/BRepMesh/BRepMesh_IncrementalMesh.cxx | Diff File | ||
| mod - src/BRepMesh/BRepMesh_IncrementalMesh.hxx | Diff File | ||
| mod - src/MeshTest/MeshTest.cxx | Diff File | ||
| mod - src/MeshTest/MeshTest_DrawableMesh.cxx | Diff File | ||
| mod - src/XSDRAWSTLVRML/XSDRAWSTLVRML_ToVRML.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-10-01 14:03 |
|
New Issue | |
| 2014-10-01 14:03 |
|
Assigned To | => kgv |
| 2014-10-01 14:05 |
|
Status | new => assigned |
| 2014-10-01 14:13 |
|
Relationship added | child of 0023106 |
| 2014-10-01 18:37 |
|
Assigned To | kgv => azn |
| 2014-10-06 13:13 | kgv | Category | OCCT:Visualization => OCCT:Mesh |
| 2014-10-08 15:00 |
|
Note Added: 0032818 | |
| 2014-10-08 15:00 |
|
Assigned To | azn => oan |
| 2014-10-08 18:58 |
|
Note Added: 0032836 | |
| 2014-10-08 18:58 |
|
Status | assigned => resolved |
| 2014-10-08 19:20 | git | Note Added: 0032838 | |
| 2014-10-09 18:37 | git | Note Added: 0032939 | |
| 2014-10-09 18:56 | git | Note Added: 0032947 | |
| 2014-10-09 19:00 | oan | Note Added: 0032949 | |
| 2014-10-09 19:00 | oan | Assigned To | oan => bugmaster |
| 2014-10-09 19:00 | oan | Status | resolved => reviewed |
| 2014-10-09 19:07 |
|
Assigned To | bugmaster => mkv |
| 2014-10-13 11:47 | oan | Summary | Regressions in visualization => Keeping temporary data structures in BRepMesh_FaceAttribute leads to out-of-memory exception |
| 2014-10-13 11:47 | oan | Description Updated | |
| 2014-10-13 11:48 | oan | Description Updated | |
| 2014-10-13 11:49 | oan | Description Updated | |
| 2014-10-13 11:51 | oan | Description Updated | |
| 2014-10-13 12:40 | oan | Relationship added | has duplicate 0025320 |
| 2014-10-13 17:52 | bugmaster | Changeset attached | => occt master fcf15f5c |
| 2014-10-13 17:52 | bugmaster | Assigned To | mkv => bugmaster |
| 2014-10-13 17:52 | bugmaster | Status | reviewed => verified |
| 2014-10-13 17:52 | bugmaster | Resolution | open => fixed |
| 2014-10-13 21:04 |
|
Note Added: 0033042 | |
| 2014-10-13 21:05 |
|
Note Added: 0033043 | |
| 2014-10-13 21:06 |
|
Note Edited: 0033043 | |
| 2014-10-13 21:07 |
|
Test case number | => bugs modalg_5(010) bug25232_9; perf bop(018) buildfaces |
| 2014-10-15 19:54 |
|
Note Added: 0033174 | |
| 2014-10-21 16:40 | git | Note Added: 0033409 | |
| 2014-11-11 12:43 |
|
Fixed in Version | => 6.8.0 |
| 2014-11-11 13:01 |
|
Status | verified => closed |
