MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0025171Community[OCCT] OCCT:Data Exchangepublic2014-08-20 14:162020-09-20 11:13
Reporterdrazmyslovich 
Assigned Tobugmaster 
PrioritynormalSeveritymajor 
StatusverifiedResolutionfixed 
PlatformWindowsOSVC++ 2010OS Version64 bit
Product Version[OCCT] 6.6.0 
Target Version[OCCT] 7.5.0Fixed in Version 
Summary0025171: Data Exchange, STEP Lexer - the strings with quote sign inside can't be properly lexed
DescriptionIn my case, I had a file generated by PRO/ENGINEER with some french words used as strings. Example: DESCRIPTIVE_REPRESENTATION_ITEM('MATIERE', 'Fil d'acier');
The current STEP lexer can't properly handle this situation and the application refuses to parse a file at all.
Steps To ReproduceReadStep D c:/as1-oc-214_parse_error.stp
TagsNo tags attached.
Test case numberbugs/step/bug25171
Attached Files? file icon as1-oc-214_parse_error.stp (441,968 bytes) 2014-08-20 14:16
c file icon lex.step.c (50,704 bytes) 2014-08-20 14:25

- Relationships
related to 0030014verifiedbugmaster Community Data Exchange - Step File import does not create shapes, after transfer roots 

-  Notes
(0030935)
drazmyslovich (developer)
2014-08-20 14:25

Unfortunately, here I can't provide a straight-forward fix to the problem. As a temporary fix on my side I use the modified lex.step.c file, which normally generated by flex from step.lex file.
Since, I'm not that familiar with flex syntax, I would prefer somebody else to fix the original source file. While the modified lex.step.c I've attached to this ticket (all modification are marked with 0025171 string - 5 modifications in total)
(0030936)
drazmyslovich (developer)
2014-08-20 14:26

Please, check the provided modifications and fix the original source file.
(0036813)
akz (developer)
2015-01-29 13:42

The problem is that the regular expression for the text arguments (described in step.lex) does not pass the single apostrophe - ' in the text.

Current regexp for the text arguments:
[\']([\n]|[\000\011-\046\050-\176\201-\237\240-\777]|[\047][\047])*[\']
(0094722)
git (administrator)
2020-09-14 13:57

Branch CR25171 has been created by dpasukhi.

SHA-1: 48a8d0aba30d50304b0047d1975cfed7f48cf95e


Detailed log of new commits:

Author: dpasukhi
Date: Sun Sep 13 13:23:00 2020 +0300

    0025171: STEP Lexer - the strings with quote sign inside can't be properly lexed
    
    Add a test case to verify that the .STEP is read correctly

Author: dpasukhi
Date: Sun Sep 13 12:43:48 2020 +0300

    0030539: Data Exchange - Step file can't be imported (ADT.step)
    
    Add a test case to verify that the .STEP is read correctly

Author: dpasukhi
Date: Sun Sep 13 13:05:04 2020 +0300

    0031191: Data Exchange - STEP import returns empty shape for a file written by SolidWorks 2018
    
    Add a test case to verify that the .STEP is read correctly

Author: dpasukhi
Date: Sun Sep 13 13:12:16 2020 +0300

    0030014: Step File import does not create shapes, after transfer roots
    
    Add a test case to verify that the .STEP is read correctly

Author: dpasukhi
Date: Sun Sep 13 11:35:47 2020 +0300

    0025440: Data Exchange - STEP file with Japanese unicode symbols cannot be read
    
    Add a test case to verify that the .STEP is read correctly
(0094734)
dpasukhi (developer)
2020-09-14 14:38

Fix included in branch CR30848_3 is reviewed, tested and integrated.
Test cases ( with related issues ) added to verify that the .STEP is read correctly.
(0094824)
dpasukhi (developer)
2020-09-15 12:51
edited on: 2020-09-18 11:07

Dear Irina,
please review CR25171/
All tests are Ok. NO regressions/
Related issues:
 - #0025440
 - 0030014
 - #0031191
 - #0030539
Fix included in 0030848.

(0094981)
git (administrator)
2020-09-17 20:56

Branch CR25171 has been updated forcibly by dpasukhi.

SHA-1: 1c393bbf3c9c91c593cf3a20d9365d1e601c41ab
(0095013)
ika (developer)
2020-09-18 10:59

No remarks.

Dear bugmaster,

please integrate
OCCT-CR25171
Products - NOT
(0095089)
bugmaster (administrator)
2020-09-19 17:23

Combination -
OCCT branch : IR-2020-09-18
master SHA - b0b766826118f74b9857a932b8cec8c52a25c492
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-09-18 SHA - a6486d839da1ba1383ef6cc1a1a446a172f494c7
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17528.97000000011 / 17378.390000000145 [+0.87%]
Products
Total CPU difference: 12127.32000000009 / 12079.540000000095 [+0.40%]
Windows-64-VC14:
OCCT
Total CPU difference: 18862.703125 / 18898.921875 [-0.19%]
Products
Total CPU difference: 13314.828125 / 13329.21875 [-0.11%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0095105)
git (administrator)
2020-09-20 11:13

Branch CR25171 has been deleted by inv.

SHA-1: 1c393bbf3c9c91c593cf3a20d9365d1e601c41ab

- Related Changesets
occt: master 4661dcad
Timestamp: 2020-09-13 10:23:00
Author: dpasukhi
Committer: bugmaster
Details ] Diff ]
0025171: Data Exchange - STEP Lexer - the strings with quote sign inside can't be properly lexed

Add a test case to verify that the .STEP is read correctly
add - tests/bugs/step/bug25171 Diff ] File ]

- Issue History
Date Modified Username Field Change
2014-08-20 14:16 drazmyslovich New Issue
2014-08-20 14:16 drazmyslovich Assigned To => gka
2014-08-20 14:16 drazmyslovich File Added: as1-oc-214_parse_error.stp
2014-08-20 14:25 drazmyslovich Note Added: 0030935
2014-08-20 14:25 drazmyslovich File Added: lex.step.c
2014-08-20 14:26 drazmyslovich Note Added: 0030936
2014-08-20 14:26 drazmyslovich Status new => assigned
2014-08-20 14:27 drazmyslovich Description Updated View Revisions
2014-09-26 16:21 abv Target Version 6.8.0 => 7.1.0
2015-01-29 13:42 akz Note Added: 0036813
2016-10-26 12:14 gka Target Version 7.1.0 => 7.2.0
2017-07-27 09:33 abv Target Version 7.2.0 => 7.4.0
2019-07-10 21:58 abv Target Version 7.4.0 => 7.5.0
2020-09-10 13:18 abv Relationship added related to 0030848
2020-09-10 13:38 abv Assigned To gka => dpasukhi
2020-09-14 13:57 git Note Added: 0094722
2020-09-14 14:38 dpasukhi Note Added: 0094734
2020-09-15 12:51 dpasukhi Note Added: 0094824
2020-09-15 12:51 dpasukhi Assigned To dpasukhi => ika
2020-09-15 12:51 dpasukhi Status assigned => resolved
2020-09-15 12:51 dpasukhi Steps to Reproduce Updated View Revisions
2020-09-17 20:56 git Note Added: 0094981
2020-09-18 09:54 kgv Summary STEP Lexer - the strings with quote sign inside can't be properly lexed => Data Exchange, STEP Lexer - the strings with quote sign inside can't be properly lexed
2020-09-18 10:59 ika Note Added: 0095013
2020-09-18 10:59 ika Assigned To ika => bugmaster
2020-09-18 10:59 ika Status resolved => reviewed
2020-09-18 11:07 dpasukhi Note Edited: 0094824 View Revisions
2020-09-18 11:19 ika Relationship added related to 0025440
2020-09-18 11:21 ika Relationship added related to 0030014
2020-09-18 11:21 ika Relationship added related to 0031191
2020-09-18 11:22 ika Relationship added related to 0030539
2020-09-19 15:52 bugmaster Test case number => bugs/step/bug25171
2020-09-19 17:23 bugmaster Note Added: 0095089
2020-09-19 17:23 bugmaster Status reviewed => tested
2020-09-20 10:55 bugmaster Changeset attached => occt master 4661dcad
2020-09-20 10:55 bugmaster Status tested => verified
2020-09-20 10:55 bugmaster Resolution open => fixed
2020-09-20 11:13 git Note Added: 0095105


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker