View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024905Open CASCADEOCCT:Modeling Algorithmspublic2014-05-07 16:282018-10-28 16:13
ReporterszvAssigned Toapn  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version6.7.1 
Target Version7.4.0Fixed in Version7.4.0 
Summary0024905: Boolean cut produced invalid result
DescriptionCutting of two mutually inclined cylinders produces an invalid shape.
Steps To Reproducepload MODELING DATAEXCHANGE
circle c1 0 0 0 0 -1 0 75
circle c2 0 0 0 0 -1 0 65
mkedge c1 c1
mkedge c2 c2
wire c1 c1
wire c2 c2
orientation c2 R
mkplane f1 c1 1
add c2 f1
prism p1 f1 0 1000 0
trotate p1 0 0 0 0 0 1 180
circle c3 50 500 -2000 0 0 1 50
mkedge c3 c3
wire c3 c3
mkplane f2 c3 1
prism p2 f2 0 0 4000
trotate p2 0 500 0 1 0 0 -77
#trotate p2 0 500 0 0 1 0 0
trotate p2 0 0 0 0 0 1 180
bcut r1 p1 p2
checkshape r1
TagsNo tags attached.
Test case numberbugs modalg_7 bug24905

Relationships

parent of 0026509 closedapn Intersection algorithm produces set of curves providing closed contour in 3D-space and not closed contour in 2D-space 

Activities

git

2018-10-23 14:08

administrator   ~0080229

Branch CR24905 has been created by nbv.

SHA-1: 5523a3a6a2a265960a1e995e8ac41f2354fd32d4


Detailed log of new commits:

Author: nbv
Date: Tue Oct 23 14:07:11 2018 +0300

    0024905: Boolean cut produced invalid result
    
    The method BOPAlgo_PaveFiller::PutClosingPaveOnCurve(...) has been improved in order to take into account extended vertex tolerance.

git

2018-10-23 18:53

administrator   ~0080242

Branch CR24905 has been updated by nbv.

SHA-1: 6e910e5c3d343852c4b99ebdcb8ca24d6f302e9d


Detailed log of new commits:

Author: nbv
Date: Tue Oct 23 18:52:32 2018 +0300

    # Test case has been created

nbv

2018-10-24 09:39

developer   ~0080249

Dear Eugeny,

Please review the current state of CR24905 branch.

Test results are here: http://jenkins-test-12.nnov.opencascade.com/view/CR24905-master_NBV/

emv

2018-10-24 10:03

developer   ~0080251

Since it was me who developed the patch, it will be better if Mikhail will take a look at the code.
I have only one remark for the test case:
- combine all "checkshape" and "bopargcheck" checks into one cycle:
foreach r {r_0 r_1 r_2 r_3 r_4} {
  checkshape $r
  if {[regexp "Faulties" [bopargcheck $f]]} {
    puts "Error: bopargcheck has found some faulties in $r"
  }
}

msv

2018-10-24 11:07

developer   ~0080254

In addition to the remark of Eugeny:

tests/bugs/modalg_7/bug24905
- wrong header

git

2018-10-24 11:50

administrator   ~0080262

Branch CR24905 has been updated by nbv.

SHA-1: 9bf3eeb6f261b8ac98bda9e4235ca300e4b84739


Detailed log of new commits:

Author: nbv
Date: Wed Oct 24 11:48:44 2018 +0300

    # Correction in the test case

nbv

2018-10-24 12:07

developer   ~0080264

Done.

Dear Mikhail,

Please review the branch CR24905 again.

msv

2018-10-24 12:22

developer   ~0080266

Reviewed.

apn

2018-10-24 12:33

administrator   ~0080267

Combination -
OCCT branch : CR24905 SHA - 5523a3a6a2a265960a1e995e8ac41f2354fd32d4
Products branch : master SHA - 35af85def09c66ceeaf90b4e4fb8b54e68d5e98c
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

Test case:
bugs modalg_7 bug24905 - OK

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17652.459999999825 / 17520.90999999988 [+0.75%]
Products
Total CPU difference: 7444.570000000064 / 7462.09000000004 [-0.23%]
Windows-64-VC14:
OCCT
Total CPU difference: 17620.90575379838 / 17666.582846598394 [-0.26%]
Products
Total CPU difference: 8337.036642199979 / 8372.402068899986 [-0.42%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2018-10-28 16:13

administrator   ~0080411

Branch CR24905 has been deleted by inv.

SHA-1: 9bf3eeb6f261b8ac98bda9e4235ca300e4b84739

Related Changesets

occt: master a8b8f90d

2018-10-23 11:07:11

nbv


Committer: apn Details Diff		 0024905: Boolean cut produced invalid result

The method BOPAlgo_PaveFiller::PutClosingPaveOnCurve(...) has been improved in order to take into account extended vertex tolerance.		 Affected Issues
0024905
mod - src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx Diff File
add - tests/bugs/modalg_7/bug24905 Diff File

Issue History

Date Modified Username Field Change
2014-05-07 16:28 szv New Issue
2014-05-07 16:28 szv Assigned To => ifv
2014-05-23 12:25 ifv Assigned To ifv => pkv
2014-05-23 12:25 ifv Status new => assigned
2014-09-12 14:07 abv Target Version => 7.1.0
2015-07-31 13:33 pkv Relationship added parent of 0026509
2016-10-25 17:42 msv Assigned To pkv =>
2016-10-25 17:42 msv Steps to Reproduce Updated
2016-10-25 17:43 msv Assigned To => msv
2016-10-25 17:43 msv Target Version 7.1.0 => 7.2.0
2017-07-24 09:33 msv Target Version 7.2.0 => 7.3.0
2017-12-05 17:08 msv Target Version 7.3.0 => 7.4.0
2018-10-23 14:08 git Note Added: 0080229
2018-10-23 18:53 git Note Added: 0080242
2018-10-24 09:39 nbv Note Added: 0080249
2018-10-24 09:39 nbv Assigned To msv => emv
2018-10-24 09:39 nbv Status assigned => resolved
2018-10-24 10:03 emv Note Added: 0080251
2018-10-24 10:03 emv Assigned To emv => msv
2018-10-24 11:07 msv Note Added: 0080254
2018-10-24 11:07 msv Assigned To msv => nbv
2018-10-24 11:07 msv Status resolved => assigned
2018-10-24 11:50 git Note Added: 0080262
2018-10-24 12:07 nbv Note Added: 0080264
2018-10-24 12:07 nbv Assigned To nbv => msv
2018-10-24 12:07 nbv Status assigned => resolved
2018-10-24 12:22 msv Note Added: 0080266
2018-10-24 12:22 msv Assigned To msv => bugmaster
2018-10-24 12:22 msv Status resolved => reviewed
2018-10-24 12:33 apn Test case number => bugs modalg_7 bug24905
2018-10-24 12:33 apn Note Added: 0080267
2018-10-24 12:33 apn Status reviewed => tested
2018-10-28 13:20 apn Changeset attached => occt master a8b8f90d
2018-10-28 13:20 apn Assigned To bugmaster => apn
2018-10-28 13:20 apn Status tested => verified
2018-10-28 13:20 apn Resolution open => fixed
2018-10-28 16:13 git Note Added: 0080411