View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0024761 | Open CASCADE | OCCT:Coding | public | 2014-03-24 16:55 | 2014-11-11 12:51 |
| Reporter | Assigned To | apn | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | x64 | OS | Windows | ||
| Product Version | 6.7.0 | ||||
| Target Version | 6.8.0 | Fixed in Version | 6.8.0 | ||
| Summary | 0024761: Convertation of the generic classes to the non-generic. Part 5 | ||||
| Description | 1) Generic class "GccEnt_QualifiedCurv" from "GccEnt" package converted to the non-generic class and moved to the "Geom2dGcc" package. Name of this class was changed to "Geom2dGcc_QCurve". 2) Generic classes "HatchGen_ElementGen", "HatchGen_ElementsGen", "HatchGen_HatchingGen" and "HatchGen_Hatcher" from "HatchGen" package converted to the non-generic classes and moved to the "Geom2dHatch" package. Names of this classes were changed to "Geom2dHatch_Element", "Geom2dHatch_Elements", "Geom2dHatch_Hatching" and "Geom2dHatch_Hatcher". Also all instantiations of the "internal" classes of this classes were moved to the "Geom2dHatch.cdl". 3) Generic classes "Extrema_GExtCC", "Extrema_GExtCC2d", "Extrema_GLocateExtCC" and "Extrema_GLocateExtCC2d" from "Extrema" package converted to the non-generic classes. Names of this classes were changed to "Extrema_ExtCC", "Extrema_ExtCC2d", "Extrema_LocateExtCC" and "Extrema_LocateExtCC2d". Also all instantiations of the "internal" classes of this classes were moved to the "Extrema.cdl". | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
| child of | 0024487 | closed | Getting rid of generic CDL classes |
|
|
Changes are ready for review in CR24761 branch. |
|
|
Dear ifv, please check patch from your point of view. |
|
|
Seems to be Ok |
|
|
Dear BugMaster, Branch CR24761 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: 40897b75ff08a7203f21026a302449c85520228f Number of compiler warnings: occt component : Linux: 27 (27 on master) Windows: 0 (0 on master) products component : Linux: 12 (12 on master) Windows: 2 (2 on master) Regressions/Differences: No regressions/differences Testing cases: Not needed Testing on Linux: Total MEMORY difference: 393410900 / 393242136 Total CPU difference: 53198.51000000003 / 57189.309999999896 Testing on Windows: Total MEMORY difference: 420624804 / 414274688 Total CPU difference: 37377.78125 / 42798.984375 There are no differences in images found by testdiff. |
|
occt: master 0b85f9a6 2014-03-20 04:19:13
Committer: apn Details Diff |
0024761: Convertation of the generic classes to the non-generic. Part 5 1) Generic class "GccEnt_QualifiedCurv" from "GccEnt" package converted to the non-generic class and moved to the "Geom2dGcc" package. Name of this class was changed to "Geom2dGcc_QCurve". 2) Generic classes "HatchGen_ElementGen", "HatchGen_ElementsGen", "HatchGen_HatchingGen" and "HatchGen_Hatcher" from "HatchGen" package converted to the non-generic classes and moved to the "Geom2dHatch" package. Names of this classes were changed to "Geom2dHatch_Element", "Geom2dHatch_Elements", "Geom2dHatch_Hatching" and "Geom2dHatch_Hatcher". Also all instantiations of the "internal" classes of this classes were moved to the "Geom2dHatch.cdl". 3) Generic classes "Extrema_GExtCC", "Extrema_GExtCC2d", "Extrema_GLocateExtCC" and "Extrema_GLocateExtCC2d" from "Extrema" package converted to the non-generic classes. Names of this classes were changed to "Extrema_ExtCC", "Extrema_ExtCC2d", "Extrema_LocateExtCC" and "Extrema_LocateExtCC2d". Also all instantiations of the "internal" classes of this classes were moved to the "Extrema.cdl". |
Affected Issues 0024761 |
|
| mod - src/Extrema/Extrema.cdl | Diff File | ||
| mod - src/GccEnt/GccEnt.cdl | Diff File | ||
| mod - src/Geom2dGcc/Geom2dGcc.cdl | Diff File | ||
| mod - src/Geom2dGcc/Geom2dGcc_Circ2d2TanOn.cxx | Diff File | ||
| mod - src/Geom2dGcc/Geom2dGcc_Circ2d2TanRad.cxx | Diff File | ||
| mod - src/Geom2dGcc/Geom2dGcc_Circ2d3Tan.cxx | Diff File | ||
| mod - src/Geom2dGcc/Geom2dGcc_Circ2dTanCen.cxx | Diff File | ||
| mod - src/Geom2dGcc/Geom2dGcc_Circ2dTanOnRad.cxx | Diff File | ||
| mod - src/Geom2dGcc/Geom2dGcc_Lin2d2Tan.cxx | Diff File | ||
| mod - src/Geom2dGcc/Geom2dGcc_Lin2dTanObl.cxx | Diff File | ||
| mod - src/Geom2dHatch/Geom2dHatch.cdl | Diff File | ||
| mod - src/HatchGen/HatchGen.cdl | Diff File | ||
| mod - src/QABugs/QABugs_17.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-03-24 16:55 |
|
New Issue | |
| 2014-03-24 16:55 |
|
Assigned To | => abv |
| 2014-03-24 16:59 |
|
Note Added: 0028454 | |
| 2014-03-24 16:59 |
|
Status | new => resolved |
| 2014-03-27 21:51 | kgv | Note Added: 0028521 | |
| 2014-03-27 21:51 | kgv | Assigned To | abv => ifv |
| 2014-03-28 16:46 |
|
Note Added: 0028547 | |
| 2014-03-28 16:46 |
|
Status | resolved => reviewed |
| 2014-03-28 18:32 |
|
Assigned To | ifv => mkv |
| 2014-04-01 12:54 |
|
Note Added: 0028583 | |
| 2014-04-01 12:55 |
|
Test case number | => Not needed |
| 2014-04-01 12:55 |
|
Assigned To | mkv => bugmaster |
| 2014-04-01 12:55 |
|
Status | reviewed => tested |
| 2014-04-04 14:00 |
|
Target Version | 6.7.1 => 6.8.0 |
| 2014-04-04 17:03 | apn | Changeset attached | => occt master 0b85f9a6 |
| 2014-04-04 17:03 | apn | Assigned To | bugmaster => apn |
| 2014-04-04 17:03 | apn | Status | tested => verified |
| 2014-04-04 17:03 | apn | Resolution | open => fixed |
| 2014-04-10 14:47 | kgv | Relationship added | child of 0024487 |
| 2014-11-11 12:47 |
|
Fixed in Version | => 6.8.0 |
| 2014-11-11 12:51 |
|
Status | verified => closed |
