MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0024752Open CASCADE[OCCT] OCCT:Visualizationpublic2014-03-22 17:202017-08-16 14:15
Reporterkgv 
Assigned Tobugmaster 
PrioritynormalSeverityintegration request 
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version[OCCT] 6.7.0 
Target Version[OCCT] 6.8.0Fixed in Version[OCCT] 6.8.0 
Summary0024752: Visualization - inherit OpenGl_Group from Graphic3d_Group
DescriptionOpenGl_Group is logically specialization of Graphic3d_Group, but stored as pointer in it by current design.
Additional information
and documentation updates
Graphic3d_Group is now abstract class and should be instantiated using Graphic3d_Structure::NewGroup() method.
TagsNo tags attached.
Test case numberNot needed
Attached Files

- Relationships
related to 0024704closedbugmaster Open CASCADE Visualization - inherit OpenGl_Structure from Graphic3d_CStructure 
related to 0028990newkgv Community class Prs3d_Root can be removed 
child of 0023117closedbugmaster Open CASCADE TKV3d and TKOpenGl code clean-up 

-  Notes
(0028434)
kgv (developer)
2014-03-23 14:57

Patch is ready for review in CR24752_1 branch (history in CR24752).
(0028469)
apl (developer)
2014-03-25 15:56

Dear Bugmaster,

The branch is reviewed, please test.
(0028476)
mkv (tester)
2014-03-25 19:07

Dear BugMaster,

Branch CR24752_1 (and products from GIT master) was compiled on Linux and Windows platforms.
SHA-1: 8ef37163242ba68aeebb9447af44934bde82ea86

There are compilation errors on Linux platform:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24752_1/job/mnt-CR24752_1-master_build_occt_linux/1/parsed_console/? [^]

from ../../../../drv/AIS/AIS_DataMapIteratorOfDataMapOfSelStat_0.cxx:12:
../../../../inc/Handle_Prs3d_Presentation.hxx:17:42: error: Handle_Graphic3d_Structure.hxx: No such file or directory
error: Graphic3d_NameOfMaterial.hxx: No such file or directory

../../../../inc/PrsMgr_PresentationManager.hxx:20:49: error: Handle_Graphic3d_StructureManager.hxx: No such file or directory

../../../../inc/Prs3d_Presentation.hxx:20:35: error: Graphic3d_Structure.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:32:53: error: Handle_Graphic3d_DataStructureManager.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:47:38: error: Handle_Graphic3d_Group.hxx: No such file or directory

....
(0028486)
kgv (developer)
2014-03-26 13:04

Please re-test updated branch.
(0028510)
mkv (tester)
2014-03-27 14:30

Dear BugMaster,

Branch CR24752_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 50b08e9efae2667f98513bdaa9a43afd80761d82

Number of compiler warnings:

occt component :
Linux: 29 (29 on master)
Windows: 0 (0 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 390736656 / 391480644
Total CPU difference: 52837.32000000001 / 51357.52999999966

Testing on Windows:
Total MEMORY difference: 434611596 / 434230736
Total CPU difference: 42828.3125 / 35761.59375

There are no differences in images found by testdiff.

- Related Changesets
occt: master b64d84be
Timestamp: 2014-03-27 13:12:18
Author: kgv
Committer: bugmaster
Details ] Diff ]
0024752: Visualization - inherit OpenGl_Group from Graphic3d_Group

Graphic3d_Group is now abstract class and should be instantiated
using Graphic3d_Structure::NewGroup() method.
Graphic3d_CGroup has been removed.

The groups list is no more duplicated within Graphic3d_Structure and OpenGl_Structure.
Removed unused/duplicated fields from Graphic3d_Group.

Prs3d_Presentation - remove redundnant field myCurrentGroup.
PrsMgr_Presentation3d::Erase(), ::Clear() - avoid possible NULL dereference.
OpenGl_GraphicDriver/Graphic3d_GraphicDriver - group management methods have been removed
(moved to Graphic3d_CStructure and Graphic3d_Group interfaces).

Graphic3d_Group::GroupPrimitivesAspect() - copy IsEmission flag
Fix wrong iterator
Fix compilation issues
mod - src/AIS/AIS_InteractiveObject.cxx Diff ] File ]
mod - src/Graphic3d/FILES Diff ] File ]
mod - src/Graphic3d/Graphic3d.cdl Diff ] File ]
mod - src/Graphic3d/Graphic3d_AspectMarker3d.cdl Diff ] File ]
mod - src/Graphic3d/Graphic3d_AspectMarker3d.cxx Diff ] File ]
add - src/Graphic3d/Graphic3d_CAspectMarker.hxx Diff ] File ]
add - src/Graphic3d/Graphic3d_CAspectText.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_CStructure.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_GraphicDriver.cdl Diff ] File ]
mod - src/Graphic3d/Graphic3d_GraphicDriver.cxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_Group.cdl Diff ] File ]
mod - src/Graphic3d/Graphic3d_Group.cxx Diff ] File ]
rm - src/Graphic3d/Graphic3d_Group_1.cxx Diff ] File ]
rm - src/Graphic3d/Graphic3d_Group_10.cxx Diff ] File ]
rm - src/Graphic3d/Graphic3d_Group_13.cxx Diff ] File ]
rm - src/Graphic3d/Graphic3d_Group_2.cxx Diff ] File ]
rm - src/Graphic3d/Graphic3d_Group_8.cxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_Structure.cdl Diff ] File ]
mod - src/Graphic3d/Graphic3d_Structure.cxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_Structure.pxx Diff ] File ]
mod - src/InterfaceGraphic/InterfaceGraphic_Graphic3d.hxx Diff ] File ]
mod - src/OpenGl/FILES Diff ] File ]
mod - src/OpenGl/OpenGl_AspectFace.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_AspectFace.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_AspectLine.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_AspectMarker.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_AspectText.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_CappingAlgo.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_CappingAlgo.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_GraduatedTrihedron.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_GraphicDriver.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_GraphicDriver.hxx Diff ] File ]
rm - src/OpenGl/OpenGl_GraphicDriver_3.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_GraphicDriver_713.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Group.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Group.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_SceneGeometry.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Structure.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Structure.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_Text.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Text.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_Trihedron.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Workspace_Raytrace.cxx Diff ] File ]
mod - src/Prs3d/Prs3d_Presentation.cdl Diff ] File ]
mod - src/Prs3d/Prs3d_Presentation.cxx Diff ] File ]
mod - src/PrsMgr/PrsMgr_Presentation3d.cxx Diff ] File ]
mod - src/QABugs/QABugs_PresentableObject.cxx Diff ] File ]
mod - src/StdSelect/StdSelect_ViewerSelector3d.cxx Diff ] File ]
mod - src/V3d/V3d.cxx Diff ] File ]
mod - src/V3d/V3d_CircularGrid.cxx Diff ] File ]
mod - src/V3d/V3d_DirectionalLight.cxx Diff ] File ]
mod - src/V3d/V3d_Plane.cxx Diff ] File ]
mod - src/V3d/V3d_PositionalLight.cxx Diff ] File ]
mod - src/V3d/V3d_PositionLight.cxx Diff ] File ]
mod - src/V3d/V3d_RectangularGrid.cxx Diff ] File ]
mod - src/V3d/V3d_SpotLight.cxx Diff ] File ]
mod - src/V3d/V3d_Viewer_3.cxx Diff ] File ]
mod - src/V3d/V3d_Viewer_4.cxx Diff ] File ]

- Issue History
Date Modified Username Field Change
2014-03-22 17:20 kgv New Issue
2014-03-22 17:20 kgv Assigned To => san
2014-03-22 17:20 kgv Relationship added related to 0024704
2014-03-22 17:21 kgv Relationship added child of 0023117
2014-03-22 17:21 kgv Assigned To san => kgv
2014-03-22 17:21 kgv Status new => assigned
2014-03-23 14:57 kgv Note Added: 0028434
2014-03-23 14:57 kgv Assigned To kgv => apl
2014-03-23 14:57 kgv Status assigned => resolved
2014-03-23 15:00 kgv Additional Information Updated View Revisions
2014-03-25 15:56 apl Note Added: 0028469
2014-03-25 15:56 apl Assigned To apl => bugmaster
2014-03-25 15:56 apl Status resolved => reviewed
2014-03-25 17:19 mkv Assigned To bugmaster => mkv
2014-03-25 19:07 mkv Note Added: 0028476
2014-03-25 19:07 mkv Test case number => Not needed
2014-03-25 19:07 mkv Assigned To mkv => kgv
2014-03-25 19:07 mkv Status reviewed => assigned
2014-03-26 13:04 kgv Note Added: 0028486
2014-03-26 13:04 kgv Assigned To kgv => bugmaster
2014-03-26 13:04 kgv Status assigned => resolved
2014-03-26 13:04 kgv Status resolved => reviewed
2014-03-26 16:45 mkv Assigned To bugmaster => mkv
2014-03-27 14:30 mkv Note Added: 0028510
2014-03-27 14:31 mkv Assigned To mkv => bugmaster
2014-03-27 14:31 mkv Status reviewed => tested
2014-03-28 16:38 bugmaster Changeset attached => occt master b64d84be
2014-03-28 16:38 bugmaster Status tested => verified
2014-03-28 16:38 bugmaster Resolution open => fixed
2014-04-04 11:54 abv Target Version 6.7.1 => 6.8.0
2014-04-30 09:53 kgv Relationship added parent of 0024465
2014-11-11 12:47 user533 Fixed in Version => 6.8.0
2014-11-11 12:52 user533 Status verified => closed
2017-08-16 14:15 kgv Relationship added related to 0028990


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker