View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0024557 | Open CASCADE | OCCT:WOK | public | 2014-01-22 19:01 | 2014-11-11 12:52 |
| Reporter | Assigned To | kgv | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.7.0 | ||||
| Target Version | 6.8.0 | Fixed in Version | 6.8.0 | ||
| Summary | 0024557: Improve formatting of HXX files generated by WOK | ||||
| Description | Before WOK is eliminated, we need to improve formatting of header files generated by WOK from CDL files so as to make them more readable and convenient for the future maintenance as source files: - avoid wrapping each #include statement into #ifdef -- this wrapping was intended to increase performance of compilation by preventing repetitive opening of include file, but modern compilers are optimized to handle this with plain #include and include guards inside header file (see discussions on #pragma once in Internet, e.g. http://rg3.name/201310161729.html) - add newline after each method declaration - apply OCCT formatting rules (perhaps use Uncrustify to format; the old draft version of the config file attached, to be revised) | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
| parent of | 0016488 | closed | WOK extractor incorrectly treats documentation comments with several Purpose clauses | |
| parent of | 0024974 | closed | apn | GCC compiler warnings 'backslash inside comment' |
| related to | 0024737 | closed | bugmaster | Coding - remove "br" tags from header files |
| related to | 0024740 | closed | kgv | WOK headers generation - improve syntax |
| child of | 0024002 | closed | Overall code and build procedure refactoring |
|
2014-01-22 19:01 manager |
uncrustify-occt.cfg (4,184 bytes) |
|
|
I have pushed commit removing #ifdef's around #includes in generated header files to branch CR24557 in WOK. The same change in CXX, GXX, LXX files is pushed to CR24557 branch in OCCT repo. There is some downgrade of performance of compilation: now I get full OCCT build on my machine in 37 min while before that fix it was 35 min. I suppose this expense of code being more maintainable (avoid duplicate ids) can be afforded. |
|
|
Patch CR24557_1 can be integrated after testing. |
|
|
Fix has been integrated into master of occt-wok repository |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-01-22 19:01 |
|
New Issue | |
| 2014-01-22 19:01 |
|
Assigned To | => kgv |
| 2014-01-22 19:01 |
|
File Added: uncrustify-occt.cfg | |
| 2014-01-22 19:02 |
|
Relationship added | child of 0024002 |
| 2014-03-14 08:32 |
|
Note Added: 0028268 | |
| 2014-03-14 08:32 |
|
Status | new => assigned |
| 2014-03-18 11:53 | kgv | Note Added: 0028319 | |
| 2014-03-18 11:53 | kgv | Assigned To | kgv => bugmaster |
| 2014-03-18 11:53 | kgv | Status | assigned => feedback |
| 2014-03-19 12:30 | bugmaster | Status | feedback => tested |
| 2014-03-19 12:32 | bugmaster | Note Added: 0028347 | |
| 2014-03-19 12:32 | bugmaster | Status | tested => verified |
| 2014-03-19 12:32 | bugmaster | Resolution | open => fixed |
| 2014-03-19 12:32 | bugmaster | Assigned To | bugmaster => kgv |
| 2014-03-19 14:13 | kgv | Relationship added | related to 0024737 |
| 2014-03-19 15:51 | kgv | Relationship added | related to 0024740 |
| 2014-04-04 11:54 |
|
Target Version | 6.7.1 => 6.8.0 |
| 2014-05-05 09:08 | kgv | Relationship added | related to 0016488 |
| 2014-05-05 09:08 | kgv | Relationship replaced | parent of 0016488 |
| 2014-05-29 16:38 |
|
Relationship added | parent of 0024974 |
| 2014-11-11 12:46 |
|
Fixed in Version | => 6.8.0 |
| 2014-11-11 12:52 |
|
Status | verified => closed |
