View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024538Open CASCADEOCCT:Modeling Algorithmspublic2014-01-16 14:142014-11-11 12:51
ReporterabvAssigned Toabv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version6.7.0 
Target Version6.8.0Fixed in Version6.8.0 
Summary0024538: BRepFill_CompatibleWires.cxx, implementation of function PlaneOfWire() is suboptimal
DescriptionIn BRepFill_CompatibleWires.cxx, implementation of function PlaneOfWire() can be improved to optimize calculation of barycenter (Bary):

- use TopoDS_Iterator to check that wire contains only one edge (instead of BRepTools_WireExplorer)
- check wire closure and take curve from edge only if that edge is only one
- do not call BRepGProp::LinearProperties() if Bary is taken from curve

(This has been noticed by post-factum review of 0024532)
TagsNo tags attached.
Test case numberNot needed

Relationships

child of 0024532 closedbugmaster BRepOffsetAPI_MakePipeShell raises an exception in a case with auxiliary guide 

Activities

aml

2014-04-08 09:01

developer   ~0028723

Last edited: 2014-04-09 10:01

 Dear ifv,
Please check current state of branch CR24538

- use TopoDS_Iterator to check that wire contains only one edge (instead of BRepTools_WireExplorer)
Done
- check wire closure and take curve from edge only if that edge is only one
Done
- do not call BRepGProp::LinearProperties() if Bary is taken from curve
Done

ifv

2014-04-09 10:23

developer   ~0028748

Ok

apn

2014-04-10 17:33

administrator   ~0028783

Dear BugMaster,

Branch CR24538 (and products from GIT master) was compiled on MacOS, Linux and Windows platforms and tested.
SHA-1: c0adc71f753a400116083aab25985c03522e1852

Number of compiler warnings:

occt component :
Linux: 21 (21 on master)
Windows: 1 (1 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 351188896 / 352026040
Total CPU difference: 48970.95999999997 / 50789.29000000014

Testing on Windows:
Total MEMORY difference: 381249888 / 381244252
Total CPU difference: 36357.4375 / 36679.046875

There are no differences in images found by testdiff.

Related Changesets

occt: master 927513c0

2014-04-07 08:09:39

abv


Committer: abv Details Diff		 0024538: BRepFill_CompatibleWires.cxx, implementation of function PlaneOfWire() is suboptimal

Implementation improvements and refactoring in PlaneOfWire() function.		 Affected Issues
0024538
mod - src/BRepFill/BRepFill_CompatibleWires.cxx Diff File

Issue History

Date Modified Username Field Change
2014-01-16 14:14 abv New Issue
2014-01-16 14:14 abv Assigned To => ifv
2014-01-16 14:14 abv Relationship added child of 0024532
2014-02-10 14:20 ifv Assigned To ifv => aml
2014-04-04 18:16 abv Target Version 6.7.1 => 6.8.0
2014-04-08 09:01 aml Note Added: 0028723
2014-04-08 09:01 aml Assigned To aml => ifv
2014-04-08 09:01 aml Status new => resolved
2014-04-09 10:01 aml Note Edited: 0028723
2014-04-09 10:23 ifv Note Added: 0028748
2014-04-09 10:23 ifv Status resolved => reviewed
2014-04-09 13:44 apn Assigned To ifv => apn
2014-04-10 17:33 apn Note Added: 0028783
2014-04-10 17:33 apn Test case number => Not needed
2014-04-10 17:33 apn Assigned To apn => bugmaster
2014-04-10 17:33 apn Status reviewed => tested
2014-04-11 14:43 abv Changeset attached => occt master 927513c0
2014-04-11 14:43 abv Assigned To bugmaster => abv
2014-04-11 14:43 abv Status tested => verified
2014-04-11 14:43 abv Resolution open => fixed
2014-11-11 12:47 aiv Fixed in Version => 6.8.0
2014-11-11 12:51 aiv Status verified => closed