0024508: Suspect shadowed variable in BRepFeat_MakeLinearForm.cxx

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0024508

Community

[OCCT] OCCT:Modeling Algorithms

public

2014-01-02 01:42

2017-05-28 18:17

Reporter

barbier

Assigned To

ifv

Priority

normal

Severity

minor

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

[OCCT] 6.9.0

Summary

0024508: Suspect shadowed variable in BRepFeat_MakeLinearForm.cxx

Description

Hello,

Lines 314-336 look like (Sliding is of type Standard_Boolean):

  if(Sliding) {
    Standard_Boolean Sliding = Standard_False;
    Handle(Geom_Surface) s = BRep_Tool::Surface(FirstFace);
    if (s->DynamicType() ==
    STANDARD_TYPE(Geom_RectangularTrimmedSurface)) {
      s = Handle(Geom_RectangularTrimmedSurface)::
    DownCast(s)->BasisSurface();
    }
    if(s->DynamicType() == STANDARD_TYPE(Geom_Plane) ||
       s->DynamicType() == STANDARD_TYPE(Geom_CylindricalSurface)) {
      // if plane or cylinder : sliding is possible
      Sliding = Standard_True;
    }
  }

  if(Sliding) {
  ...

But another Sliding variable is defined in the inner scope, and thus it is not modified in the outer scope.

Tags

No tags attached.

Test case number

Attached Files

Relationships

related to

0025734

closed

bugmaster

Open CASCADE

GCC warnings in Android build

Notes
(0066687) abv (manager) 2017-05-28 18:17	Fixed by 0025734

Issue History
Date Modified	Username	Field	Change
2014-01-02 01:42	barbier	New Issue
2014-01-02 01:42	barbier	Assigned To	=> ifv
2017-05-28 18:16	abv	Relationship added	related to 0025734
2017-05-28 18:17	abv	Note Added: 0066687
2017-05-28 18:17	abv	Status	new => closed
2017-05-28 18:17	abv	Fixed in Version	=> 6.9.0
2017-05-28 18:17	abv	Resolution	open => fixed