View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0024320 | Open CASCADE | OCCT:Visualization | public | 2013-11-05 15:28 | 2014-11-11 12:51 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.7.0 | ||||
| Target Version | 6.8.0 | Fixed in Version | 6.8.0 | ||
| Summary | 0024320: TKOpenGl, Ray Tracing - OpenGL resources created for OpenCL interconnection should be managed in common way | ||||
| Description | Currently OpenGl_Workspace::myRaytraceOutputTexture managed as pure GL resource. It is more convenient to use OpenGl_Resource hierarchy (and probably OpenGl_Texture) for consistency. In particular - OpenGL device lost state (OpenGl_Context::IsValid()) should be checked before resource destruction to prevent possible access violations in system OpenGL drivers. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Dear apl, the patch is ready (branch CR24320_1). Please review. |
|
|
Dear Bugmaster, The branch is reviewed. No remarks. Please test. |
|
|
Dear BugMaster, Branch R24320_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: 33bbf2b4e15d9f9665273086067ac02aef6cb327 Number of compiler warnings: occt component : Linux: 109 (103 on master) OpenGl_RectangleTexture.hxx:235, GNU C Compiler 4 (gcc), Priority: Normal when initialized here OpenGl_RectangleTexture.hxx:245, GNU C Compiler 4 (gcc), Priority: Normal ‘GLint OpenGl_TextureFormat::myInternal’ OpenGl_RectangleTexture.hxx:248, GNU C Compiler 4 (gcc), Priority: Normal ‘OpenGl_TextureFormat::myChannels’ will be initialized after OpenGl_RectangleTexture.hxx:371, GNU C Compiler 4 (gcc), Priority: Normal ‘GLsizei OpenGl_RectangleTexture::mySizeX’ OpenGl_RectangleTexture.hxx:377, GNU C Compiler 4 (gcc), Priority: Normal ‘OpenGl_RectangleTexture::myFormat’ will be initialized afte OpenGl_RectangleTexture.cxx:67, GNU C Compiler 4 (gcc), Priority: Normal when initialized here Windows: 0 (0 on master) products component : Linux: 21 (21 on master) Windows: 1 (1 on master) Regressions/Differences: http://occt-tests/CR24320-1-master-occt/Windows-32-VC9/summary.html bugs vis bug280_2 bug280_3 bug349 bug349_1 bug23654_MarkersRecompute bug23670_2 caf bugs B6 caf presentation A4 v3d glsl phong_views xml ocaf_std B6 xml ocaf_xml B6 Testing cases: Not needed Testing on Linux: Total MEMORY difference: 359681432 / 359763168 Total CPU difference: 43270.020000000135 / 44230.10000000008 Testing on Windows: Total MEMORY difference: 413773372 / 412248164 Total CPU difference: 30424.25 / 34843.90625 There are not differences in images found by testdiff. |
|
|
Dear apl, bug with resource releasing was fixed. Please review (CR24320). |
|
|
Dear bugmaster, The branch CR24320 reviewed. Please test. |
|
|
Dear BugMaster, Branch CR24320 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: 077ffeb2e7812ff7a83cde9b01242a2fd464db61 Number of compiler warnings: occt component : Linux: 108 (104 on master) Windows: 1 (1 on master) New additional warning compilation on Linux platform: http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/A_mnt_warnings/job/mnt-CR24320-master_build_occt_linux/1/warnings16Result/package.-133837126/file.716362236/ OpenGl_RectangleTexture.cxx:67, GNU C Compiler 4 (gcc), Priority: Normal when initialized here products component : Linux: 21 (21 on master) Windows: 2 (2 on master) Regressions/Differences: No regressions/differences Testing cases: Not needed Testing on Linux: Total MEMORY difference: 358565612 / 358548164 Total CPU difference: 44700.67000000003 / 42225.03000000006 Testing on Windows: Total MEMORY difference: 413567908 / 412794016 Total CPU difference: 29659.640625 / 31506.421875 There are not differences in images found by testdiff. |
|
|
Dear kgv, the patch is ready. Please review (branch CR24320). |
|
|
Dear Bugmaster, patch is ready for testing in CR24320 branch. |
|
|
Dear BugMaster, Branch CR24320 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: 2c5333b26421712ae45051f8f9f31f8ea1fe9013 Number of compiler warnings: occt component : Linux: 55 (55 on master) Windows: 1 (1 on master) products component : Linux: 20 (20 on master) Windows: 2 (2 on master) Regressions/Differences: No regressions/differences Testing cases: Not needed Testing on Linux: Total MEMORY difference: 358078752 / 357072716 Total CPU difference: 44042.620000000155 / 42990.47999999986 Testing on Windows: Total MEMORY difference: 413638640 / 412488216 Total CPU difference: 31345.328125 / 32601.78125 There are not differences in images found by testdiff. |
|
occt: master 68333c8f 2014-01-14 09:05:08
Committer: bugmaster Details Diff |
0024320: TKOpenGl, Ray Tracing - OpenGL resources created for OpenCL interconnection should be managed in common way |
Affected Issues 0024320 |
|
| mod - src/OpenGl/OpenGl_Texture.cxx | Diff File | ||
| mod - src/OpenGl/OpenGl_Texture.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_Workspace.cxx | Diff File | ||
| mod - src/OpenGl/OpenGl_Workspace.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_Workspace_Raytrace.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-11-05 15:28 | kgv | New Issue | |
| 2013-11-05 15:28 | kgv | Assigned To | => san |
| 2013-11-05 15:28 | kgv | Relationship added | related to 0024130 |
| 2013-11-05 15:29 | kgv | Relationship added | related to 0024228 |
| 2013-11-05 15:30 | kgv | Assigned To | san => dbp |
| 2013-11-05 15:30 | kgv | Product Version | 7.0.0 => 6.7.0 |
| 2013-12-26 14:59 |
|
Note Added: 0027351 | |
| 2013-12-26 14:59 |
|
Assigned To | dbp => apl |
| 2013-12-26 14:59 |
|
Status | new => resolved |
| 2013-12-26 16:48 |
|
Note Added: 0027354 | |
| 2013-12-26 16:48 |
|
Assigned To | apl => bugmaster |
| 2013-12-26 16:48 |
|
Status | resolved => reviewed |
| 2013-12-26 17:24 | apn | Assigned To | bugmaster => apn |
| 2013-12-27 13:15 | apn | Note Added: 0027364 | |
| 2013-12-27 13:15 | apn | Note Edited: 0027364 | |
| 2013-12-27 13:15 | apn | Test case number | => Not needed |
| 2013-12-27 13:15 | apn | Assigned To | apn => dbp |
| 2013-12-27 13:15 | apn | Status | reviewed => assigned |
| 2013-12-27 17:36 |
|
Note Added: 0027368 | |
| 2013-12-27 17:36 |
|
Assigned To | dbp => apl |
| 2013-12-27 17:36 |
|
Status | assigned => resolved |
| 2014-01-08 09:39 |
|
Note Added: 0027389 | |
| 2014-01-08 09:39 |
|
Assigned To | apl => bugmaster |
| 2014-01-08 09:39 |
|
Status | resolved => reviewed |
| 2014-01-08 10:31 |
|
Assigned To | bugmaster => mkv |
| 2014-01-09 11:40 |
|
Note Added: 0027413 | |
| 2014-01-09 11:41 |
|
Assigned To | mkv => dbp |
| 2014-01-09 11:41 |
|
Status | reviewed => assigned |
| 2014-01-14 12:18 |
|
Note Added: 0027467 | |
| 2014-01-14 12:18 |
|
Assigned To | dbp => kgv |
| 2014-01-14 12:18 |
|
Status | assigned => resolved |
| 2014-01-14 13:56 | kgv | Note Added: 0027472 | |
| 2014-01-14 13:56 | kgv | Assigned To | kgv => bugmaster |
| 2014-01-14 13:56 | kgv | Status | resolved => reviewed |
| 2014-01-14 14:33 |
|
Assigned To | bugmaster => mkv |
| 2014-01-15 07:47 |
|
Note Added: 0027483 | |
| 2014-01-15 07:47 |
|
Assigned To | mkv => bugmaster |
| 2014-01-15 07:47 |
|
Status | reviewed => tested |
| 2014-01-21 11:22 | bugmaster | Changeset attached | => occt master 68333c8f |
| 2014-01-21 11:22 | bugmaster | Status | tested => verified |
| 2014-01-21 11:22 | bugmaster | Resolution | open => fixed |
| 2014-04-04 12:44 |
|
Target Version | 6.7.1 => 6.8.0 |
| 2014-11-11 12:47 |
|
Fixed in Version | => 6.8.0 |
| 2014-11-11 12:51 |
|
Status | verified => closed |
